Add missing Data space type in qlikcloud (#21698)

* Add missing `Data` space type in qlikcloud * Fix broken json files
2025-06-27 04:22:05 +00:00 · 2025-06-13 03:19:10 +05:30 · 2025-06-13 03:19:10 +05:30 · 2803e62f0b
commit 2803e62f0b
parent d20d278c4b
21 changed files with 29 additions and 91 deletions
--- a/ingestion/src/metadata/ingestion/source/dashboard/qlikcloud/metadata.py
+++ b/ingestion/src/metadata/ingestion/source/dashboard/qlikcloud/metadata.py
@ -134,6 +134,12 @@ class QlikcloudSource(QliksenseSource):
            if self.filter_draft_dashboard(dashboard):
                # Skip unpublished dashboards
                continue
+            if dashboard.space_id not in self.projects_map:
+                logger.warning(
+                    f"Project ID '{dashboard.space_id}' for Dashboard '{dashboard.name}' is not present"
+                    " in projects map"
+                )
+                continue
            project = self.projects_map[dashboard.space_id]
            if self.filter_projects_by_type(project):
                # Skip dashboard based on space type filter
--- a/ingestion/src/metadata/ingestion/source/dashboard/qlikcloud/models.py
+++ b/ingestion/src/metadata/ingestion/source/dashboard/qlikcloud/models.py
@ -21,6 +21,7 @@ class QlikSpaceType(Enum):
    MANAGED = "Managed"
    SHARED = "Shared"
    PERSONAL = "Personal"
+    DATA = "Data"


 # Space Models
--- a/openmetadata-docs/content/v1.7.x/connectors/dashboard/qlikcloud/index.md
+++ b/openmetadata-docs/content/v1.7.x/connectors/dashboard/qlikcloud/index.md
@ -47,7 +47,7 @@ To deploy OpenMetadata, check the Deployment guides.

 - **Qlik Cloud Host Port**: This field refers to the base url of your Qlik Cloud Portal, will be used for generating the redirect links for dashboards and charts. Example: `https://<TenantURL>.qlikcloud.com`
 - **Qlik Cloud API Token**: Enter the API token for Qlik Cloud APIs access. Refer to [this](https://help.qlik.com/en-US/cloud-services/Subsystems/Hub/Content/Sense_Hub/Admin/mc-generate-api-keys.htm) document for more details about. Example: `eyJhbGciOiJFU***`.
- **Qlik Cloud Space Types**: Select relevant space types of Qlik Cloud to filter the dashboards ingested into the platform. Example: `Personal`, `Shared`, `Managed`.
+- **Qlik Cloud Space Types**: Select relevant space types of Qlik Cloud to filter the dashboards ingested into the platform. Example: `Personal`, `Shared`, `Managed`, `Data`.

 {% /extraContent %}

--- a/openmetadata-docs/content/v1.7.x/connectors/dashboard/qlikcloud/yaml.md
+++ b/openmetadata-docs/content/v1.7.x/connectors/dashboard/qlikcloud/yaml.md
@ -81,7 +81,7 @@ Example: `https://<TenantURL>.qlikcloud.com`

 Select relevant space types of Qlik Cloud to filter the dashboards ingested into the platform.

-Example: `Personal`, `Shared`, `Managed`
+Example: `Personal`, `Shared`, `Managed`, `Data`

 {% /codeInfo %}

@ -111,7 +111,7 @@ source:
      hostPort: https://<TenantURL>.qlikcloud.com
 ```
 ```yaml {% srNumber=3 %}
-      spaceTypes: ["Personal", "Shared", "Managed"]
+      spaceTypes: ["Personal", "Shared", "Managed", "Data"]
 ```

 {% partial file="/v1.7/connectors/yaml/dashboard/source-config.md" /%}
--- a/openmetadata-docs/content/v1.8.x-SNAPSHOT/connectors/dashboard/qlikcloud/index.md
+++ b/openmetadata-docs/content/v1.8.x-SNAPSHOT/connectors/dashboard/qlikcloud/index.md
@ -47,7 +47,7 @@ To deploy OpenMetadata, check the Deployment guides.

 - **Qlik Cloud Host Port**: This field refers to the base url of your Qlik Cloud Portal, will be used for generating the redirect links for dashboards and charts. Example: `https://<TenantURL>.qlikcloud.com`
 - **Qlik Cloud API Token**: Enter the API token for Qlik Cloud APIs access. Refer to [this](https://help.qlik.com/en-US/cloud-services/Subsystems/Hub/Content/Sense_Hub/Admin/mc-generate-api-keys.htm) document for more details about. Example: `eyJhbGciOiJFU***`.
- **Qlik Cloud Space Types**: Select relevant space types of Qlik Cloud to filter the dashboards ingested into the platform. Example: `Personal`, `Shared`, `Managed`.
+- **Qlik Cloud Space Types**: Select relevant space types of Qlik Cloud to filter the dashboards ingested into the platform. Example: `Personal`, `Shared`, `Managed`, `Data`.

 {% /extraContent %}

--- a/openmetadata-docs/content/v1.8.x-SNAPSHOT/connectors/dashboard/qlikcloud/yaml.md
+++ b/openmetadata-docs/content/v1.8.x-SNAPSHOT/connectors/dashboard/qlikcloud/yaml.md
@ -81,7 +81,7 @@ Example: `https://<TenantURL>.qlikcloud.com`

 Select relevant space types of Qlik Cloud to filter the dashboards ingested into the platform.

-Example: `Personal`, `Shared`, `Managed`
+Example: `Personal`, `Shared`, `Managed`, `Data`

 {% /codeInfo %}

@ -111,7 +111,7 @@ source:
      hostPort: https://<TenantURL>.qlikcloud.com
 ```
 ```yaml {% srNumber=3 %}
-      spaceTypes: ["Personal", "Shared", "Managed"]
+      spaceTypes: ["Personal", "Shared", "Managed", "Data"]
 ```

 {% partial file="/v1.8/connectors/yaml/dashboard/source-config.md" /%}
--- a/openmetadata-service/src/main/resources/elasticsearch/zh/query_cost_record_index_mapping.json
+++ b/openmetadata-service/src/main/resources/elasticsearch/zh/query_cost_record_index_mapping.json
@ -410,7 +410,7 @@
                    "totalVotes": {
                        "type": "long",
                        "null_value": 0
-                    },
+                    }
                }
            },
            "service": {
--- a/openmetadata-service/src/main/resources/elasticsearch/zh/query_index_mapping.json
+++ b/openmetadata-service/src/main/resources/elasticsearch/zh/query_index_mapping.json
@ -165,85 +165,6 @@
            "type": "text"
          }
        }
-      },
-          "downVotes": {
-            "type": "long"
-          },
-          "upVoters": {
-            "properties": {
-              "id": {
-                "type": "keyword",
-                "fields": {
-                  "keyword": {
-                    "type": "keyword",
-                    "ignore_above": 36
-                  }
-                }
-              },
-              "type": {
-                "type": "keyword"
-              },
-              "name": {
-                "type": "keyword",
-                "fields": {
-                  "keyword": {
-                    "type": "keyword",
-                    "ignore_above": 256
-                  }
-                }
-              },
-              "fullyQualifiedName": {
-                "type": "text"
-              },
-              "description": {
-                "type": "text"
-              },
-              "deleted": {
-                "type": "text"
-              },
-              "href": {
-                "type": "text"
-              }
-            }
-          },
-          "downVoters": {
-            "properties": {
-              "id": {
-                "type": "keyword",
-                "fields": {
-                  "keyword": {
-                    "type": "keyword",
-                    "ignore_above": 36
-                  }
-                }
-              },
-              "type": {
-                "type": "keyword"
-              },
-              "name": {
-                "type": "keyword",
-                "fields": {
-                  "keyword": {
-                    "type": "keyword",
-                    "ignore_above": 256
-                  }
-                }
-              },
-              "fullyQualifiedName": {
-                "type": "text"
-              },
-              "description": {
-                "type": "text"
-              },
-              "deleted": {
-                "type": "text"
-              },
-              "href": {
-                "type": "text"
-              }
-            }
-          }
-        }
      },
      "query": {
        "type": "text",
@ -379,7 +300,6 @@
      "entityType": {
        "type": "keyword"
      },
-
      "tier": {
        "properties": {
          "description": {
@ -442,4 +362,4 @@
      }
    }
  }
-}
+}
--- a/openmetadata-spec/src/main/resources/json/schema/entity/services/connections/dashboard/qlikCloudConnection.json
+++ b/openmetadata-spec/src/main/resources/json/schema/entity/services/connections/dashboard/qlikCloudConnection.json
@ -40,9 +40,9 @@
        "uniqueItems": true,
        "items": {
          "type": "string",
-          "enum": ["Managed", "Shared", "Personal"]
+          "enum": ["Managed", "Shared", "Personal", "Data"]
        },
-        "default": ["Managed", "Shared", "Personal"],
+        "default": ["Managed", "Shared", "Personal", "Data"],
        "minItems": 1
      },
      "dashboardFilterPattern": {
--- a/openmetadata-ui/src/main/resources/ui/public/locales/en-US/Dashboard/QlikCloud.md
+++ b/openmetadata-ui/src/main/resources/ui/public/locales/en-US/Dashboard/QlikCloud.md
@ -37,5 +37,5 @@ $$section

 Select relevant space types of Qlik Cloud to filter the dashboards ingested into the platform.

-Example: `Personal`, `Shared`, `Managed`
+Example: `Personal`, `Shared`, `Managed`, `Data`
 $$
--- a/openmetadata-ui/src/main/resources/ui/src/generated/api/automations/createWorkflow.ts
+++ b/openmetadata-ui/src/main/resources/ui/src/generated/api/automations/createWorkflow.ts
@ -3659,6 +3659,7 @@ export enum KafkaSecurityProtocol {
 }

 export enum SpaceType {
+    Data = "Data",
    Managed = "Managed",
    Personal = "Personal",
    Shared = "Shared",
--- a/openmetadata-ui/src/main/resources/ui/src/generated/api/services/createDashboardService.ts
+++ b/openmetadata-ui/src/main/resources/ui/src/generated/api/services/createDashboardService.ts
@ -1088,6 +1088,7 @@ export interface GCPImpersonateServiceAccountValues {
 }

 export enum SpaceType {
+    Data = "Data",
    Managed = "Managed",
    Personal = "Personal",
    Shared = "Shared",
--- a/openmetadata-ui/src/main/resources/ui/src/generated/api/services/ingestionPipelines/createIngestionPipeline.ts
+++ b/openmetadata-ui/src/main/resources/ui/src/generated/api/services/ingestionPipelines/createIngestionPipeline.ts
@ -5143,6 +5143,7 @@ export enum KafkaSecurityProtocol {
 }

 export enum SpaceType {
+    Data = "Data",
    Managed = "Managed",
    Personal = "Personal",
    Shared = "Shared",
--- a/openmetadata-ui/src/main/resources/ui/src/generated/entity/automations/testServiceConnection.ts
+++ b/openmetadata-ui/src/main/resources/ui/src/generated/entity/automations/testServiceConnection.ts
@ -3541,6 +3541,7 @@ export enum KafkaSecurityProtocol {
 }

 export enum SpaceType {
+    Data = "Data",
    Managed = "Managed",
    Personal = "Personal",
    Shared = "Shared",
--- a/openmetadata-ui/src/main/resources/ui/src/generated/entity/automations/workflow.ts
+++ b/openmetadata-ui/src/main/resources/ui/src/generated/entity/automations/workflow.ts
@ -3931,6 +3931,7 @@ export enum KafkaSecurityProtocol {
 }

 export enum SpaceType {
+    Data = "Data",
    Managed = "Managed",
    Personal = "Personal",
    Shared = "Shared",
--- a/openmetadata-ui/src/main/resources/ui/src/generated/entity/services/connections/dashboard/qlikCloudConnection.ts
+++ b/openmetadata-ui/src/main/resources/ui/src/generated/entity/services/connections/dashboard/qlikCloudConnection.ts
@ -72,6 +72,7 @@ export interface FilterPattern {
 }

 export enum SpaceType {
+    Data = "Data",
    Managed = "Managed",
    Personal = "Personal",
    Shared = "Shared",
--- a/openmetadata-ui/src/main/resources/ui/src/generated/entity/services/connections/serviceConnection.ts
+++ b/openmetadata-ui/src/main/resources/ui/src/generated/entity/services/connections/serviceConnection.ts
@ -3522,6 +3522,7 @@ export enum KafkaSecurityProtocol {
 }

 export enum SpaceType {
+    Data = "Data",
    Managed = "Managed",
    Personal = "Personal",
    Shared = "Shared",
--- a/openmetadata-ui/src/main/resources/ui/src/generated/entity/services/dashboardService.ts
+++ b/openmetadata-ui/src/main/resources/ui/src/generated/entity/services/dashboardService.ts
@ -1205,6 +1205,7 @@ export interface GCPImpersonateServiceAccountValues {
 }

 export enum SpaceType {
+    Data = "Data",
    Managed = "Managed",
    Personal = "Personal",
    Shared = "Shared",
--- a/openmetadata-ui/src/main/resources/ui/src/generated/entity/services/ingestionPipelines/ingestionPipeline.ts
+++ b/openmetadata-ui/src/main/resources/ui/src/generated/entity/services/ingestionPipelines/ingestionPipeline.ts
@ -5549,6 +5549,7 @@ export enum KafkaSecurityProtocol {
 }

 export enum SpaceType {
+    Data = "Data",
    Managed = "Managed",
    Personal = "Personal",
    Shared = "Shared",
--- a/openmetadata-ui/src/main/resources/ui/src/generated/metadataIngestion/testSuitePipeline.ts
+++ b/openmetadata-ui/src/main/resources/ui/src/generated/metadataIngestion/testSuitePipeline.ts
@ -3566,6 +3566,7 @@ export enum KafkaSecurityProtocol {
 }

 export enum SpaceType {
+    Data = "Data",
    Managed = "Managed",
    Personal = "Personal",
    Shared = "Shared",
--- a/openmetadata-ui/src/main/resources/ui/src/generated/metadataIngestion/workflow.ts
+++ b/openmetadata-ui/src/main/resources/ui/src/generated/metadataIngestion/workflow.ts
@ -3613,6 +3613,7 @@ export enum KafkaSecurityProtocol {
 }

 export enum SpaceType {
+    Data = "Data",
    Managed = "Managed",
    Personal = "Personal",
    Shared = "Shared",