yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-11-03 03:59:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

#14554 test case name's length limitation-DBT (#14815)

Browse Source
This commit is contained in:
Shailesh Parmar 2024-01-22 19:12:36 +05:30 committed by GitHub
parent a9e193608c
commit 284ca34b18
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
openmetadata-ui/src/main/resources/ui/cypress/e2e/Pages/DataQualityAndProfiler.spec.js
View File

@ -956,7 +956,7 @@ describe('Data Quality and Profiler should work properly', () => {
.not('.ant-select-dropdown-hidden') .not('.ant-select-dropdown-hidden')
.find(`[title="${profilerSetting.partitionIntervalType}"]`) .find(`[title="${profilerSetting.partitionIntervalType}"]`)
.click(); .click();
cy.get('[data-testid="column-name"]').click(); cy.get('#includeColumnsProfiler_partitionColumnName').click();
cy.get('.ant-select-dropdown') cy.get('.ant-select-dropdown')
.not('.ant-select-dropdown-hidden') .not('.ant-select-dropdown-hidden')
.find(`[title="${profilerSetting.partitionColumnName}"]`) .find(`[title="${profilerSetting.partitionColumnName}"]`)

7
openmetadata-ui/src/main/resources/ui/src/components/AddDataQualityTest/components/TestCaseForm.tsx
View File

@ -305,6 +305,13 @@ const TestCaseForm: React.FC<TestCaseFormProps> = ({
pattern: ENTITY_NAME_REGEX, pattern: ENTITY_NAME_REGEX,
message: t('message.entity-name-validation'), message: t('message.entity-name-validation'),
}, },
{
max: 256,
message: t('message.entity-maximum-size', {
entity: t('label.name'),
max: 256,
}),
},
{ {
validator: (_, value) => { validator: (_, value) => {
if (testCases.some((test) => test.name === value)) { if (testCases.some((test) => test.name === value)) {

3
openmetadata-ui/src/main/resources/ui/src/components/TableProfiler/Component/TableProfilerChart.tsx
View File

@ -32,6 +32,7 @@ import { useHistory } from 'react-router-dom';
import { ReactComponent as SettingIcon } from '../../../assets/svg/ic-settings-primery.svg'; import { ReactComponent as SettingIcon } from '../../../assets/svg/ic-settings-primery.svg';
import { PAGE_HEADERS } from '../../../constants/PageHeaders.constant'; import { PAGE_HEADERS } from '../../../constants/PageHeaders.constant';
import { import {
DEFAULT_RANGE_DATA,
INITIAL_OPERATION_METRIC_VALUE, INITIAL_OPERATION_METRIC_VALUE,
INITIAL_ROW_METRIC_VALUE, INITIAL_ROW_METRIC_VALUE,
} from '../../../constants/profiler.constant'; } from '../../../constants/profiler.constant';
@ -79,7 +80,7 @@ const TableProfilerChart = ({
onSettingButtonClick, onSettingButtonClick,
isProfilingEnabled, isProfilingEnabled,
customMetric: tableCustomMetric, customMetric: tableCustomMetric,
dateRangeObject, dateRangeObject = DEFAULT_RANGE_DATA,
onDateRangeChange, onDateRangeChange,
} = useTableProfiler(); } = useTableProfiler();

1
openmetadata-ui/src/main/resources/ui/src/pages/IncidentManager/IncidentManagerDetailPage/IncidentManagerDetailPage.tsx
View File

@ -233,6 +233,7 @@ const IncidentManagerDetailPage = () => {
</Col> </Col>
<Col className="p-x-lg" data-testid="entity-page-header" span={24}> <Col className="p-x-lg" data-testid="entity-page-header" span={24}>
<EntityHeaderTitle <EntityHeaderTitle
className="w-max-full-45"
displayName={testCaseData.data?.displayName} displayName={testCaseData.data?.displayName}
icon={<TestCaseIcon className="h-9" />} icon={<TestCaseIcon className="h-9" />}
name={testCaseData.data?.name ?? ''} name={testCaseData.data?.name ?? ''}