From 289404748a49885394b4a51a9fc64ed7ec2d5af8 Mon Sep 17 00:00:00 2001 From: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com> Date: Wed, 30 Oct 2024 14:05:44 +0530 Subject: [PATCH] fix(ui): block multiple paging req while fetching data (#18436) --- .../ClassificationDetails/ClassificationDetails.tsx | 3 ++- .../Dashboard/DataModel/DataModels/DataModelsTable.tsx | 1 + .../TestSuite/TestSuiteList/TestSuites.component.tsx | 1 + .../DatabaseSchemaTable/DatabaseSchemaTable.tsx | 1 + .../TableProfiler/QualityTab/QualityTab.component.tsx | 1 + .../Glossary/GlossaryTerms/tabs/AssetsTabs.component.tsx | 1 + .../AppRunsHistory/AppRunsHistory.component.tsx | 1 + .../Settings/Bot/BotListV1/BotListV1.component.tsx | 1 + .../Ingestion/IngestionListTable/IngestionListTable.tsx | 1 + .../ui/src/components/Settings/Services/Services.tsx | 1 + .../Settings/Team/TeamDetails/UserTab/UserTab.component.tsx | 1 + .../common/NextPrevious/NextPrevious.interface.ts | 1 + .../ui/src/components/common/NextPrevious/NextPrevious.tsx | 6 ++++-- .../ui/src/pages/APICollectionPage/APIEndpointsTab.tsx | 1 + .../resources/ui/src/pages/Application/ApplicationPage.tsx | 1 + .../ui/src/pages/CustomPageSettings/CustomPageSettings.tsx | 1 + .../main/resources/ui/src/pages/DataInsightPage/KPIList.tsx | 1 + .../ui/src/pages/DatabaseSchemaPage/SchemaTablesTab.tsx | 1 + .../ui/src/pages/MarketPlacePage/MarketPlacePage.tsx | 1 + .../src/pages/MetricsPage/MetricListPage/MetricListPage.tsx | 1 + .../src/pages/NotificationListPage/NotificationListPage.tsx | 1 + .../ObservabilityAlertsPage/ObservabilityAlertsPage.tsx | 1 + .../ui/src/pages/Persona/PersonaListPage/PersonaPage.tsx | 1 + .../PoliciesPage/PoliciesListPage/PoliciesListPage.tsx | 1 + .../ui/src/pages/RolesPage/RolesListPage/RolesListPage.tsx | 1 + .../src/pages/ServiceDetailsPage/ServiceMainTabContent.tsx | 1 + .../ServiceVersionPage/ServiceVersionMainTabContent.tsx | 1 + .../ui/src/pages/StoredProcedure/StoredProcedureTab.tsx | 1 + .../resources/ui/src/pages/UserListPage/UserListPageV1.tsx | 1 + 29 files changed, 33 insertions(+), 3 deletions(-) diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Classifications/ClassificationDetails/ClassificationDetails.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Classifications/ClassificationDetails/ClassificationDetails.tsx index 30ab4a06487..4f2b4b5ef43 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Classifications/ClassificationDetails/ClassificationDetails.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/Classifications/ClassificationDetails/ClassificationDetails.tsx @@ -521,9 +521,10 @@ const ClassificationDetails = forwardRef( size="small" /> - {showPagination && !isTagsLoading && ( + {showPagination && ( { {showPagination && ( { { diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Settings/Applications/AppRunsHistory/AppRunsHistory.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Settings/Applications/AppRunsHistory/AppRunsHistory.component.tsx index aecccc6167c..a570f7dbd42 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Settings/Applications/AppRunsHistory/AppRunsHistory.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/Settings/Applications/AppRunsHistory/AppRunsHistory.component.tsx @@ -308,6 +308,7 @@ const AppRunsHistory = forwardRef( { {showPagination && ( = ({ pageSize, isNumberBased = false, currentPage = 1, + isLoading, ...pagingProps }: NextPreviousProps) => { const { t } = useTranslation(); @@ -91,7 +92,7 @@ const NextPrevious: FC = ({ ghost className="hover-button text-sm flex-center" data-testid="previous" - disabled={computePrevDisableState()} + disabled={computePrevDisableState() || isLoading} icon={} type="primary" onClick={onPreviousHandler}> @@ -105,7 +106,7 @@ const NextPrevious: FC = ({ ghost className="hover-button text-sm flex-center" data-testid="next" - disabled={computeNextDisableState()} + disabled={computeNextDisableState() || isLoading} type="primary" onClick={onNextHandler}> {t('label.next')} @@ -113,6 +114,7 @@ const NextPrevious: FC = ({ {onShowSizeChange && ( ({ label: `${size} / Page`, diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/APICollectionPage/APIEndpointsTab.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/APICollectionPage/APIEndpointsTab.tsx index af02fca7bb3..67914237e0b 100644 --- a/openmetadata-ui/src/main/resources/ui/src/pages/APICollectionPage/APIEndpointsTab.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/pages/APICollectionPage/APIEndpointsTab.tsx @@ -185,6 +185,7 @@ function APIEndpointsTab({ { {showPagination && ( { {showPagination && ( { { {showPagination && ( { {showPagination && ( { {showPagination && ( 0} pageSize={pageSize} paging={paging} pagingHandler={onPageChange} diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/ObservabilityAlertsPage/ObservabilityAlertsPage.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/ObservabilityAlertsPage/ObservabilityAlertsPage.tsx index 8bfb0e9a8fe..a50abccabe0 100644 --- a/openmetadata-ui/src/main/resources/ui/src/pages/ObservabilityAlertsPage/ObservabilityAlertsPage.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/pages/ObservabilityAlertsPage/ObservabilityAlertsPage.tsx @@ -242,6 +242,7 @@ const ObservabilityAlertsPage = () => { {showPagination && ( { { {showPagination && ( { {showPagination && ( { {showPagination && ( { {showPagination && (