From 28c76fe2e1e6543f8928ac133a9c66140f5568f0 Mon Sep 17 00:00:00 2001 From: Sriharsha Chintalapani Date: Sun, 10 Jul 2022 19:25:54 -0700 Subject: [PATCH] Fix #5092: Allow tag names to be 64 chars in length (#5986) --- .../json/schema/entity/tags/tagCategory.json | 2 +- .../catalog/resources/tags/TagResourceTest.java | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/catalog-rest-service/src/main/resources/json/schema/entity/tags/tagCategory.json b/catalog-rest-service/src/main/resources/json/schema/entity/tags/tagCategory.json index 0208de8e1af..43ce29a57ea 100644 --- a/catalog-rest-service/src/main/resources/json/schema/entity/tags/tagCategory.json +++ b/catalog-rest-service/src/main/resources/json/schema/entity/tags/tagCategory.json @@ -11,7 +11,7 @@ "description": "Name of the tag.", "type": "string", "minLength": 2, - "maxLength": 25 + "maxLength": 64 }, "tagCategoryType": { "description": "Type of tag category.", diff --git a/catalog-rest-service/src/test/java/org/openmetadata/catalog/resources/tags/TagResourceTest.java b/catalog-rest-service/src/test/java/org/openmetadata/catalog/resources/tags/TagResourceTest.java index ac3539f9327..3aa752393ef 100644 --- a/catalog-rest-service/src/test/java/org/openmetadata/catalog/resources/tags/TagResourceTest.java +++ b/catalog-rest-service/src/test/java/org/openmetadata/catalog/resources/tags/TagResourceTest.java @@ -273,7 +273,7 @@ public class TagResourceTest extends CatalogApplicationTest { // Long name create.withName(TestUtils.LONG_ENTITY_NAME).withCategoryType(TagCategoryType.Descriptive); assertResponseContains( - () -> createAndCheckCategory(create, ADMIN_AUTH_HEADERS), BAD_REQUEST, "name size must be between 2 and 25"); + () -> createAndCheckCategory(create, ADMIN_AUTH_HEADERS), BAD_REQUEST, "name size must be between 2 and 64"); } @Order(1) @@ -313,13 +313,13 @@ public class TagResourceTest extends CatalogApplicationTest { assertResponseContains( () -> createPrimaryTag(USER_TAG_CATEGORY.getName(), create, ADMIN_AUTH_HEADERS), BAD_REQUEST, - "name size must be between 2 and 25"); + "name size must be between 2 and 64"); // Long secondary tag name assertResponseContains( () -> createSecondaryTag(USER_TAG_CATEGORY.getName(), ADDRESS_TAG.getName(), create, ADMIN_AUTH_HEADERS), BAD_REQUEST, - "name size must be between 2 and 25"); + "name size must be between 2 and 64"); } @Test @@ -374,7 +374,7 @@ public class TagResourceTest extends CatalogApplicationTest { assertResponseContains( () -> updateCategory(USER_TAG_CATEGORY.getName(), create, ADMIN_AUTH_HEADERS), BAD_REQUEST, - "name size must be between 2 and 25"); + "name size must be between 2 and 64"); } @Test @@ -417,7 +417,7 @@ public class TagResourceTest extends CatalogApplicationTest { assertResponseContains( () -> updatePrimaryTag(USER_TAG_CATEGORY.getName(), ADDRESS_TAG.getName(), create, ADMIN_AUTH_HEADERS), BAD_REQUEST, - "name size must be between 2 and 25"); + "name size must be between 2 and 64"); // Long secondary tag name assertResponseContains( @@ -425,7 +425,7 @@ public class TagResourceTest extends CatalogApplicationTest { updateSecondaryTag( USER_TAG_CATEGORY.getName(), ADDRESS_TAG.getName(), "Secondary", create, ADMIN_AUTH_HEADERS), BAD_REQUEST, - "name size must be between 2 and 25"); + "name size must be between 2 and 64"); } private TagCategory createAndCheckCategory(CreateTagCategory create, Map authHeaders)