yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-08-02 06:08:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix #5092: Allow tag names to be 64 chars in length (#5986)

Browse Source
This commit is contained in:
Sriharsha Chintalapani 2022-07-10 19:25:54 -07:00 committed by GitHub
parent 930fc16ad8
commit 28c76fe2e1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
catalog-rest-service/src/main/resources/json/schema/entity/tags/tagCategory.json
View File

@ -11,7 +11,7 @@
"description": "Name of the tag.", "description": "Name of the tag.",
"type": "string", "type": "string",
"minLength": 2, "minLength": 2,
"maxLength": 25 "maxLength": 64
}, },
"tagCategoryType": { "tagCategoryType": {
"description": "Type of tag category.", "description": "Type of tag category.",

12
catalog-rest-service/src/test/java/org/openmetadata/catalog/resources/tags/TagResourceTest.java
View File

@ -273,7 +273,7 @@ public class TagResourceTest extends CatalogApplicationTest {
// Long name // Long name
create.withName(TestUtils.LONG_ENTITY_NAME).withCategoryType(TagCategoryType.Descriptive); create.withName(TestUtils.LONG_ENTITY_NAME).withCategoryType(TagCategoryType.Descriptive);
assertResponseContains( assertResponseContains(
() -> createAndCheckCategory(create, ADMIN_AUTH_HEADERS), BAD_REQUEST, "name size must be between 2 and 25"); () -> createAndCheckCategory(create, ADMIN_AUTH_HEADERS), BAD_REQUEST, "name size must be between 2 and 64");
} }
@Order(1) @Order(1)
@ -313,13 +313,13 @@ public class TagResourceTest extends CatalogApplicationTest {
assertResponseContains( assertResponseContains(
() -> createPrimaryTag(USER_TAG_CATEGORY.getName(), create, ADMIN_AUTH_HEADERS), () -> createPrimaryTag(USER_TAG_CATEGORY.getName(), create, ADMIN_AUTH_HEADERS),
BAD_REQUEST, BAD_REQUEST,
"name size must be between 2 and 25"); "name size must be between 2 and 64");
// Long secondary tag name // Long secondary tag name
assertResponseContains( assertResponseContains(
() -> createSecondaryTag(USER_TAG_CATEGORY.getName(), ADDRESS_TAG.getName(), create, ADMIN_AUTH_HEADERS), () -> createSecondaryTag(USER_TAG_CATEGORY.getName(), ADDRESS_TAG.getName(), create, ADMIN_AUTH_HEADERS),
BAD_REQUEST, BAD_REQUEST,
"name size must be between 2 and 25"); "name size must be between 2 and 64");
} }
@Test @Test
@ -374,7 +374,7 @@ public class TagResourceTest extends CatalogApplicationTest {
assertResponseContains( assertResponseContains(
() -> updateCategory(USER_TAG_CATEGORY.getName(), create, ADMIN_AUTH_HEADERS), () -> updateCategory(USER_TAG_CATEGORY.getName(), create, ADMIN_AUTH_HEADERS),
BAD_REQUEST, BAD_REQUEST,
"name size must be between 2 and 25"); "name size must be between 2 and 64");
} }
@Test @Test
@ -417,7 +417,7 @@ public class TagResourceTest extends CatalogApplicationTest {
assertResponseContains( assertResponseContains(
() -> updatePrimaryTag(USER_TAG_CATEGORY.getName(), ADDRESS_TAG.getName(), create, ADMIN_AUTH_HEADERS), () -> updatePrimaryTag(USER_TAG_CATEGORY.getName(), ADDRESS_TAG.getName(), create, ADMIN_AUTH_HEADERS),
BAD_REQUEST, BAD_REQUEST,
"name size must be between 2 and 25"); "name size must be between 2 and 64");
// Long secondary tag name // Long secondary tag name
assertResponseContains( assertResponseContains(
@ -425,7 +425,7 @@ public class TagResourceTest extends CatalogApplicationTest {
updateSecondaryTag( updateSecondaryTag(
USER_TAG_CATEGORY.getName(), ADDRESS_TAG.getName(), "Secondary", create, ADMIN_AUTH_HEADERS), USER_TAG_CATEGORY.getName(), ADDRESS_TAG.getName(), "Secondary", create, ADMIN_AUTH_HEADERS),
BAD_REQUEST, BAD_REQUEST,
"name size must be between 2 and 25"); "name size must be between 2 and 64");
} }
private TagCategory createAndCheckCategory(CreateTagCategory create, Map<String, String> authHeaders) private TagCategory createAndCheckCategory(CreateTagCategory create, Map<String, String> authHeaders)