GEN-Activity Feed Filtering (#18873)

* fix: Update configuration for activity feed.

* fix: Migrations

* remove the customProperty and testSuite feed beautification case from the feed

* fix: Remove custom properties from the source

* fix: add metric in the matchAnySource.

---------

Co-authored-by: Ashish Gupta <ashish@getcollate.io>
This commit is contained in:
Siddhant 2024-12-04 16:56:21 +05:30 committed by GitHub
parent 30196f4c8d
commit 28f551d20a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 9 additions and 31 deletions

View File

@ -55,3 +55,5 @@ where serviceType in ('Snowflake', 'Redshift', 'BigQuery');
-- Update all rows in the consumers_dlq table to set the source column to 'publisher' -- Update all rows in the consumers_dlq table to set the source column to 'publisher'
UPDATE consumers_dlq SET source = 'publisher'; UPDATE consumers_dlq SET source = 'publisher';
DELETE from event_subscription_entity where name = "ActivityFeedAlert";

View File

@ -71,3 +71,5 @@ WHERE serviceType IN ('Snowflake', 'Redshift', 'BigQuery');
-- Update all rows in the consumers_dlq table to set the source column to 'publisher' -- Update all rows in the consumers_dlq table to set the source column to 'publisher'
UPDATE consumers_dlq SET source = 'publisher'; UPDATE consumers_dlq SET source = 'publisher';
DELETE from event_subscription_entity where name = 'ActivityFeedAlert';

View File

@ -10,26 +10,20 @@
{ {
"name": "matchAnyEventType", "name": "matchAnyEventType",
"effect": "include", "effect": "include",
"condition": "matchAnyEventType({'entityCreated', 'entityDeleted', 'entitySoftDeleted'}) && !matchUpdatedBy({'ingestion-bot'}) && !matchAnySource({'user', 'ingestionPipeline', 'workflow'})", "condition": "matchAnyEventType({'entityCreated', 'entityDeleted', 'entitySoftDeleted'}) && !matchUpdatedBy({'ingestion-bot'}) && !matchAnySource({'user', 'team', 'owners', 'databaseService', 'messagingService', 'dashboardService', 'pipelineService', 'storageService', 'mlmodelService', 'metadataService', 'searchService', 'apiService', 'ingestionPipeline', 'workflow'})",
"prefixCondition": "AND" "prefixCondition": "AND"
}, },
{ {
"name": "matchAnyFieldChange", "name": "matchAnyFieldChange",
"effect": "include", "effect": "include",
"condition": "matchAnyFieldChange({'testCaseResult'})", "condition": "matchAnyFieldChange({'description', 'domain', 'owners', 'tags', 'followers','parameterValues', 'assets'})",
"prefixCondition": "OR"
},
{
"name": "matchAnyFieldChange",
"effect": "include",
"condition": "matchAnyFieldChange({'description', 'domain', 'owners', 'tags', 'followers', 'extension','parameterValues', 'assets'})",
"prefixCondition": "OR" "prefixCondition": "OR"
}, },
{ {
"name": "matchAnySource", "name": "matchAnySource",
"effect": "include", "effect": "include",
"prefixCondition": "AND", "prefixCondition": "AND",
"condition": "matchAnySource({'chart','container','dashboard','dashboardDataModel','database','databaseSchema','glossary','glossaryTerm','mlmodel','pipeline','query','report','searchIndex','storedProcedure','table','topic','testSuite','testCase', 'domain', 'dataProduct'})" "condition": "matchAnySource({'chart','container','dashboard','dashboardDataModel','database','databaseSchema','glossary','glossaryTerm','mlmodel','pipeline','query','report','searchIndex','storedProcedure','table','topic', 'domain', 'dataProduct', 'metric'})"
}, },
{ {
"name": "matchUpdatedBy", "name": "matchUpdatedBy",
@ -76,9 +70,7 @@
"owners", "owners",
"tags", "tags",
"followers", "followers",
"extension",
"parameterValues", "parameterValues",
"testCaseResult",
"pipelineStatus" "pipelineStatus"
] ]
} }
@ -108,8 +100,6 @@
"storedProcedure", "storedProcedure",
"table", "table",
"topic", "topic",
"testSuite",
"testCase",
"domain", "domain",
"dataProduct" "dataProduct"
] ]

View File

@ -29,17 +29,14 @@ import {
import { formatDateTime } from '../../../../utils/date-time/DateTimeUtils'; import { formatDateTime } from '../../../../utils/date-time/DateTimeUtils';
import entityUtilClassBase from '../../../../utils/EntityUtilClassBase'; import entityUtilClassBase from '../../../../utils/EntityUtilClassBase';
import { import {
entityDisplayName,
getEntityFQN, getEntityFQN,
getEntityType, getEntityType,
getFrontEndFormat, getFrontEndFormat,
MarkdownToHTMLConverter, MarkdownToHTMLConverter,
} from '../../../../utils/FeedUtils'; } from '../../../../utils/FeedUtils';
import ExploreSearchCard from '../../../ExploreV1/ExploreSearchCard/ExploreSearchCard'; import ExploreSearchCard from '../../../ExploreV1/ExploreSearchCard/ExploreSearchCard';
import CustomPropertyFeed from '../../ActivityFeedCardV2/FeedCardBody/CustomPropertyFeed/CustomPropertyFeed.component';
import DescriptionFeed from '../../ActivityFeedCardV2/FeedCardBody/DescriptionFeed/DescriptionFeed'; import DescriptionFeed from '../../ActivityFeedCardV2/FeedCardBody/DescriptionFeed/DescriptionFeed';
import TagsFeed from '../../ActivityFeedCardV2/FeedCardBody/TagsFeed/TagsFeed'; import TagsFeed from '../../ActivityFeedCardV2/FeedCardBody/TagsFeed/TagsFeed';
import TestCaseFeed from '../../ActivityFeedCardV2/FeedCardBody/TestCaseFeed/TestCaseFeed';
import './feed-card-body-v1.less'; import './feed-card-body-v1.less';
import { FeedCardBodyV1Props } from './FeedCardBodyV1.interface'; import { FeedCardBodyV1Props } from './FeedCardBodyV1.interface';
@ -83,15 +80,6 @@ const FeedCardBodyV1 = ({
return <TagsFeed feed={feed} />; return <TagsFeed feed={feed} />;
} }
if (cardStyle === CardStyle.TestCaseResult) {
return (
<TestCaseFeed
entitySpecificInfo={feed.feedInfo?.entitySpecificInfo}
testCaseName={entityDisplayName(entityType, entityFQN) ?? ''}
/>
);
}
if (ASSET_CARD_STYLES.includes(cardStyle as CardStyle)) { if (ASSET_CARD_STYLES.includes(cardStyle as CardStyle)) {
const entityInfo = feed.feedInfo?.entitySpecificInfo?.entity; const entityInfo = feed.feedInfo?.entitySpecificInfo?.entity;
const isExecutableTestSuite = const isExecutableTestSuite =
@ -127,10 +115,6 @@ const FeedCardBodyV1 = ({
</Link> </Link>
); );
} }
if (cardStyle === CardStyle.CustomProperties) {
return <CustomPropertyFeed feed={feed} />;
}
} }
return ( return (