yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-08-28 02:46:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

minor(test): fix ingestion related flaky for aut (#17727)

Browse Source
This commit is contained in:
Chirag Madlani 2024-09-05 22:09:43 +05:30 committed by Shailesh Parmar
parent 1243f50b0f
commit 29b5ee9dcc
3 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
openmetadata-ui/src/main/resources/ui/playwright/support/entity/ingestion/RedshiftWithDBTIngestionClass.ts
View File

@ -166,15 +166,15 @@ class RedshiftWithDBTIngestionClass extends ServiceBaseClass {
await sidebarClick(page, SidebarItem.TAGS); await sidebarClick(page, SidebarItem.TAGS);
await page.waitForSelector('[data-testid="data-summary-container"]'); await page.waitForSelector('[data-testid="data-summary-container"]');
await page.click( await page.click(
`[data-testid="data-summary-container"] >> text=${DBT.classification}` `[data-testid="data-summary-container"] >> text=${DBT.classification}`
); );
// Verify DBT tag category is added // Verify DBT tag category is added
await page.waitForSelector('[data-testid="tag-name"]'); await page.waitForSelector('[data-testid="loader"]', {
const tagName = await page.textContent('[data-testid="tag-name"]'); state: 'detached',
});
expect(tagName).toContain(DBT.classification);
await page.waitForSelector('.ant-table-row'); await page.waitForSelector('.ant-table-row');

6
openmetadata-ui/src/main/resources/ui/playwright/support/entity/ingestion/ServiceBaseClass.ts
View File

@ -41,6 +41,7 @@ class ServiceBaseClass {
protected entityName: string; protected entityName: string;
protected shouldTestConnection: boolean; protected shouldTestConnection: boolean;
protected shouldAddIngestion: boolean; protected shouldAddIngestion: boolean;
protected entityFQN: string | null;
constructor( constructor(
category: Services, category: Services,
@ -56,6 +57,7 @@ class ServiceBaseClass {
this.entityName = entity; this.entityName = entity;
this.shouldTestConnection = shouldTestConnection; this.shouldTestConnection = shouldTestConnection;
this.shouldAddIngestion = shouldAddIngestion; this.shouldAddIngestion = shouldAddIngestion;
this.entityFQN = null;
} }
visitService() { visitService() {
@ -402,7 +404,7 @@ class ServiceBaseClass {
// Navigate to ingested table // Navigate to ingested table
await visitEntityPage({ await visitEntityPage({
page, page,
searchTerm: this.entityName, searchTerm: this.entityFQN ?? this.entityName,
dataTestId: entityDataTestId ?? `${this.serviceName}-${this.entityName}`, dataTestId: entityDataTestId ?? `${this.serviceName}-${this.entityName}`,
}); });
@ -446,7 +448,7 @@ class ServiceBaseClass {
// Navigate to table name // Navigate to table name
await visitEntityPage({ await visitEntityPage({
page, page,
searchTerm: this.entityName, searchTerm: this.entityFQN ?? this.entityName,
dataTestId: entityDataTestId ?? `${this.serviceName}-${this.entityName}`, dataTestId: entityDataTestId ?? `${this.serviceName}-${this.entityName}`,
}); });

2
openmetadata-ui/src/main/resources/ui/playwright/support/entity/ingestion/SnowflakeIngestionClass.ts
View File

@ -29,6 +29,8 @@ class SnowflakeIngestionClass extends ServiceBaseClass {
'CUSTOMER' 'CUSTOMER'
); );
this.schema = 'TPCH_SF1000'; this.schema = 'TPCH_SF1000';
const database = process.env.PLAYWRIGHT_SNOWFLAKE_DATABASE ?? '';
this.entityFQN = `${this.serviceName}.${database}.${this.schema}.${this.entityName} `;
} }
async createService(page: Page) { async createService(page: Page) {