Using context for charts (#5576)

Co-authored-by: Onkar Ravgan <onkarravgan@Onkars-MacBook-Pro.local>
This commit is contained in:
Onkar Ravgan 2022-06-22 14:15:28 +05:30 committed by GitHub
parent 685b7bede8
commit 2b25c299e5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -61,7 +61,6 @@ class ModeSource(DashboardServiceSource):
metadata_config: OpenMetadataConnection, metadata_config: OpenMetadataConnection,
): ):
super().__init__(config, metadata_config) super().__init__(config, metadata_config)
self.charts = []
self.workspace_name = config.serviceConnection.__root__.config.workspaceName self.workspace_name = config.serviceConnection.__root__.config.workspaceName
self.data_sources = self.client.get_all_data_sources(self.workspace_name) self.data_sources = self.client.get_all_data_sources(self.workspace_name)
@ -116,11 +115,10 @@ class ModeSource(DashboardServiceSource):
description=dashboard_details.get(mode_client.DESCRIPTION) description=dashboard_details.get(mode_client.DESCRIPTION)
if dashboard_details.get(mode_client.DESCRIPTION) if dashboard_details.get(mode_client.DESCRIPTION)
else "", else "",
charts=get_chart_entities_from_id( charts=[
chart_ids=self.charts, EntityReference(id=chart.id.__root__, type="chart")
metadata=self.metadata, for chart in self.context.charts
service_name=self.config.serviceName, ],
),
service=EntityReference( service=EntityReference(
id=self.context.dashboard_service.id.__root__, type="dashboardService" id=self.context.dashboard_service.id.__root__, type="dashboardService"
), ),
@ -198,7 +196,6 @@ class ModeSource(DashboardServiceSource):
Returns: Returns:
Iterable[CreateChartRequest] Iterable[CreateChartRequest]
""" """
self.charts = []
response_queries = self.client.get_all_queries( response_queries = self.client.get_all_queries(
workspace_name=self.workspace_name, workspace_name=self.workspace_name,
report_token=dashboard_details.get(mode_client.TOKEN), report_token=dashboard_details.get(mode_client.TOKEN),
@ -235,7 +232,6 @@ class ModeSource(DashboardServiceSource):
type="dashboardService", type="dashboardService",
), ),
) )
self.charts.append(chart.get(mode_client.TOKEN))
self.status.scanned( self.status.scanned(
chart[mode_client.VIEW_VEGAS][mode_client.TITLE] chart[mode_client.VIEW_VEGAS][mode_client.TITLE]
) )