From 2bc8ca050d4236e9f8238318e8d4212ad5ec083a Mon Sep 17 00:00:00 2001 From: Shailesh Parmar Date: Thu, 5 Jan 2023 11:32:25 +0530 Subject: [PATCH] fixed ANTD deprecated warnings (#9560) * fixed and deprecate warning * fixed failing unit test --- .../ActivityFeedCard/ActivityFeedCard.tsx | 4 +- .../ActivityFeedCard/PopoverContent.tsx | 4 +- .../AddDataQualityTest/EditTestCaseModal.tsx | 2 +- .../EdgeInfoDrawer.component.tsx | 4 +- .../EntityLineage/EntityLineage.component.tsx | 2 +- .../Explore/AdvanceSearchModal.component.tsx | 2 +- .../components/Explore/Explore.component.tsx | 47 ++-- .../Explore/SortingDropDown.test.tsx | 8 +- .../components/Explore/SortingDropDown.tsx | 8 +- .../GlobalSearchProvider.tsx | 2 +- .../Glossary/GlossaryV1.component.tsx | 68 +++-- .../IngestionStepper.component.tsx | 58 +++-- .../AddAnnouncementModal.tsx | 2 +- .../EditAnnouncementModal.tsx | 2 +- .../DeployIngestionLoaderModal.tsx | 2 +- .../EntityDeleteModal/EntityDeleteModal.tsx | 2 +- .../src/components/Modals/FormModal/index.tsx | 2 +- .../RelatedTermsModal/RelatedTermsModal.tsx | 2 +- .../ReviewerModal/ReviewerModal.component.tsx | 2 +- .../Modals/SchemaModal/SchemaModal.tsx | 2 +- .../Modals/TourEndModal/TourEndModal.tsx | 2 +- .../components/Modals/WhatsNewModal/index.tsx | 2 +- .../ui/src/components/Reactions/Emoji.tsx | 4 +- .../ui/src/components/Reactions/Reactions.tsx | 4 +- .../Component/ProfilerSettingsModal.tsx | 2 +- .../components/TeamDetails/TeamDetailsV1.tsx | 17 +- .../components/TeamDetails/TeamHierarchy.tsx | 2 +- .../ui/src/components/UserList/UserListV1.tsx | 2 +- .../components/Users/ChangePasswordForm.tsx | 2 +- .../common/DeleteWidget/DeleteWidgetModal.tsx | 2 +- .../EntitySummaryDetails.tsx | 4 +- .../AnnouncementDrawer/AnnouncementDrawer.tsx | 2 +- .../common/entityPageInfo/FollowersModal.tsx | 2 +- .../ManageButton/ManageButton.tsx | 238 +++++++++--------- .../ui/src/components/nav-bar/NavBar.tsx | 83 +++--- .../ElasticSearchReIndexModal.component.tsx | 2 +- .../ui/src/pages/KPIPage/AddKPIPage.tsx | 5 +- .../ui/src/pages/KPIPage/EditKPIPage.tsx | 3 +- .../AddAttributeModal/AddAttributeModal.tsx | 2 +- .../ui/src/pages/teams/AddTeamForm.tsx | 2 +- .../ui/src/pages/teams/AddUsersModalV1.tsx | 2 +- 41 files changed, 292 insertions(+), 317 deletions(-) diff --git a/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedCard/ActivityFeedCard.tsx b/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedCard/ActivityFeedCard.tsx index ea42401fc90..c4534f447c1 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedCard/ActivityFeedCard.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedCard/ActivityFeedCard.tsx @@ -190,12 +190,12 @@ const ActivityFeedCard: FC = ({ destroyTooltipOnHide={{ keepParent: false }} getPopupContainer={() => containerRef.current || document.body} key="reaction-options-popover" + open={visible && !isEditPost} overlayClassName="ant-popover-feed" placement="topRight" trigger="hover" - visible={visible && !isEditPost} zIndex={100} - onVisibleChange={handleVisibleChange}> + onOpenChange={handleVisibleChange}> diff --git a/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedCard/PopoverContent.tsx b/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedCard/PopoverContent.tsx index 78f652ea549..541ba78ad0b 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedCard/PopoverContent.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedCard/PopoverContent.tsx @@ -161,12 +161,12 @@ const PopoverContent: FC = ({ align={{ targetOffset: [0, -10] }} content={reactionList} id="reaction-popover" + open={visible} overlayClassName="ant-popover-feed-reactions" placement="topLeft" trigger="click" - visible={visible} zIndex={9999} - onVisibleChange={handleVisibleChange}> + onOpenChange={handleVisibleChange}> } + open={visible} title={ {softDelete ? ( @@ -83,7 +84,6 @@ const EntityDeleteModal = ({ )} } - visible={visible} width={600}>
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Modals/FormModal/index.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Modals/FormModal/index.tsx index b8c9b95648c..3c784b1a4e0 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Modals/FormModal/index.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/Modals/FormModal/index.tsx @@ -61,12 +61,12 @@ const FormModal = ({
} + open={visible} title={ {header} } - visible={visible} width={1300} onCancel={onCancel}> diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Modals/RelatedTermsModal/RelatedTermsModal.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Modals/RelatedTermsModal/RelatedTermsModal.tsx index e2cf683d36b..8b033672aec 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Modals/RelatedTermsModal/RelatedTermsModal.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/Modals/RelatedTermsModal/RelatedTermsModal.tsx @@ -123,12 +123,12 @@ const RelatedTermsModal = ({ } + open={visible} title={ {header} } - visible={visible} width={800}>
} + open={visible} title={ {header} } - visible={visible} width={800}> <> = ({ } data-testid="schema-modal" footer={null} + open={visible} title={ {t('label.json-data')} } - visible={visible} width={800}>
{ {t('label.explore-now')} } - visible={visible}> + open={visible}> = ({ } data-testid="whats-new-dialog" footer={null} + open={visible} title={ {header} } - visible={visible} width={1200}>
= ({ + onOpenChange={setVisible}>