From 2be8b0c20c52fc5aa75f511ed138bdc37149584a Mon Sep 17 00:00:00 2001
From: parthp2107 <83201188+parthp2107@users.noreply.github.com>
Date: Wed, 5 Jan 2022 14:17:55 +0530
Subject: [PATCH] tests for issues found (#2021)

---
 .../pages/common/PaginationAndFilterTest.java | 24 ++++++++++++++++++
 .../selenium/pages/myData/MyDataPageTest.java | 25 +++++++++++++++++++
 .../tableDetails/TableDetailsPageTest.java    |  6 +++++
 3 files changed, 55 insertions(+)

diff --git a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/common/PaginationAndFilterTest.java b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/common/PaginationAndFilterTest.java
index d504dc985de..24c48103dbf 100644
--- a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/common/PaginationAndFilterTest.java
+++ b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/common/PaginationAndFilterTest.java
@@ -22,6 +22,7 @@ import org.junit.jupiter.api.TestMethodOrder;
 import org.openmetadata.catalog.selenium.events.Events;
 import org.openmetadata.catalog.selenium.properties.Property;
 import org.openqa.selenium.By;
+import org.openqa.selenium.Keys;
 import org.openqa.selenium.TimeoutException;
 import org.openqa.selenium.WebDriver;
 import org.openqa.selenium.WebElement;
@@ -130,6 +131,29 @@ public class PaginationAndFilterTest {
     Events.click(webDriver, By.cssSelector("[data-testid='checkbox'][id='BigQuery']")); // Tables
   }
 
+  @Test
+  @Order(5)
+  public void filterDisappearsAfterSearchCheck() throws Exception {
+    Events.click(webDriver, By.cssSelector("[data-testid='closeWhatsNew']")); // Close What's new
+    Thread.sleep(waitTime);
+    Events.click(webDriver, By.cssSelector("[data-testid='appbar-item'][id='explore']")); // Explore
+    Events.click(webDriver, By.cssSelector("[data-testid='checkbox'][id='BigQuery']"));
+    Events.sendKeys(webDriver, By.cssSelector("[data-testid='searchBox']"), "dim");
+    Events.sendEnter(webDriver, By.cssSelector("[data-testid='searchBox']"));
+    Thread.sleep(2000);
+    WebElement clearSearchBox = webDriver.findElement(By.cssSelector("[data-testid='searchBox']"));
+    clearSearchBox.sendKeys(Keys.CONTROL + "a");
+    clearSearchBox.sendKeys(Keys.DELETE);
+    Events.sendEnter(webDriver, By.cssSelector("[data-testid='searchBox']"));
+    try {
+      Events.click(webDriver, By.cssSelector("[data-testid='checkbox'][id='Glue']"));
+      Events.click(webDriver, By.cssSelector("[data-testid='checkbox'][id='default']"));
+    } catch (TimeoutException exception) {
+      throw new Exception("filters are missing");
+    }
+  }
+
+
   @AfterEach
   public void closeTabs() {
     ArrayList<String> tabs = new ArrayList<>(webDriver.getWindowHandles());
diff --git a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/myData/MyDataPageTest.java b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/myData/MyDataPageTest.java
index 81175001bd5..f9ebb7c8620 100644
--- a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/myData/MyDataPageTest.java
+++ b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/myData/MyDataPageTest.java
@@ -15,6 +15,7 @@ package org.openmetadata.catalog.selenium.pages.myData;
 
 import java.time.Duration;
 import java.util.ArrayList;
+import java.util.logging.Logger;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.MethodOrderer;
@@ -24,7 +25,9 @@ import org.junit.jupiter.api.TestMethodOrder;
 import org.openmetadata.catalog.selenium.events.Events;
 import org.openmetadata.catalog.selenium.properties.Property;
 import org.openqa.selenium.By;
+import org.openqa.selenium.TimeoutException;
 import org.openqa.selenium.WebDriver;
+import org.openqa.selenium.WebElement;
 import org.openqa.selenium.chrome.ChromeDriver;
 import org.openqa.selenium.chrome.ChromeOptions;
 import org.openqa.selenium.interactions.Actions;
@@ -35,6 +38,8 @@ import org.openqa.selenium.support.ui.WebDriverWait;
 @TestMethodOrder(MethodOrderer.OrderAnnotation.class)
 public class MyDataPageTest {
 
+  private static final Logger LOG = Logger.getLogger(MyDataPageTest.class.getName());
+
   static WebDriver webDriver;
   static String url = Property.getInstance().getURL();
   static Actions actions;
@@ -207,6 +212,26 @@ public class MyDataPageTest {
 
   @Test
   @Order(9)
+  public void checkRecentSearchWithSpaces() throws Exception {
+    checkWhatsNew();
+    Events.sendKeys(webDriver, By.cssSelector("[id='searchBox']"), " "); // Search bar/Empty Space " "
+    Events.sendEnter(webDriver, By.cssSelector("[id='searchBox']"));
+    Events.click(webDriver, By.cssSelector("[data-testid='table-link']"));
+    Events.click(webDriver, By.cssSelector("[data-testid='image']"));
+    Thread.sleep(2000);
+    try {
+      WebElement spaceSearch = wait.until(ExpectedConditions.presenceOfElementLocated(
+          By.cssSelector("[data-testid='Recently-Search- ']")));
+      if (spaceSearch.isDisplayed()) {
+        throw new Exception("Spaces are captured in Recent Search");
+      }
+    } catch (TimeoutException exception) {
+      LOG.info("Success");
+    }
+  }
+
+  @Test
+  @Order(10)
   public void checkLogout() {
     checkWhatsNew();
     Events.click(webDriver, By.cssSelector("[data-testid='dropdown-profile']"));
diff --git a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/tableDetails/TableDetailsPageTest.java b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/tableDetails/TableDetailsPageTest.java
index 82f8106af2e..e39da3d7d4e 100644
--- a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/tableDetails/TableDetailsPageTest.java
+++ b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/tableDetails/TableDetailsPageTest.java
@@ -266,6 +266,12 @@ public class TableDetailsPageTest {
     Events.click(webDriver, By.cssSelector("[data-testid='edit-description']")); // edit description
     Thread.sleep(1000);
     webDriver.findElement(By.xpath("//*[text()[contains(.,'" + editDescription + "')]] "));
+    Events.sendKeys(webDriver, By.xpath(enterDescription), updateDescription);
+    Events.click(webDriver, By.cssSelector("[data-testid='save']"));
+    webDriver.navigate().refresh();
+    Events.click(webDriver, By.cssSelector("[data-testid='edit-description']"));
+    Thread.sleep(1000);
+    webDriver.findElement(By.xpath("//*[text()[contains(.,'" + editDescription + updateDescription + "')]] "));
     Events.click(webDriver, By.cssSelector("[data-testid='cancel']"));
     Events.click(webDriver, By.xpath("(//tr[@data-testid='column']//td[1]/a)[1]")); // database
     Events.click(webDriver, By.cssSelector("[data-testid='edit-description']")); // edit description