yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-06-27 04:22:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove Default: null from columns and let json to pojo handle (#21934)

Browse Source 
* Remove Default: null from columns and let json to pojo handle

* Remove Setting table columns to null

* Fix Failing Tests

---------

Co-authored-by: Sriharsha Chintalapani <harshach@users.noreply.github.com>
This commit is contained in:
Mohit Yadav 2025-06-25 21:53:32 +05:30 committed by GitHub
parent 1e50fc1376
commit 2c696bb1e2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/TableRepository.java
View File

@ -588,8 +588,6 @@ public class TableRepository extends EntityRepository<Table> {
table.setProfile(tableProfile); table.setProfile(tableProfile);
if (includeColumnProfile) { if (includeColumnProfile) {
setColumnProfile(table.getColumns()); setColumnProfile(table.getColumns());
} else {
table.setColumns(null);
} }
// Set the column tags. Will be used to hide the data // Set the column tags. Will be used to hide the data

2
openmetadata-service/src/test/java/org/openmetadata/service/resources/databases/TableResourceTest.java
View File

@ -1443,7 +1443,7 @@ public class TableResourceTest extends EntityResourceTest<Table, CreateTable> {
table1 = getLatestTableProfile(table1.getFullyQualifiedName(), ADMIN_AUTH_HEADERS); table1 = getLatestTableProfile(table1.getFullyQualifiedName(), ADMIN_AUTH_HEADERS);
verifyTableProfile(table1.getProfile(), table1ProfileList.get(table1ProfileList.size() - 1)); verifyTableProfile(table1.getProfile(), table1ProfileList.get(table1ProfileList.size() - 1));
table1 = getLatestTableProfile(table1.getFullyQualifiedName(), false, ADMIN_AUTH_HEADERS); table1 = getLatestTableProfile(table1.getFullyQualifiedName(), false, ADMIN_AUTH_HEADERS);
assertNull(table1.getColumns()); assertNotNull(table1.getColumns());
// Table profile with column profile as null // Table profile with column profile as null
timestamp = TestUtils.dateToTimestamp("2022-09-09"); timestamp = TestUtils.dateToTimestamp("2022-09-09");

3
openmetadata-spec/src/main/resources/json/schema/entity/data/table.json
View File

@ -1003,8 +1003,7 @@
"type": "array", "type": "array",
"items": { "items": {
"$ref": "#/definitions/column" "$ref": "#/definitions/column"
}, }
"default": null
}, },
"tableConstraints": { "tableConstraints": {
"description": "Table constraints.", "description": "Table constraints.",