From 2cfabf6017f912b53d1f7aa2241cd178434c8ebc Mon Sep 17 00:00:00 2001 From: Mike Kutzma Date: Tue, 8 Jul 2025 08:13:55 -0400 Subject: [PATCH] [FIX] 21910: Update amundsen ingest (#22201) Addresses: #21910 Removed 'Either' that currently wraps the generators being yieded from in the amundsen `metadata.py` from the `AmundsenSource` class. I think these are not necessary and causing the issue since the objects being yielded inside those methods (`self.create_table_entity`, etc) are all yielding `Either` objects. Tested on my local instance and this resolved the issue with the service not being able to ingest. Co-authored-by: Mayur Singal <39544459+ulixius9@users.noreply.github.com> --- .../ingestion/source/metadata/amundsen/metadata.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/ingestion/src/metadata/ingestion/source/metadata/amundsen/metadata.py b/ingestion/src/metadata/ingestion/source/metadata/amundsen/metadata.py index 03b6c5a176e..af3ab760be9 100644 --- a/ingestion/src/metadata/ingestion/source/metadata/amundsen/metadata.py +++ b/ingestion/src/metadata/ingestion/source/metadata/amundsen/metadata.py @@ -147,18 +147,18 @@ class AmundsenSource(Source): def _iter(self, *_, **__) -> Iterable[Either[Entity]]: table_entities = self.client.execute_query(NEO4J_AMUNDSEN_TABLE_QUERY) for table in table_entities: - yield from Either(right=self.create_table_entity(table)) + yield from self.create_table_entity(table) user_entities = self.client.execute_query(NEO4J_AMUNDSEN_USER_QUERY) for user in user_entities: - yield from Either(right=self.create_user_entity(user)) - yield from Either(right=self.add_owner_to_entity(user)) + yield from self.create_user_entity(user) + yield from self.add_owner_to_entity(user) dashboard_entities = self.client.execute_query(NEO4J_AMUNDSEN_DASHBOARD_QUERY) for dashboard in dashboard_entities: - yield from Either(right=self.create_dashboard_service(dashboard)) - yield from Either(right=self.create_chart_entity(dashboard)) - yield from Either(right=self.create_dashboard_entity(dashboard)) + yield from self.create_dashboard_service(dashboard) + yield from self.create_chart_entity(dashboard) + yield from self.create_dashboard_entity(dashboard) def create_user_entity(self, user) -> Iterable[Either[OMetaUserProfile]]: try: