yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-11-15 18:33:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Get service connection info if not set (#9981)

Browse Source
This commit is contained in:
Pere Miquel Brull 2023-01-29 10:42:17 +01:00 committed by GitHub
parent 02c1f9ac94
commit 2ec8b42e96
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
ingestion/src/metadata/ingestion/api/workflow.py
View File

@ -18,6 +18,9 @@ from metadata.config.common import WorkflowExecutionError
from metadata.generated.schema.entity.services.connections.metadata.openMetadataConnection import ( from metadata.generated.schema.entity.services.connections.metadata.openMetadataConnection import (
OpenMetadataConnection, OpenMetadataConnection,
) )
from metadata.generated.schema.entity.services.connections.serviceConnection import (
ServiceConnection,
)
from metadata.generated.schema.entity.services.ingestionPipelines.ingestionPipeline import ( from metadata.generated.schema.entity.services.ingestionPipelines.ingestionPipeline import (
PipelineState, PipelineState,
) )
@ -301,10 +304,7 @@ class Workflow(WorkflowStatusMixin):
:param service_type: source workflow service type :param service_type: source workflow service type
:return: :return:
""" """
if ( if not self.config.source.serviceConnection:
service_type is not ServiceType.Metadata
and not self.config.source.serviceConnection
):
service_name = self.config.source.serviceName service_name = self.config.source.serviceName
try: try:
service: ServiceWithConnectionType = cast( service: ServiceWithConnectionType = cast(
@ -315,10 +315,19 @@ class Workflow(WorkflowStatusMixin):
), ),
) )
if service: if service:
self.config.source.serviceConnection = service.connection self.config.source.serviceConnection = ServiceConnection(
__root__=service.connection
)
else:
raise InvalidWorkflowJSONException(
"The serviceConnection is not informed and we cannot retrieve it from the API"
f" by searching for the service name [{service_name}]. Does this service exist in OpenMetadata?"
)
except InvalidWorkflowJSONException as exc:
raise exc
except Exception as exc: except Exception as exc:
logger.debug(traceback.format_exc()) logger.debug(traceback.format_exc())
logger.error( logger.error(
f"Error getting service connection for service name [{service_name}]" f"Unknown error getting service connection for service name [{service_name}]"
f" using the secrets manager provider [{self.metadata.config.secretsManagerProvider}]: {exc}" f" using the secrets manager provider [{self.metadata.config.secretsManagerProvider}]: {exc}"
) )