fix the underline issue on entity cards (#11497)

This commit is contained in:
Ashish Gupta 2023-05-09 19:45:52 +05:30 committed by GitHub
parent 915e800d60
commit 30ba81a9ef
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 42 additions and 23 deletions

View File

@ -38,7 +38,7 @@ const NotificationFeedCard: FC<NotificationFeedProp> = ({
return ( return (
<Link <Link
className="tw-no-underline" className="no-underline"
to={ to={
feedType === ThreadType.Conversation feedType === ThreadType.Conversation
? prepareFeedLink(entityType, entityFQN) ? prepareFeedLink(entityType, entityFQN)

View File

@ -151,7 +151,7 @@ const UserCard = ({
} }
return ( return (
<Link className="tw-no-underline" data-testid="dataset-link" to={link}> <Link className="no-underline" data-testid="dataset-link" to={link}>
<span className="tw-font-medium tw-text-grey-body tw-break-all tw-text-left"> <span className="tw-font-medium tw-text-grey-body tw-break-all tw-text-left">
{getAssetDisplayName(type, fqn)} {getAssetDisplayName(type, fqn)}
</span> </span>

View File

@ -13,11 +13,8 @@
// common css utils file // common css utils file
@import url('./variables.less'); @import url('./variables.less');
@primary: #7147e8;
@primary-light: rgb(244, 240, 253); @primary-light: rgb(244, 240, 253);
@primary-hover-light: rgba(219, 209, 249); @primary-hover-light: rgba(219, 209, 249);
@white: #fff;
@gray: #dde3ea;
@trigger-btn-hover-bg: #efefef; @trigger-btn-hover-bg: #efefef;
// Global css // Global css
@ -46,6 +43,38 @@
background-color: @error-light-color; background-color: @error-light-color;
} }
.show-more,
a[href]:not(.button-comp):not(.no-underline):not(.link-text-info),
.link-text {
color: @primary-color-hover;
&:hover {
color: @primary-color-hover;
text-decoration: underline;
}
&:focus {
color: @primary-color-hover;
text-decoration: underline;
cursor: pointer;
}
}
a[href].link-text-grey,
.link-text-grey {
color: @text-color;
&:hover {
color: @text-color;
text-decoration: underline;
}
&:focus {
color: @text-color;
text-decoration: underline;
cursor: pointer;
}
}
// used in glossary + query right panel, to keep both consistent // used in glossary + query right panel, to keep both consistent
.right-panel-label { .right-panel-label {
font-size: 14px; font-size: 14px;
@ -60,9 +89,9 @@
// text color // text color
.text-primary { .text-primary {
color: @primary; color: @primary-color;
&:hover { &:hover {
color: @primary; color: @primary-color;
} }
} }
.text-color-inherit { .text-color-inherit {
@ -139,10 +168,10 @@
border-color: @border-color; border-color: @border-color;
} }
.border-primary { .border-primary {
border-color: @primary; border-color: @primary-color;
} }
.border-gray { .border-gray {
border-color: @gray; border-color: @border-color;
} }
.border-light-gray { .border-light-gray {
border-color: @light-border-color; border-color: @light-border-color;
@ -183,20 +212,20 @@
background: @primary-light; background: @primary-light;
} }
.bg-primary { .bg-primary {
background: @primary; background: @primary-color;
} }
.bg-primary-hover-lite { .bg-primary-hover-lite {
background-color: @primary-hover-light; background-color: @primary-hover-light;
} }
.bg-grey { .bg-grey {
background-color: @gray; background-color: @border-color;
} }
.bg-white { .bg-white {
background-color: @white; background-color: @white;
} }
.activeCategory { .activeCategory {
border-left: 2px solid @primary; border-left: 2px solid @primary-color;
background: @primary-light; background: @primary-light;
padding-left: 10px; padding-left: 10px;
font-weight: 600; font-weight: 600;

View File

@ -149,17 +149,6 @@
@apply tw-text-info hover:tw-text-info focus:tw-text-info hover:tw-underline focus:tw-underline tw-cursor-pointer; @apply tw-text-info hover:tw-text-info focus:tw-text-info hover:tw-underline focus:tw-underline tw-cursor-pointer;
} }
.show-more,
a[href]:not(.button-comp):not(.tw-no-underline):not(.link-text-info),
.link-text {
@apply tw-text-primary-hover hover:tw-text-primary-hover focus:tw-text-primary-hover hover:tw-underline focus:tw-underline tw-cursor-pointer;
}
a[href].link-text-grey,
.link-text-grey {
@apply tw-text-grey-body hover:tw-text-grey-body focus:tw-text-grey-body hover:tw-underline focus:tw-underline tw-cursor-pointer;
}
.page-container { .page-container {
@apply tw-bg-body-main; @apply tw-bg-body-main;
} }

View File

@ -12,6 +12,7 @@
*/ */
@primary-color: #7147e8; @primary-color: #7147e8;
@primary-color-hover: #5523e0;
@secondary-color: #b02aac; @secondary-color: #b02aac;
@link-color: #7147e8; @link-color: #7147e8;
@success-color: #008376; @success-color: #008376;