yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-07-18 06:31:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

MINOR: fix qlikcloud test connection (#17459)

Browse Source 
* fix: qlikcloud test connection

* patch test_connection for qlik cloud unit tests
This commit is contained in:
Imri Paran 2024-08-20 08:14:09 +02:00 committed by GitHub
parent ddd8c41864
commit 31c2ec8c57
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ingestion/src/metadata/ingestion/source/dashboard/qlikcloud/client.py
View File

@ -145,7 +145,7 @@ class QlikCloudClient:
resp_apps = self.client.get("/v1/items?resourceType=app") resp_apps = self.client.get("/v1/items?resourceType=app")
if resp_apps: if resp_apps:
resp = QlikAppResponse(**resp_apps) resp = QlikAppResponse(**resp_apps)
yield from resp.apps return list(resp.apps)
def get_dashboard_details(self, dashboard_id: str) -> Optional[QlikApp]: def get_dashboard_details(self, dashboard_id: str) -> Optional[QlikApp]:
""" """

6
ingestion/tests/unit/topology/dashboard/test_qlikcloud.py
View File

@ -157,7 +157,11 @@ class QlikCloudUnitTest(TestCase):
""" """
def __init__(self, methodName) -> None: def __init__(self, methodName) -> None:
with patch.object(QlikCloudClient, "get_dashboards_list", return_value=None): with patch.object(
QlikCloudClient, "get_dashboards_list", return_value=None
), patch.object(
QlikCloudClient, "get_dashboards_list_test_conn", return_value=None
):
super().__init__(methodName) super().__init__(methodName)
# test_connection.return_value = False # test_connection.return_value = False
self.config = OpenMetadataWorkflowConfig.model_validate( self.config = OpenMetadataWorkflowConfig.model_validate(