yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-08-04 23:28:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed : #1221 UI: Versioning right panel should wrap the summary. (#1226)

Browse Source
This commit is contained in:
Sachin Chaurasiya 2021-11-17 15:54:46 +05:30 committed by GitHub
parent e7072a3177
commit 325992d086
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
catalog-rest-service/src/main/resources/ui/src/components/EntityVersionTimeLine/EntityVersionTimeLine.tsx
View File

@ -55,7 +55,7 @@ const EntityVersionTimeLine: React.FC<Props> = ({
})}> })}>
v{parseFloat(currV?.version).toFixed(1)} v{parseFloat(currV?.version).toFixed(1)}
</p> </p>
<div className="tw-text-xs tw-font-normal"> <div className="tw-text-xs tw-font-normal tw-break-all">
{getSummary(currV?.changeDescription)} {getSummary(currV?.changeDescription)}
</div> </div>
<p className="tw-text-xs tw-italic"> <p className="tw-text-xs tw-italic">

16
catalog-rest-service/src/main/resources/ui/src/utils/EntityVersionUtils.tsx
View File

@ -166,9 +166,9 @@ export const summaryFormatter = (v: FieldChange) => {
: '{}' : '{}'
); );
if (v.name === 'columns') { if (v.name === 'columns') {
return `columns ${value?.map((val: any) => val?.name).join(',')}`; return `columns ${value?.map((val: any) => val?.name).join(', ')}`;
} else if (v.name === 'tags' || v.name?.endsWith('tags')) { } else if (v.name === 'tags' || v.name?.endsWith('tags')) {
return `tags ${value?.map((val: any) => val?.tagFQN)?.join(',')}`; return `tags ${value?.map((val: any) => val?.tagFQN)?.join(', ')}`;
} else { } else {
return v.name; return v.name;
} }
@ -182,13 +182,19 @@ export const getSummary = (changeDescription: ChangeDescription) => {
return ( return (
<Fragment> <Fragment>
{fieldsAdded?.length > 0 ? ( {fieldsAdded?.length > 0 ? (
<p>{fieldsAdded?.map(summaryFormatter)} has been added</p> <p className="tw-mb-2">
{fieldsAdded?.map(summaryFormatter)} has been added
</p>
) : null} ) : null}
{fieldsUpdated?.length ? ( {fieldsUpdated?.length ? (
<p>{fieldsUpdated?.map(summaryFormatter)} has been updated</p> <p className="tw-mb-2">
{fieldsUpdated?.map(summaryFormatter)} has been updated
</p>
) : null} ) : null}
{fieldsDeleted?.length ? ( {fieldsDeleted?.length ? (
<p>{fieldsDeleted?.map(summaryFormatter)} has been deleted</p> <p className="tw-mb-2">
{fieldsDeleted?.map(summaryFormatter)} has been deleted
</p>
) : null} ) : null}
</Fragment> </Fragment>
); );