yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-10-24 07:14:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Return s3 endpoint as str() instead of Url (#18521)

Browse Source
This commit is contained in:
IceS2 2024-11-05 18:39:50 +01:00 committed by Pablo Takara
parent b7f3157986
commit 357e1c80f8
No known key found for this signature in database
GPG Key ID: 63381DDFBB2BF725
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ingestion/src/metadata/ingestion/source/database/iceberg/fs/s3.py
View File

@ -67,7 +67,7 @@ class S3FileSystem(IcebergFileSystemBase):
) )
return { return {
S3_ENDPOINT: fs_config.endPointURL, S3_ENDPOINT: str(fs_config.endPointURL),
S3_ACCESS_KEY_ID: fs_config.awsAccessKeyId, S3_ACCESS_KEY_ID: fs_config.awsAccessKeyId,
S3_SECRET_ACCESS_KEY: fs_config.awsSecretAccessKey.get_secret_value() S3_SECRET_ACCESS_KEY: fs_config.awsSecretAccessKey.get_secret_value()
if fs_config.awsSecretAccessKey if fs_config.awsSecretAccessKey

1
ingestion/tests/unit/topology/database/test_iceberg.py
View File

@ -464,6 +464,7 @@ MOCK_DYNAMO_CONFIG = {
"connection": { "connection": {
"tableName": "table", "tableName": "table",
"awsConfig": { "awsConfig": {
"endPointURL": "http://example.com",
"awsAccessKeyId": "access_key", "awsAccessKeyId": "access_key",
"awsSecretAccessKey": "secret", "awsSecretAccessKey": "secret",
"awsRegion": "us-east-2", "awsRegion": "us-east-2",