From 38c707b0bc378a63813c668dfb06ac32fb7a5c20 Mon Sep 17 00:00:00 2001 From: Mayur Singal <39544459+ulixius9@users.noreply.github.com> Date: Thu, 11 Sep 2025 17:29:23 +0530 Subject: [PATCH] MINOR: Fix column comment getting overriden in glue (#23329) --- .../src/metadata/ingestion/source/database/athena/utils.py | 2 +- .../src/metadata/ingestion/source/database/glue/metadata.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ingestion/src/metadata/ingestion/source/database/athena/utils.py b/ingestion/src/metadata/ingestion/source/database/athena/utils.py index 66d68d08313..3219cb3bdc5 100644 --- a/ingestion/src/metadata/ingestion/source/database/athena/utils.py +++ b/ingestion/src/metadata/ingestion/source/database/athena/utils.py @@ -173,7 +173,7 @@ def get_columns(self, connection, table_name, schema=None, **kw): for glue_col in glue_columns: col_name = glue_col["Name"] col_type = glue_col["Type"] - col_comment = glue_col.get("Comment", "") + col_comment = glue_col.get("Comment") col_parameters = glue_col.get("Parameters", {}) # Check if this is a non-current Iceberg column diff --git a/ingestion/src/metadata/ingestion/source/database/glue/metadata.py b/ingestion/src/metadata/ingestion/source/database/glue/metadata.py index 0a8c5c5d18f..35b171f0448 100755 --- a/ingestion/src/metadata/ingestion/source/database/glue/metadata.py +++ b/ingestion/src/metadata/ingestion/source/database/glue/metadata.py @@ -406,7 +406,7 @@ class GlueSource(ExternalTableLineageMixin, DatabaseServiceSource): for glue_col in glue_columns: col_name = glue_col["Name"] col_type = glue_col["Type"] - col_comment = glue_col.get("Comment", "") + col_comment = glue_col.get("Comment") col_parameters = glue_col.get("Parameters", {}) # Check if this is a non-current Iceberg column @@ -427,7 +427,7 @@ class GlueSource(ExternalTableLineageMixin, DatabaseServiceSource): for glue_col in partition_keys: col_name = glue_col["Name"] col_type = glue_col["Type"] - col_comment = glue_col.get("Comment", "") + col_comment = glue_col.get("Comment") col_parameters = glue_col.get("Parameters", {}) # Check if this is a non-current Iceberg column