diff --git a/ingestion/tests/cli_e2e/base/test_cli_db.py b/ingestion/tests/cli_e2e/base/test_cli_db.py index c3afd497d44..314c8ab6d02 100644 --- a/ingestion/tests/cli_e2e/base/test_cli_db.py +++ b/ingestion/tests/cli_e2e/base/test_cli_db.py @@ -210,27 +210,6 @@ class CliDBBase(TestCase): sink_status, ) - @pytest.mark.order(12) - def test_system_metrics(self) -> None: - if not any([self.delete_queries(), self.update_queries()]): - pytest.skip( - "System metrics test requires delete and update table rows queries" - ) - self.build_config_file() - self.run_command() - self.delete_table_and_view() - self.create_table_and_view() - self.build_config_file( - E2EType.PROFILER, {"includes": self.get_includes_schemas()} - ) - self.delete_table_rows() - self.update_table_row() - # Add 5min delay for system tables to register the change - time.sleep(5 * 60) - result = self.run_command("profile") - sink_status, source_status = self.retrieve_statuses(result) - self.assert_for_system_metrics(source_status, sink_status) - def retrieve_table(self, table_name_fqn: str) -> Table: return self.openmetadata.get_by_name(entity=Table, fqn=table_name_fqn) diff --git a/ingestion/tests/cli_e2e/common/test_cli_db.py b/ingestion/tests/cli_e2e/common/test_cli_db.py index dc39939171a..c27e43ef140 100644 --- a/ingestion/tests/cli_e2e/common/test_cli_db.py +++ b/ingestion/tests/cli_e2e/common/test_cli_db.py @@ -123,27 +123,6 @@ class CliCommonDB: if sample_data: self.assertTrue(len(json.loads(sample_data.json()).get("rows")) > 0) - def assert_for_system_metrics( - self, source_status: SourceStatus, sink_status: SinkStatus - ): - self.assertTrue(len(source_status.failures) == 0) - self.assertTrue(len(sink_status.failures) == 0) - - start_ts = int((datetime.now() - timedelta(days=1)).timestamp() * 1000) - end_ts = int((datetime.now() + timedelta(days=1)).timestamp() * 1000) - system_profile = self.openmetadata.get_profile_data( - self.fqn_deleted_table(), - start_ts, - end_ts, - profile_type=SystemProfile, - ) - - assert {profile.operation.value for profile in system_profile.entities} == { - "DELETE", - "INSERT", - "UPDATE", - } - def assert_for_delete_table_is_marked_as_deleted( self, source_status: SourceStatus, sink_status: SinkStatus ): diff --git a/ingestion/tests/cli_e2e/test_cli_snowflake.py b/ingestion/tests/cli_e2e/test_cli_snowflake.py index 87fe73818e2..7725b6ea5fc 100644 --- a/ingestion/tests/cli_e2e/test_cli_snowflake.py +++ b/ingestion/tests/cli_e2e/test_cli_snowflake.py @@ -131,23 +131,6 @@ class SnowflakeCliTest(CliCommonDB.TestSuite, SQACommonMethods): sink_status, source_status = self.retrieve_statuses(result) self.assert_for_table_with_profiler(source_status, sink_status) - @pytest.mark.order(12) - def test_system_metrics(self) -> None: - self.delete_table_and_view() - self.create_table_and_view() - self.build_config_file() - self.run_command() - self.build_config_file( - E2EType.PROFILER, {"includes": self.get_includes_schemas()} - ) - self.delete_table_rows() - self.update_table_row() - # Add 5min delay for system tables to register the change - time.sleep(5 * 60) - result = self.run_command("profile") - sink_status, source_status = self.retrieve_statuses(result) - self.assert_for_system_metrics(source_status, sink_status) - @staticmethod def expected_tables() -> int: return 7