yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2026-01-06 04:26:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

✨ Revamp : Task Details Page (#5722)

Browse Source
This commit is contained in:
Sachin Chaurasiya 2022-06-29 12:45:07 +05:30 committed by GitHub
parent 04a6acc02f
commit 3b278db0e7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 35 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

59
openmetadata-ui/src/main/resources/ui/src/pages/TasksPage/TaskDetailPage/TaskDetailPage.tsx
View File

@ -555,7 +555,7 @@ const TaskDetailPage = () => {
newDescription || ''
);
return !diffs.length ? (
return !newDescription && !oldDescription ? (
<span className="tw-p-2 tw-text-grey-muted">No Suggestion</span>
) : (
<DiffView className="tw-p-2" diffArr={diffs} />
@ -651,6 +651,7 @@ const TaskDetailPage = () => {
</Button>
<Button
className="tw-mx-1 tw-self-center ant-btn-primary-custom"
disabled={!assignees.length}
size="small"
type="primary"
onClick={onTaskUpdate}>
@ -697,7 +698,7 @@ const TaskDetailPage = () => {
<div data-testid="description-task">
{isRequestDescription && (
<div data-testid="request-description">
{isTaskActionEdit ? (
{isTaskActionEdit && hasEditAccess() ? (
<RichTextEditor
height="208px"
initialValue={suggestion}
@ -715,7 +716,7 @@ const TaskDetailPage = () => {
{isUpdateDescription && (
<div data-testid="update-description">
{isTaskActionEdit ? (
{isTaskActionEdit && hasEditAccess() ? (
<DescriptionTabs
description={currentDescription()}
markdownRef={markdownRef}
@ -746,27 +747,37 @@ const TaskDetailPage = () => {
Close with comment
</Button>
<Dropdown.Button
className="ant-btn-primary-dropdown"
icon={
<FontAwesomeIcon
className="tw-text-sm"
icon={faChevronDown}
/>
}
overlay={
<Menu
selectable
items={TASK_ACTION_LIST}
selectedKeys={[taskAction.key]}
onClick={(info) => onTaskActionChange(info.key)}
/>
}
trigger={['click']}
type="primary"
onClick={onTaskResolve}>
{taskAction.label}
</Dropdown.Button>
{taskDetail.task?.suggestion ? (
<Dropdown.Button
className="ant-btn-primary-dropdown"
icon={
<FontAwesomeIcon
className="tw-text-sm"
icon={faChevronDown}
/>
}
overlay={
<Menu
selectable
items={TASK_ACTION_LIST}
selectedKeys={[taskAction.key]}
onClick={(info) => onTaskActionChange(info.key)}
/>
}
trigger={['click']}
type="primary"
onClick={onTaskResolve}>
{taskAction.label}
</Dropdown.Button>
) : (
<Button
className="ant-btn-primary-custom"
disabled={!suggestion}
type="primary"
onClick={onTaskResolve}>
Add Description
</Button>
)}
</div>
)}