mirror of
				https://github.com/open-metadata/OpenMetadata.git
				synced 2025-10-26 00:04:52 +00:00 
			
		
		
		
	pass filters when refreshing for domain assets (#19872)
* pass filters when refreshing assets * verify query_filter being passed for refresh
This commit is contained in:
		
							parent
							
								
									eddaf75121
								
							
						
					
					
						commit
						3be1a40c05
					
				| @ -344,9 +344,24 @@ export const addAssetsToDomain = async ( | |||||||
|   } |   } | ||||||
| 
 | 
 | ||||||
|   const assetsAddRes = page.waitForResponse(`/api/v1/domains/*/assets/add`); |   const assetsAddRes = page.waitForResponse(`/api/v1/domains/*/assets/add`); | ||||||
|  |   const searchRes = page.waitForResponse((response) => { | ||||||
|  |     const url = new URL(response.url()); | ||||||
|  |     const queryParams = new URLSearchParams(url.search); | ||||||
|  |     const queryFilter = queryParams.get('query_filter'); | ||||||
|  | 
 | ||||||
|  |     return ( | ||||||
|  |       response | ||||||
|  |         .url() | ||||||
|  |         .includes('/api/v1/search/query?q=**&index=all&from=0&size=15') && | ||||||
|  |       queryFilter !== null && | ||||||
|  |       queryFilter !== '' | ||||||
|  |     ); | ||||||
|  |   }); | ||||||
|   await page.getByTestId('save-btn').click(); |   await page.getByTestId('save-btn').click(); | ||||||
|   await assetsAddRes; |   await assetsAddRes; | ||||||
| 
 | 
 | ||||||
|  |   await searchRes; | ||||||
|  | 
 | ||||||
|   await page.reload(); |   await page.reload(); | ||||||
|   await page.waitForLoadState('networkidle'); |   await page.waitForLoadState('networkidle'); | ||||||
| 
 | 
 | ||||||
|  | |||||||
| @ -753,12 +753,19 @@ const AssetsTabs = forwardRef( | |||||||
|       refreshAssets() { |       refreshAssets() { | ||||||
|         // Reset page to one and trigger fetchAssets
 |         // Reset page to one and trigger fetchAssets
 | ||||||
|         handlePageChange(1); |         handlePageChange(1); | ||||||
|  | 
 | ||||||
|  |         const newFilter = getCombinedQueryFilterObject( | ||||||
|  |           queryFilter as unknown as QueryFilterInterface, | ||||||
|  |           quickFilterQuery as QueryFilterInterface | ||||||
|  |         ); | ||||||
|  | 
 | ||||||
|         // If current page is already 1 it won't trigger fetchAset from useEffect
 |         // If current page is already 1 it won't trigger fetchAset from useEffect
 | ||||||
|         // Hence need to manually trigger it for this case
 |         // Hence need to manually trigger it for this case
 | ||||||
|         currentPage === 1 && |         currentPage === 1 && | ||||||
|           fetchAssets({ |           fetchAssets({ | ||||||
|             index: isEmpty(activeFilter) ? [SearchIndex.ALL] : activeFilter, |             index: isEmpty(activeFilter) ? [SearchIndex.ALL] : activeFilter, | ||||||
|             page: 1, |             page: 1, | ||||||
|  |             queryFilter: newFilter, | ||||||
|           }); |           }); | ||||||
|       }, |       }, | ||||||
|       closeSummaryPanel() { |       closeSummaryPanel() { | ||||||
|  | |||||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user
	 Karan Hotchandani
						Karan Hotchandani