From 3c809d34261539f557aea4007daaf3523b458e66 Mon Sep 17 00:00:00 2001 From: Sachin Chaurasiya Date: Thu, 22 Sep 2022 18:55:02 +0530 Subject: [PATCH] Fix #7648 UI : Add ViewBasic operation for resources (#7659) * Fix #7648 UI : Add ViewBasic operation for resources * Minor change --- .../DatasetDetails.component.tsx | 13 +++- .../GlossaryTerms/GlossaryTerms.test.tsx | 3 + .../Ingestion/Ingestion.component.tsx | 6 +- .../ProfilerDashboard/ProfilerDashboard.tsx | 8 ++- .../TableProfiler/TableProfilerV1.tsx | 6 +- .../components/TeamDetails/TeamDetailsV1.tsx | 3 +- .../ui/src/components/TeamDetails/Teams.tsx | 2 +- .../TestSuitePipelineTab.component.tsx | 5 +- .../common/ProfilePicture/ProfilePicture.tsx | 5 +- .../pages/BotDetailsPage/BotDetailsPage.tsx | 4 +- .../CustomPropertiesPageV1.tsx | 2 +- .../DashboardDetailsPage.component.tsx | 4 +- .../DatabaseSchemaPage.component.tsx | 8 ++- .../DatasetDetailsPage.component.tsx | 4 +- .../MlModelPage/MlModelPage.component.tsx | 4 +- .../pages/MyDataPage/MyDataPage.component.tsx | 5 +- .../PipelineDetailsPage.component.tsx | 4 +- .../PoliciesDetailPage/PoliciesDetailPage.tsx | 4 +- .../PoliciesListPage/PoliciesList.test.tsx | 3 + .../PoliciesListPage/PoliciesList.tsx | 8 ++- .../ProfilerDashboardPage.tsx | 8 ++- .../RolesDetailPage/RolesDetailPage.tsx | 4 +- .../RolesPage/RolesListPage/RolesList.tsx | 8 ++- .../TestSuiteDetailsPage.component.tsx | 4 +- .../TopicDetailsPage.component.tsx | 4 +- .../ui/src/pages/database-details/index.tsx | 4 +- .../resources/ui/src/pages/service/index.tsx | 6 +- .../ui/src/pages/services/ServicesPage.tsx | 6 +- .../ui/src/pages/teams/TeamsPage.tsx | 4 +- .../ui/src/router/AuthenticatedAppRouter.tsx | 12 ++-- .../ui/src/router/GlobalSettingRouter.tsx | 33 +++------ .../ui/src/utils/GlobalSettingsUtils.tsx | 67 +++++++------------ .../ui/src/utils/PermissionsUtils.ts | 11 +++ 33 files changed, 143 insertions(+), 129 deletions(-) diff --git a/openmetadata-ui/src/main/resources/ui/src/components/DatasetDetails/DatasetDetails.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/DatasetDetails/DatasetDetails.component.tsx index 69a5ed0f7cd..9fdffeea43c 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/DatasetDetails/DatasetDetails.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/DatasetDetails/DatasetDetails.component.tsx @@ -240,7 +240,11 @@ const DatasetDetails: React.FC = ({ selectedName: 'sample-data-color', }, isProtected: false, - isHidden: !(tablePermissions.ViewAll || tablePermissions.ViewSampleData), + isHidden: !( + tablePermissions.ViewAll || + tablePermissions.ViewBasic || + tablePermissions.ViewSampleData + ), position: 3, }, { @@ -252,7 +256,11 @@ const DatasetDetails: React.FC = ({ selectedName: '', }, isProtected: false, - isHidden: !(tablePermissions.ViewAll || tablePermissions.ViewQueries), + isHidden: !( + tablePermissions.ViewAll || + tablePermissions.ViewBasic || + tablePermissions.ViewQueries + ), position: 4, }, { @@ -266,6 +274,7 @@ const DatasetDetails: React.FC = ({ isProtected: false, isHidden: !( tablePermissions.ViewAll || + tablePermissions.ViewBasic || tablePermissions.ViewDataProfile || tablePermissions.ViewTests ), diff --git a/openmetadata-ui/src/main/resources/ui/src/components/GlossaryTerms/GlossaryTerms.test.tsx b/openmetadata-ui/src/main/resources/ui/src/components/GlossaryTerms/GlossaryTerms.test.tsx index 69b9f99ede2..99edfde3fba 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/GlossaryTerms/GlossaryTerms.test.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/GlossaryTerms/GlossaryTerms.test.tsx @@ -56,6 +56,9 @@ jest.mock('../PermissionProvider/PermissionProvider', () => ({ jest.mock('../../utils/PermissionsUtils', () => ({ checkPermission: jest.fn().mockReturnValue(true), + userPermissions: { + hasViewPermissions: jest.fn(), + }, })); jest.mock('react-router-dom', () => ({ diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Ingestion/Ingestion.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Ingestion/Ingestion.component.tsx index a699e4f3e0b..f7c9457736a 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Ingestion/Ingestion.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/Ingestion/Ingestion.component.tsx @@ -448,14 +448,16 @@ const Ingestion: React.FC = ({ {airflowEndpoint ? (