From 3dcccb1f1471253e79ca9961828199d0db61d01f Mon Sep 17 00:00:00 2001 From: Aniket Katkar Date: Thu, 19 Jan 2023 16:56:02 +0530 Subject: [PATCH] added unit test improvements for CustomPropertyTable and Users components (#9802) --- .../ui/src/components/Users/Users.component.test.tsx | 8 ++++---- .../CustomPropertyTable/CustomPropertyTable.test.tsx | 6 ++++++ 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Users/Users.component.test.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Users/Users.component.test.tsx index 2e8dab745f3..5456219d3b2 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Users/Users.component.test.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/Users/Users.component.test.tsx @@ -248,9 +248,9 @@ describe('Test User Component', () => { wrapper: MemoryRouter, } ); - const inheritedRoles = await findByTestId(container, 'loader'); + const loader = await findByTestId(container, 'loader'); - expect(inheritedRoles).toBeInTheDocument(); + expect(loader).toBeInTheDocument(); }); it('Following tab should show loader if the data is loading', async () => { @@ -260,8 +260,8 @@ describe('Test User Component', () => { wrapper: MemoryRouter, } ); - const inheritedRoles = await findByTestId(container, 'loader'); + const loader = await findByTestId(container, 'loader'); - expect(inheritedRoles).toBeInTheDocument(); + expect(loader).toBeInTheDocument(); }); }); diff --git a/openmetadata-ui/src/main/resources/ui/src/components/common/CustomPropertyTable/CustomPropertyTable.test.tsx b/openmetadata-ui/src/main/resources/ui/src/components/common/CustomPropertyTable/CustomPropertyTable.test.tsx index fd1a804e390..0fb3238eee3 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/common/CustomPropertyTable/CustomPropertyTable.test.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/common/CustomPropertyTable/CustomPropertyTable.test.tsx @@ -118,5 +118,11 @@ describe('Test CustomProperty Table Component', () => { // To check if loader was rendered when the loading state was true and then removed after loading is false await waitForElementToBeRemoved(() => screen.getByTestId('loader')); + + const noDataPlaceHolder = await screen.findByText( + 'ErrorPlaceHolder.component' + ); + + expect(noDataPlaceHolder).toBeInTheDocument(); }); });