yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-08-28 19:05:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

added unit test improvements for CustomPropertyTable and Users components (#9802)

Browse Source
This commit is contained in:
Aniket Katkar 2023-01-19 16:56:02 +05:30 committed by GitHub
parent d7cf3acf9f
commit 3dcccb1f14
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
openmetadata-ui/src/main/resources/ui/src/components/Users/Users.component.test.tsx
View File

@ -248,9 +248,9 @@ describe('Test User Component', () => {
wrapper: MemoryRouter, wrapper: MemoryRouter,
} }
); );
const inheritedRoles = await findByTestId(container, 'loader'); const loader = await findByTestId(container, 'loader');
expect(inheritedRoles).toBeInTheDocument(); expect(loader).toBeInTheDocument();
}); });
it('Following tab should show loader if the data is loading', async () => { it('Following tab should show loader if the data is loading', async () => {
@ -260,8 +260,8 @@ describe('Test User Component', () => {
wrapper: MemoryRouter, wrapper: MemoryRouter,
} }
); );
const inheritedRoles = await findByTestId(container, 'loader'); const loader = await findByTestId(container, 'loader');
expect(inheritedRoles).toBeInTheDocument(); expect(loader).toBeInTheDocument();
}); });
}); });

6
openmetadata-ui/src/main/resources/ui/src/components/common/CustomPropertyTable/CustomPropertyTable.test.tsx
View File

@ -118,5 +118,11 @@ describe('Test CustomProperty Table Component', () => {
// To check if loader was rendered when the loading state was true and then removed after loading is false // To check if loader was rendered when the loading state was true and then removed after loading is false
await waitForElementToBeRemoved(() => screen.getByTestId('loader')); await waitForElementToBeRemoved(() => screen.getByTestId('loader'));
const noDataPlaceHolder = await screen.findByText(
'ErrorPlaceHolder.component'
);
expect(noDataPlaceHolder).toBeInTheDocument();
}); });
}); });