From 3f65c8ab0f91a0820b3e99829a0a6fd51ea5f14a Mon Sep 17 00:00:00 2001 From: Mayur Singal <39544459+ulixius9@users.noreply.github.com> Date: Thu, 4 May 2023 13:37:00 +0530 Subject: [PATCH] Fix Vertica column fetch query (#11424) * Fix vertica column fetch query * fix timestamp datatype --- .../metadata/ingestion/source/database/vertica/metadata.py | 4 ---- .../src/metadata/ingestion/source/database/vertica/queries.py | 3 ++- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/ingestion/src/metadata/ingestion/source/database/vertica/metadata.py b/ingestion/src/metadata/ingestion/source/database/vertica/metadata.py index a3a2b786cc1..c3f03044176 100644 --- a/ingestion/src/metadata/ingestion/source/database/vertica/metadata.py +++ b/ingestion/src/metadata/ingestion/source/database/vertica/metadata.py @@ -145,16 +145,12 @@ def _get_column_info( # pylint: disable=too-many-locals,too-many-branches,too-m args = () elif attype in ("timestamptz", "timetz"): kwargs["timezone"] = True - if charlen: - kwargs["precision"] = int(charlen) args = () elif attype in ( "timestamp", "time", ): kwargs["timezone"] = False - if charlen: - kwargs["precision"] = int(charlen) args = () elif attype.startswith("interval"): field_match = re.match(r"interval (.+)", attype, re.I) diff --git a/ingestion/src/metadata/ingestion/source/database/vertica/queries.py b/ingestion/src/metadata/ingestion/source/database/vertica/queries.py index 054ba7df880..38e3ad5f453 100644 --- a/ingestion/src/metadata/ingestion/source/database/vertica/queries.py +++ b/ingestion/src/metadata/ingestion/source/database/vertica/queries.py @@ -35,7 +35,8 @@ VERTICA_GET_COLUMNS = textwrap.dedent( FROM v_catalog.columns col LEFT JOIN v_catalog.comments com ON com.object_type = 'COLUMN' - AND com.object_name LIKE CONCAT(CONCAT(col.table_name, '_%.'), col.column_name) + AND com.object_id = col.table_id + AND com.child_object = col.column_name WHERE lower(table_name) = '{table}' AND {schema_condition} UNION ALL