yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-09-01 21:23:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixes #18186: Quicksight Ingestion Error handled (#18218)

Browse Source
This commit is contained in:
Ayush Shah 2024-10-16 09:52:07 +05:30 committed by GitHub
parent 831cccf71e
commit 40bd3bd3fa
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 61 additions and 52 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
ingestion/src/metadata/ingestion/source/dashboard/quicksight/metadata.py
View File

@ -247,6 +247,7 @@ class QuicksightSource(DashboardServiceSource):
**data_source["RelationalTable"] **data_source["RelationalTable"]
) )
except (KeyError, ValidationError) as err: except (KeyError, ValidationError) as err:
data_source_resp = None
yield Either( yield Either(
left=StackTraceError( left=StackTraceError(
name="Lineage", name="Lineage",
@ -257,7 +258,7 @@ class QuicksightSource(DashboardServiceSource):
stackTrace=traceback.format_exc(), stackTrace=traceback.format_exc(),
) )
) )
if data_source_resp:
schema_name = data_source_resp.schema_name schema_name = data_source_resp.schema_name
table_name = data_source_resp.table_name table_name = data_source_resp.table_name
@ -283,14 +284,19 @@ class QuicksightSource(DashboardServiceSource):
DataSourceId=data_source_id, DataSourceId=data_source_id,
) )
).DataSource ).DataSource
if data_source_resp and data_source_resp.DataSourceParameters: if (
data_source_resp
and data_source_resp.DataSourceParameters
):
data_source_dict = data_source_resp.DataSourceParameters data_source_dict = data_source_resp.DataSourceParameters
for db in data_source_dict.keys() or []: for db in data_source_dict.keys() or []:
from_fqn = fqn.build( from_fqn = fqn.build(
self.metadata, self.metadata,
entity_type=Table, entity_type=Table,
service_name=db_service_name, service_name=db_service_name,
database_name=data_source_dict[db].get("Database"), database_name=data_source_dict[db].get(
"Database"
),
schema_name=schema_name, schema_name=schema_name,
table_name=table_name, table_name=table_name,
skip_es_search=True, skip_es_search=True,
@ -309,7 +315,10 @@ class QuicksightSource(DashboardServiceSource):
entity=Dashboard, entity=Dashboard,
fqn=to_fqn, fqn=to_fqn,
) )
if from_entity is not None and to_entity is not None: if (
from_entity is not None
and to_entity is not None
):
yield self._get_add_lineage_request( yield self._get_add_lineage_request(
to_entity=to_entity, from_entity=from_entity to_entity=to_entity, from_entity=from_entity
) )

4
ingestion/src/metadata/ingestion/source/dashboard/quicksight/models.py
View File

@ -50,12 +50,12 @@ class DashboardResp(BaseModel):
RequestId: Optional[str] = None RequestId: Optional[str] = None
class DataSource(BaseModel): class DataSourceModel(BaseModel):
DataSourceId: str DataSourceId: str
DataSourceParameters: Optional[dict] = None DataSourceParameters: Optional[dict] = None
class DescribeDataSourceResponse(BaseModel): class DescribeDataSourceResponse(BaseModel):
DataSource: Optional[DataSource] = None DataSource: Optional[DataSourceModel] = None
RequestId: Optional[str] = None RequestId: Optional[str] = None
Status: Optional[int] = None Status: Optional[int] = None