yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2026-01-05 12:07:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

MINOR: PowerBI improve error logging (#19249)

Browse Source
This commit is contained in:
harshsoni2024 2025-01-07 14:39:59 +05:30 committed by harshsoni2024
parent 922c3d2713
commit 40d48ba072
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
ingestion/src/metadata/ingestion/source/dashboard/powerbi/client.py
View File

@ -234,6 +234,9 @@ class PowerBiApiClient:
entities_per_page = self.config.pagination_entity_per_page
params_data = {"$top": "1"}
response_data = self.client.get(api_url, data=params_data)
if not response_data:
logger.debug("No groups/workspaces found")
return None
response = GroupsResponse(**response_data)
count = response.odata_count
indexes = math.ceil(count / entities_per_page)
@ -245,6 +248,9 @@ class PowerBiApiClient:
"$skip": str(index * entities_per_page),
}
response_data = self.client.get(api_url, data=params_data)
if not response_data:
logger.debug("No more groups/workspaces found")
continue
response = GroupsResponse(**response_data)
workspaces.extend(response.value)
return workspaces
@ -280,6 +286,7 @@ class PowerBiApiClient:
def fetch_workspace_scan_status(
self, scan_id: str
) -> Optional[WorkSpaceScanResponse]:
# deprecated in favour to avoide bulk data prepare
"""Get Workspace scan status by id method
Args:
scan_id:
@ -298,6 +305,7 @@ class PowerBiApiClient:
return None
def fetch_workspace_scan_result(self, scan_id: str) -> Optional[Workspaces]:
# deprecated in favour to avoide bulk data prepare
"""Get Workspace scan result by id method
Args:
scan_id:
@ -319,6 +327,7 @@ class PowerBiApiClient:
"""
Method to poll the scan status endpoint until the timeout
"""
# deprecated in favour to avoide bulk data prepare
min_sleep_time = 3
if min_sleep_time > timeout:
logger.info(f"Timeout is set to minimum sleep time: {timeout}")

2
ingestion/src/metadata/ingestion/source/dashboard/powerbi/metadata.py
View File

@ -167,7 +167,7 @@ class PowerbiSource(DashboardServiceSource):
Method to iterate through dashboard lists filter dashboards & yield dashboard details
"""
# fetch all workspaces/groups & apply filter pattern
all_workspaces = self.client.api_client.fetch_all_workspaces()
all_workspaces = self.client.api_client.fetch_all_workspaces() or []
all_workspaces = self.get_filtered_workspaces(all_workspaces)
for workspace in all_workspaces:
# prepare additional data for specific workspace (datasets, reports, dashboards)