From 420da29841f0a8b5d828e8b13aed306dbf0b1113 Mon Sep 17 00:00:00 2001
From: Iaroslav Frolikov <iaroslav.frolikov@toptal.com>
Date: Mon, 23 Oct 2023 12:12:06 +0200
Subject: [PATCH] Fixes #13607: BigQuery lineage ingestion fails when using
 GcpCredentialsPath authentication config (#13608)

---
 .../source/database/bigquery/query_parser.py  |  4 +++-
 .../unit/topology/database/test_bigquery.py   | 21 +++++++++++++++++++
 2 files changed, 24 insertions(+), 1 deletion(-)

diff --git a/ingestion/src/metadata/ingestion/source/database/bigquery/query_parser.py b/ingestion/src/metadata/ingestion/source/database/bigquery/query_parser.py
index 13edf4b0d95..3e15b051516 100644
--- a/ingestion/src/metadata/ingestion/source/database/bigquery/query_parser.py
+++ b/ingestion/src/metadata/ingestion/source/database/bigquery/query_parser.py
@@ -23,7 +23,7 @@ from metadata.generated.schema.entity.services.connections.database.bigQueryConn
 from metadata.generated.schema.metadataIngestion.workflow import (
     Source as WorkflowSource,
 )
-from metadata.generated.schema.security.credentials.gcpValues import MultipleProjectId
+from metadata.generated.schema.security.credentials.gcpValues import MultipleProjectId, GcpCredentialsValues
 from metadata.ingestion.api.steps import InvalidSourceException
 from metadata.ingestion.ometa.ometa_api import OpenMetadata
 from metadata.ingestion.source.database.bigquery.helper import get_inspector_details
@@ -69,6 +69,8 @@ class BigqueryQueryParserSource(QueryParserSource, ABC):
 
     def get_engine(self):
         if isinstance(
+                self.service_connection.credentials.gcpConfig, GcpCredentialsValues
+        ) and isinstance(
             self.service_connection.credentials.gcpConfig.projectId, MultipleProjectId
         ):
             project_ids = deepcopy(
diff --git a/ingestion/tests/unit/topology/database/test_bigquery.py b/ingestion/tests/unit/topology/database/test_bigquery.py
index 089b40adbb6..59a479688da 100644
--- a/ingestion/tests/unit/topology/database/test_bigquery.py
+++ b/ingestion/tests/unit/topology/database/test_bigquery.py
@@ -21,6 +21,7 @@ from metadata.generated.schema.entity.data.table import TableType
 from metadata.generated.schema.metadataIngestion.workflow import (
     OpenMetadataWorkflowConfig,
 )
+from metadata.ingestion.source.database.bigquery.lineage import BigqueryLineageSource
 from metadata.ingestion.source.database.bigquery.metadata import BigquerySource
 
 mock_bq_config = {
@@ -44,6 +45,11 @@ mock_bq_config = {
     },
 }
 
+mock_credentials_path_bq_config = mock_bq_config
+mock_credentials_path_bq_config["source"]["serviceConnection"]["config"]["credentials"]["gcpConfig"][
+    "__root__"
+] = "credentials.json"
+
 
 MOCK_DB_NAME = "random-project-id"
 MOCK_SCHEMA_NAME = "test_omd"
@@ -82,3 +88,18 @@ class BigqueryUnitTest(TestCase):
             ),
             EXPECTED_URL,
         )
+
+
+class BigqueryLineageSourceTest(TestCase):
+    @patch("metadata.ingestion.source.database.bigquery.connection.get_connection")
+    @patch("metadata.ingestion.source.database.bigquery.connection.test_connection")
+    @patch("metadata.ingestion.ometa.ometa_api.OpenMetadata")
+    def __init__(self, methodName, get_connection, test_connection, OpenMetadata) -> None:
+        super().__init__(methodName)
+
+        self.config = OpenMetadataWorkflowConfig.parse_obj(mock_credentials_path_bq_config)
+        self.bq_query_parser = BigqueryLineageSource(self.config.source, OpenMetadata())
+
+    def test_get_engine_without_project_id_specified(self):
+        for engine in self.bq_query_parser.get_engine():
+            assert engine is self.bq_query_parser.engine