diff --git a/catalog-rest-service/src/main/resources/json/schema/tests/column/columnValuesToBeNotNull.json b/catalog-rest-service/src/main/resources/json/schema/tests/column/columnValuesToBeNotNull.json index 32d1fe48951..da249f7d61f 100644 --- a/catalog-rest-service/src/main/resources/json/schema/tests/column/columnValuesToBeNotNull.json +++ b/catalog-rest-service/src/main/resources/json/schema/tests/column/columnValuesToBeNotNull.json @@ -5,6 +5,11 @@ "description": "This schema defines the test ColumnValuesToBeNotNull. Test the number of values in a column are null. Values must be explicitly null. Empty strings don't count as null. ", "type": "object", "javaType": "org.openmetadata.catalog.tests.column.ColumnValuesToBeNotNull", - "properties": {}, + "properties": { + "columnValuesToBeNotNull": { + "type": "boolean", + "default": true + } + }, "additionalProperties": false } diff --git a/catalog-rest-service/src/main/resources/json/schema/tests/column/columnValuesToBeUnique.json b/catalog-rest-service/src/main/resources/json/schema/tests/column/columnValuesToBeUnique.json index 94bb03e6bb7..6d57d1a5041 100644 --- a/catalog-rest-service/src/main/resources/json/schema/tests/column/columnValuesToBeUnique.json +++ b/catalog-rest-service/src/main/resources/json/schema/tests/column/columnValuesToBeUnique.json @@ -5,6 +5,11 @@ "description": "This schema defines the test ColumnValuesToBeUnique. Test the values in a column to be unique. ", "type": "object", "javaType": "org.openmetadata.catalog.tests.column.ColumnValuesToBeUnique", - "properties": {}, + "properties": { + "columnValuesToBeUnique": { + "type": "boolean", + "default": true + } + }, "additionalProperties": false } diff --git a/ingestion-core/src/metadata/_version.py b/ingestion-core/src/metadata/_version.py index 315c1541753..47fd72c4b50 100644 --- a/ingestion-core/src/metadata/_version.py +++ b/ingestion-core/src/metadata/_version.py @@ -7,5 +7,5 @@ Provides metadata version information. from incremental import Version -__version__ = Version("metadata", 0, 9, 0, dev=21) +__version__ = Version("metadata", 0, 9, 0, dev=22) __all__ = ["__version__"] diff --git a/ingestion/tests/unit/profiler/test_validation_parsing.py b/ingestion/tests/unit/profiler/test_validation_parsing.py index 827dc5f92c5..414e0844d20 100644 --- a/ingestion/tests/unit/profiler/test_validation_parsing.py +++ b/ingestion/tests/unit/profiler/test_validation_parsing.py @@ -51,7 +51,10 @@ def test_column_values_to_be_unique(): """ ColumnValuesToBeUnique """ - obj = {"config": {}, "columnTestType": "columnValuesToBeUnique"} + obj = { + "config": {"columnValuesToBeUnique": True}, + "columnTestType": "columnValuesToBeUnique", + } test_case = ColumnTestCase.parse_obj(obj) @@ -62,12 +65,14 @@ def test_column_values_to_be_not_null(): """ ColumnValuesToBeNotNull """ - obj = {"config": {}, "columnTestType": "columnValuesToBeNotNull"} + obj = { + "config": {"columnValuesToBeNotNull": True}, + "columnTestType": "columnValuesToBeNotNull", + } test_case = ColumnTestCase.parse_obj(obj) - # TODO: we should parse this properly - # assert isinstance(test_case.config, ColumnValuesToBeNotNull) + assert isinstance(test_case.config, ColumnValuesToBeNotNull) def test_column_values_to_be_between(): @@ -139,6 +144,15 @@ def test_column_values_missing_count_to_be_equal(): assert isinstance(test_case.config, ColumnValuesMissingCount) + obj = { + "config": {"missingCountValue": 10}, + "columnTestType": "columnValuesMissingCountToBeEqual", + } + + test_case = ColumnTestCase.parse_obj(obj) + + assert isinstance(test_case.config, ColumnValuesMissingCount) + def test_table_row_count_to_equal(): """