yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-07-13 12:08:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix #3221 - columnValuesToBeUnique vs. columnValuesToBeNotNull JSONs (#3255)

Browse Source 
Fix #3221 - columnValuesToBeUnique vs. columnValuesToBeNotNull JSONs (#3255)
This commit is contained in:
Pere Miquel Brull 2022-03-08 09:15:20 +01:00 committed by GitHub
parent a07bc411dc
commit 434aa30a92
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 31 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
catalog-rest-service/src/main/resources/json/schema/tests/column/columnValuesToBeNotNull.json
View File

@ -5,6 +5,11 @@
"description": "This schema defines the test ColumnValuesToBeNotNull. Test the number of values in a column are null. Values must be explicitly null. Empty strings don't count as null. ", "description": "This schema defines the test ColumnValuesToBeNotNull. Test the number of values in a column are null. Values must be explicitly null. Empty strings don't count as null. ",
"type": "object", "type": "object",
"javaType": "org.openmetadata.catalog.tests.column.ColumnValuesToBeNotNull", "javaType": "org.openmetadata.catalog.tests.column.ColumnValuesToBeNotNull",
"properties": {}, "properties": {
"columnValuesToBeNotNull": {
"type": "boolean",
"default": true
}
},
"additionalProperties": false "additionalProperties": false
} }

7
catalog-rest-service/src/main/resources/json/schema/tests/column/columnValuesToBeUnique.json
View File

@ -5,6 +5,11 @@
"description": "This schema defines the test ColumnValuesToBeUnique. Test the values in a column to be unique. ", "description": "This schema defines the test ColumnValuesToBeUnique. Test the values in a column to be unique. ",
"type": "object", "type": "object",
"javaType": "org.openmetadata.catalog.tests.column.ColumnValuesToBeUnique", "javaType": "org.openmetadata.catalog.tests.column.ColumnValuesToBeUnique",
"properties": {}, "properties": {
"columnValuesToBeUnique": {
"type": "boolean",
"default": true
}
},
"additionalProperties": false "additionalProperties": false
} }

2
ingestion-core/src/metadata/_version.py
View File

@ -7,5 +7,5 @@ Provides metadata version information.
from incremental import Version from incremental import Version
__version__ = Version("metadata", 0, 9, 0, dev=21) __version__ = Version("metadata", 0, 9, 0, dev=22)
__all__ = ["__version__"] __all__ = ["__version__"]

22
ingestion/tests/unit/profiler/test_validation_parsing.py
View File

@ -51,7 +51,10 @@ def test_column_values_to_be_unique():
""" """
ColumnValuesToBeUnique ColumnValuesToBeUnique
""" """
obj = {"config": {}, "columnTestType": "columnValuesToBeUnique"} obj = {
"config": {"columnValuesToBeUnique": True},
"columnTestType": "columnValuesToBeUnique",
}
test_case = ColumnTestCase.parse_obj(obj) test_case = ColumnTestCase.parse_obj(obj)
@ -62,12 +65,14 @@ def test_column_values_to_be_not_null():
""" """
ColumnValuesToBeNotNull ColumnValuesToBeNotNull
""" """
obj = {"config": {}, "columnTestType": "columnValuesToBeNotNull"} obj = {
"config": {"columnValuesToBeNotNull": True},
"columnTestType": "columnValuesToBeNotNull",
}
test_case = ColumnTestCase.parse_obj(obj) test_case = ColumnTestCase.parse_obj(obj)
# TODO: we should parse this properly assert isinstance(test_case.config, ColumnValuesToBeNotNull)
# assert isinstance(test_case.config, ColumnValuesToBeNotNull)
def test_column_values_to_be_between(): def test_column_values_to_be_between():
@ -139,6 +144,15 @@ def test_column_values_missing_count_to_be_equal():
assert isinstance(test_case.config, ColumnValuesMissingCount) assert isinstance(test_case.config, ColumnValuesMissingCount)
obj = {
"config": {"missingCountValue": 10},
"columnTestType": "columnValuesMissingCountToBeEqual",
}
test_case = ColumnTestCase.parse_obj(obj)
assert isinstance(test_case.config, ColumnValuesMissingCount)
def test_table_row_count_to_equal(): def test_table_row_count_to_equal():
""" """