yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-09-18 13:31:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed dbt test col name (#12065)

Browse Source
This commit is contained in:
Onkar Ravgan 2023-06-21 14:17:54 +05:30 committed by GitHub
parent b9d85bb27f
commit 47514f6c5f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
ingestion/src/metadata/ingestion/source/database/dbt/metadata.py
View File

@ -752,11 +752,12 @@ class DbtSource(DbtServiceSource): # pylint: disable=too-many-public-methods
entity=TestDefinition,
)
if not check_test_definition_exists:
column_name = manifest_node.column_name
if column_name:
entity_type = EntityType.TABLE
if (
hasattr(manifest_node, "column_name")
and manifest_node.column_name
):
entity_type = EntityType.COLUMN
else:
entity_type = EntityType.TABLE
yield CreateTestDefinitionRequest(
name=manifest_node.name,
description=manifest_node.description,
@ -874,7 +875,9 @@ class DbtSource(DbtServiceSource): # pylint: disable=too-many-public-methods
database_name=source_elements[1],
schema_name=source_elements[2],
table_name=source_elements[3],
column_name=manifest_node.column_name,
column_name=manifest_node.column_name
if hasattr(manifest_node, "column_name")
else None,
test_case_name=manifest_node.name,
)
self.metadata.add_test_case_results(
@ -915,7 +918,10 @@ class DbtSource(DbtServiceSource): # pylint: disable=too-many-public-methods
manifest_node = dbt_test.get(DbtCommonEnum.MANIFEST_NODE.value)
entity_link_list = [
entity_link.get_entity_link(
table_fqn=table_fqn, column_name=manifest_node.column_name
table_fqn=table_fqn,
column_name=manifest_node.column_name
if hasattr(manifest_node, "column_name")
else None,
)
for table_fqn in dbt_test[DbtCommonEnum.UPSTREAM.value]
]

2
ingestion/src/metadata/utils/fqn.py
View File

@ -377,7 +377,7 @@ def _(
database_name: str,
schema_name: str,
table_name: str,
column_name: str,
column_name: Optional[str],
test_case_name: str,
) -> str:
if column_name: