From 47c38b0088a97b4dc355c12247e4a378de2155e2 Mon Sep 17 00:00:00 2001
From: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
Date: Mon, 1 Jul 2024 16:45:04 +0530
Subject: [PATCH] fix(ui): switching tabs not taking effect (#16851)

* fix(ui): switching tabs not taking effect

* add unit tests

* update test
---
 .../pages/ServicesPage/ServicesPage.test.tsx  | 128 ++++++++++++++++++
 .../src/pages/ServicesPage/ServicesPage.tsx   |  14 +-
 2 files changed, 136 insertions(+), 6 deletions(-)
 create mode 100644 openmetadata-ui/src/main/resources/ui/src/pages/ServicesPage/ServicesPage.test.tsx

diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/ServicesPage/ServicesPage.test.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/ServicesPage/ServicesPage.test.tsx
new file mode 100644
index 00000000000..e0317e589f5
--- /dev/null
+++ b/openmetadata-ui/src/main/resources/ui/src/pages/ServicesPage/ServicesPage.test.tsx
@@ -0,0 +1,128 @@
+/*
+ *  Copyright 2024 Collate.
+ *  Licensed under the Apache License, Version 2.0 (the "License");
+ *  you may not use this file except in compliance with the License.
+ *  You may obtain a copy of the License at
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+import { act, render, screen } from '@testing-library/react';
+import React from 'react';
+import { MemoryRouter, Route } from 'react-router-dom';
+import { userPermissions } from '../../utils/PermissionsUtils';
+import ServicesPage from './ServicesPage';
+
+jest.mock(
+  '../../components/Settings/Services/Ingestion/IngestionPipelineList/IngestionPipelineList.component',
+  () => ({
+    IngestionPipelineList: jest
+      .fn()
+      .mockReturnValue(<>mockIngestionPipelineList</>),
+  })
+);
+
+jest.mock('../../components/Settings/Services/Services', () => {
+  return jest.fn().mockReturnValue(<>mockServices</>);
+});
+
+jest.mock('../../components/PageLayoutV1/PageLayoutV1', () => {
+  return jest.fn().mockImplementation(({ children }) => <>{children}</>);
+});
+
+jest.mock(
+  '../../components/common/ErrorWithPlaceholder/ErrorPlaceHolder',
+  () => {
+    return jest.fn().mockReturnValue(<>mockErrorPlaceHolder</>);
+  }
+);
+
+jest.mock(
+  '../../components/common/TitleBreadcrumb/TitleBreadcrumb.component',
+  () => {
+    return jest.fn().mockReturnValue(<>mockTitleBreadcrumb</>);
+  }
+);
+
+const mockEntityPermissions = {
+  Create: true,
+  Delete: true,
+  ViewAll: true,
+  ViewBasic: true,
+  EditAll: true,
+  EditTags: true,
+  EditDescription: true,
+  EditDisplayName: true,
+  EditCustomFields: true,
+};
+
+jest.mock('../../context/PermissionProvider/PermissionProvider', () => ({
+  usePermissionProvider: jest
+    .fn()
+    .mockImplementation(() => ({ permissions: mockEntityPermissions })),
+}));
+
+jest.mock('../../hooks/authHooks', () => ({
+  useAuth: jest.fn().mockReturnValue({
+    isAdminUser: true,
+  }),
+}));
+
+jest.mock('../../utils/GlobalSettingsUtils', () => ({
+  getSettingPageEntityBreadCrumb: jest.fn().mockReturnValue({
+    getSettingPageEntityBreadCrumb: jest.fn().mockReturnValue([]),
+  }),
+}));
+
+jest.mock('../../utils/PermissionsUtils', () => ({
+  userPermissions: {
+    hasViewPermissions: jest.fn().mockReturnValue(true),
+  },
+}));
+
+describe('ServicesPage', () => {
+  it('should render Services tab', async () => {
+    await act(async () => {
+      render(
+        <MemoryRouter initialEntries={['/services/databases']}>
+          <Route component={ServicesPage} path="/services/:tab" />
+        </MemoryRouter>
+      );
+    });
+
+    expect(await screen.findByText('mockServices')).toBeInTheDocument();
+  });
+
+  it('should render Pipelines tab', async () => {
+    await act(async () => {
+      render(
+        <MemoryRouter initialEntries={['/services/databases?tab=pipelines']}>
+          <Route component={ServicesPage} path="/services/:tab" />
+        </MemoryRouter>
+      );
+    });
+
+    expect(
+      await screen.findByText('mockIngestionPipelineList')
+    ).toBeInTheDocument();
+  });
+
+  it('should render ErrorPlaceholder when user does not have permission', async () => {
+    (userPermissions.hasViewPermissions as jest.Mock).mockImplementationOnce(
+      jest.fn().mockReturnValue(false)
+    );
+
+    await act(async () => {
+      render(
+        <MemoryRouter initialEntries={['/services/services']}>
+          <Route component={ServicesPage} path="/services/:tab" />
+        </MemoryRouter>
+      );
+    });
+
+    expect(await screen.findByText('mockErrorPlaceHolder')).toBeInTheDocument();
+  });
+});
diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/ServicesPage/ServicesPage.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/ServicesPage/ServicesPage.tsx
index bee069b5a3d..43c735786c7 100644
--- a/openmetadata-ui/src/main/resources/ui/src/pages/ServicesPage/ServicesPage.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/pages/ServicesPage/ServicesPage.tsx
@@ -42,14 +42,16 @@ const ServicesPage = () => {
   const history = useHistory();
   const { t } = useTranslation();
   const { isAdminUser } = useAuth();
+  const queryParams = qs.parse(
+    location.search.startsWith('?')
+      ? location.search.substring(1)
+      : location.search
+  );
   const search =
-    qs.parse(
-      location.search.startsWith('?')
-        ? location.search.substring(1)
-        : location.search
-    ).tab ?? tab === GlobalSettingOptions.DATA_OBSERVABILITY
+    queryParams.tab ??
+    (tab === GlobalSettingOptions.DATA_OBSERVABILITY
       ? 'pipelines'
-      : 'services';
+      : 'services');
 
   const serviceName = useMemo(
     () =>