From 4a407f6d0d8ffaec72637edf39d708d4568a602c Mon Sep 17 00:00:00 2001 From: Mayur Singal <39544459+ulixius9@users.noreply.github.com> Date: Mon, 7 Apr 2025 21:24:46 +0530 Subject: [PATCH] MINOR: Implement column validation in lineage patch api (#20545) --- ingestion/tests/integration/ometa/test_ometa_lineage_api.py | 4 ++-- .../org/openmetadata/service/jdbi3/LineageRepository.java | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/ingestion/tests/integration/ometa/test_ometa_lineage_api.py b/ingestion/tests/integration/ometa/test_ometa_lineage_api.py index f0024617554..d17a4869657 100644 --- a/ingestion/tests/integration/ometa/test_ometa_lineage_api.py +++ b/ingestion/tests/integration/ometa/test_ometa_lineage_api.py @@ -267,9 +267,9 @@ class OMetaLineageTest(TestCase): columnsLineage=[ ColumnLineage( fromColumns=[ - f"{self.table1_entity.fullyQualifiedName.root}.name" + f"{self.table1_entity.fullyQualifiedName.root}.another" ], - toColumn=f"{self.table2_entity.fullyQualifiedName.root}.name", + toColumn=f"{self.table2_entity.fullyQualifiedName.root}.another", ) ], ), diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/LineageRepository.java b/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/LineageRepository.java index d2b28f2be20..1b6d23fcb5a 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/LineageRepository.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/LineageRepository.java @@ -1146,7 +1146,8 @@ public class LineageRepository { updated.setUpdatedAt(System.currentTimeMillis()); updated.setUpdatedBy(updatedBy); - String detailsJson = JsonUtils.pojoToJson(updated); + // Validate Lineage Details + String detailsJson = validateLineageDetails(from, to, updated); dao.relationshipDAO() .insert(fromId, toId, fromEntity, toEntity, Relationship.UPSTREAM.ordinal(), detailsJson); addLineageToSearch(from, to, updated);