From 4b43fa207935db36d39069ad7a094039a2878584 Mon Sep 17 00:00:00 2001 From: Shailesh Parmar Date: Sat, 3 Feb 2024 11:54:51 +0530 Subject: [PATCH] Minor: Address feedback of Incident manager (#14997) * Minor: Address feedback of Incident manager * added provision to delete and update display name from test case detail page * address the feedback * added option to clear severity --- .../e2e/Features/IncidentManager.spec.js | 8 +- .../components/ParameterForm.tsx | 18 +++- .../TestCaseStatusModal.component.tsx | 1 + .../IncidentManagerPageHeader.component.tsx | 12 ++- .../Severity/SeverityModal.component.tsx | 1 + .../TestCaseResultTab.component.tsx | 2 +- .../component/TestSummary.tsx | 6 +- .../CustomMetricGraphs.component.tsx | 7 +- .../CustomMetricGraphs.test.tsx | 16 +++ .../Task/TaskTab/TaskTab.component.tsx | 49 ++++++++- .../IncidentManagerDetailPage.tsx | 99 ++++++++++++++----- .../pages/TasksPage/TasksPage.interface.ts | 1 + .../src/pages/TasksPage/shared/Assignees.tsx | 1 + .../resources/ui/src/rest/customMetricAPI.ts | 2 +- .../ui/src/utils/TasksUtils.test.tsx | 3 + .../main/resources/ui/src/utils/TasksUtils.ts | 2 + 16 files changed, 184 insertions(+), 44 deletions(-) diff --git a/openmetadata-ui/src/main/resources/ui/cypress/e2e/Features/IncidentManager.spec.js b/openmetadata-ui/src/main/resources/ui/cypress/e2e/Features/IncidentManager.spec.js index 70f1b041bbe..106e3da7019 100644 --- a/openmetadata-ui/src/main/resources/ui/cypress/e2e/Features/IncidentManager.spec.js +++ b/openmetadata-ui/src/main/resources/ui/cypress/e2e/Features/IncidentManager.spec.js @@ -269,10 +269,10 @@ describe('Incident Manager', () => { verifyResponseStatusCode('@getTestCase', 200); cy.get('[data-testid="incident"]').click(); verifyResponseStatusCode('@getTaskFeed', 200); - cy.get('[data-testid="task-cta-buttons"]') - .contains('Reassign') + cy.get('[data-testid="task-cta-buttons"] [role="img"]') .scrollIntoView() .click(); + cy.get('[role="menu"').find('[data-menu-id*="re-assign"]').click(); interceptURL( 'GET', '/api/v1/search/suggest?q=admin&index=*user_search_index*', @@ -309,10 +309,10 @@ describe('Incident Manager', () => { verifyResponseStatusCode('@getTestCase', 200); cy.get('[data-testid="incident"]').click(); verifyResponseStatusCode('@getTaskFeed', 200); - cy.get('[data-testid="task-cta-buttons"] [role="img"]') + cy.get('[data-testid="task-cta-buttons"]') + .contains('Resolve') .scrollIntoView() .click(); - cy.get('[role="menu"').find('[data-menu-id*="resolve"]').click(); cy.get('#testCaseFailureReason').click(); cy.get('[title="Missing Data"]').click(); cy.get('.toastui-editor-md-container > .toastui-editor > .ProseMirror') diff --git a/openmetadata-ui/src/main/resources/ui/src/components/AddDataQualityTest/components/ParameterForm.tsx b/openmetadata-ui/src/main/resources/ui/src/components/AddDataQualityTest/components/ParameterForm.tsx index 59c882cca62..0ba9d1f6ab4 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/AddDataQualityTest/components/ParameterForm.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/AddDataQualityTest/components/ParameterForm.tsx @@ -12,7 +12,15 @@ */ import { PlusOutlined } from '@ant-design/icons'; -import { Button, Form, Input, InputNumber, Select, Switch } from 'antd'; +import { + Button, + Form, + FormItemProps, + Input, + InputNumber, + Select, + Switch, +} from 'antd'; import 'codemirror/addon/fold/foldgutter.css'; import { isUndefined } from 'lodash'; import React from 'react'; @@ -32,6 +40,7 @@ const ParameterForm: React.FC = ({ definition, table }) => { const { t } = useTranslation(); const prepareForm = (data: TestCaseParameterDefinition) => { + let internalFormItemProps: FormItemProps = {}; let Field = ( = ({ definition, table }) => { break; case TestDataType.Boolean: Field = ; + internalFormItemProps = { + ...internalFormItemProps, + valuePropName: 'checked', + }; break; case TestDataType.Array: @@ -204,7 +217,8 @@ const ParameterForm: React.FC = ({ definition, table }) => { })}`, }, ]} - tooltip={data.description}> + tooltip={data.description} + {...internalFormItemProps}> {Field} ); diff --git a/openmetadata-ui/src/main/resources/ui/src/components/DataQuality/TestCaseStatusModal/TestCaseStatusModal.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/DataQuality/TestCaseStatusModal/TestCaseStatusModal.component.tsx index 6171a6a2e2c..5cedd22a8ad 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/DataQuality/TestCaseStatusModal/TestCaseStatusModal.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/DataQuality/TestCaseStatusModal/TestCaseStatusModal.component.tsx @@ -103,6 +103,7 @@ export const TestCaseStatusModal = ({ ...data.testCaseResolutionStatusDetails, assignee: { name: updatedAssignees[0].name, + displayName: updatedAssignees[0].displayName, id: updatedAssignees[0].value, type: EntityType.USER, }, diff --git a/openmetadata-ui/src/main/resources/ui/src/components/IncidentManager/IncidentManagerPageHeader/IncidentManagerPageHeader.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/IncidentManager/IncidentManagerPageHeader/IncidentManagerPageHeader.component.tsx index 3bde0edc411..708a9353b4b 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/IncidentManager/IncidentManagerPageHeader/IncidentManagerPageHeader.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/IncidentManager/IncidentManagerPageHeader/IncidentManagerPageHeader.component.tsx @@ -10,7 +10,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -import { Divider, Skeleton, Space, Typography } from 'antd'; +import { Divider, Skeleton, Space, Tooltip, Typography } from 'antd'; import { AxiosError } from 'axios'; import { compare } from 'fast-json-patch'; import { first, isUndefined, last } from 'lodash'; @@ -274,9 +274,13 @@ const IncidentManagerPageHeader = ({ {`${t('label.test-type')}: `} - - {getEntityName(testCaseData?.testDefinition)} - + + + {getEntityName(testCaseData?.testDefinition)} + + ); diff --git a/openmetadata-ui/src/main/resources/ui/src/components/IncidentManager/Severity/SeverityModal.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/IncidentManager/Severity/SeverityModal.component.tsx index f4f772d17ff..7bf5f26e674 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/IncidentManager/Severity/SeverityModal.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/IncidentManager/Severity/SeverityModal.component.tsx @@ -60,6 +60,7 @@ const SeverityModal = ({ onFinish={handleFormSubmit}>