From 4c537f2d6889f2fde3e62154f64962b0e9a28ef7 Mon Sep 17 00:00:00 2001 From: Onkar Ravgan Date: Tue, 30 Jan 2024 14:05:51 +0530 Subject: [PATCH] MINOR: Fix E2E failures (#14940) Co-authored-by: Ayush Shah --- .../tests/cli_e2e/database/athena/athena.yaml | 3 +++ ingestion/tests/cli_e2e/test_cli_mssql.py | 10 ++++----- ingestion/tests/cli_e2e/test_cli_redshift.py | 22 +++++++++---------- 3 files changed, 17 insertions(+), 18 deletions(-) diff --git a/ingestion/tests/cli_e2e/database/athena/athena.yaml b/ingestion/tests/cli_e2e/database/athena/athena.yaml index 8d4025cc615..9643b80b75e 100644 --- a/ingestion/tests/cli_e2e/database/athena/athena.yaml +++ b/ingestion/tests/cli_e2e/database/athena/athena.yaml @@ -12,6 +12,9 @@ source: sourceConfig: config: type: DatabaseMetadata + schemaFilterPattern: + includes: + - e2e_db sink: type: metadata-rest config: {} diff --git a/ingestion/tests/cli_e2e/test_cli_mssql.py b/ingestion/tests/cli_e2e/test_cli_mssql.py index b7c2a68e7a5..8450ba21506 100644 --- a/ingestion/tests/cli_e2e/test_cli_mssql.py +++ b/ingestion/tests/cli_e2e/test_cli_mssql.py @@ -15,8 +15,6 @@ MSSQL E2E tests from typing import List -from metadata.generated.schema.entity.data.table import Histogram - from .common.test_cli_db import CliCommonDB from .common_e2e_sqa_mixins import SQACommonMethods @@ -149,10 +147,10 @@ class MSSQLCliTest(CliCommonDB.TestSuite, SQACommonMethods): "distinctProportion": 1.0, "duplicateCount": None, "firstQuartile": 2.5, - "histogram": Histogram( - boundaries=["1.00 to 3.77", "3.77 and up"], - frequencies=[1, 2], - ), + "histogram": { + "boundaries": ["1.000 to 3.773", "3.773 and up"], + "frequencies": [1, 2], + }, "interQuartileRange": 2.0, "max": 5.0, "maxLength": None, diff --git a/ingestion/tests/cli_e2e/test_cli_redshift.py b/ingestion/tests/cli_e2e/test_cli_redshift.py index e90af0ab776..c86aaa79bfa 100644 --- a/ingestion/tests/cli_e2e/test_cli_redshift.py +++ b/ingestion/tests/cli_e2e/test_cli_redshift.py @@ -15,8 +15,6 @@ Redshift E2E tests from typing import List -from metadata.generated.schema.entity.data.table import Histogram - from .common.test_cli_db import CliCommonDB from .common_e2e_sqa_mixins import SQACommonMethods @@ -158,17 +156,17 @@ class RedshiftCliTest(CliCommonDB.TestSuite, SQACommonMethods): "distinctProportion": 1.0, "duplicateCount": None, "firstQuartile": -451.0775, - "histogram": Histogram( - boundaries=[ - "-999.63 to -665.73", - "-665.73 to -331.83", - "-331.83 to 2.06", - "2.06 to 335.96", - "335.96 to 669.86", - "669.86 and up", + "histogram": { + "boundaries": [ + "-999.630 to -665.732", + "-665.732 to -331.834", + "-331.834 to 2.064", + "2.064 to 335.962", + "335.962 to 669.859", + "669.859 and up", ], - frequencies=[3, 7, 6, 1, 2, 3], - ), + "frequencies": [3, 7, 6, 1, 2, 3], + }, "interQuartileRange": 467.7975, "max": 856.41, "maxLength": None,