yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-08-19 06:28:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix: #2694 removed entity api calls for recently viewed data (#2755)

Browse Source
This commit is contained in:
darth-coder00 2022-02-15 07:50:04 +05:30 committed by GitHub
parent 76f4ccd590
commit 4c67a8d3d2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 16 additions and 152 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

163
openmetadata-ui/src/main/resources/ui/src/components/recently-viewed/RecentlyViewed.tsx
View File

@ -13,18 +13,7 @@
import { FormatedTableData } from 'Models';
import React, { FunctionComponent, useEffect, useState } from 'react';
import { getDashboardByFqn } from '../../axiosAPIs/dashboardAPI';
import { getPipelineByFqn } from '../../axiosAPIs/pipelineAPI';
import { getTableDetailsByFQN } from '../../axiosAPIs/tableAPI';
import { getTopicByFqn } from '../../axiosAPIs/topicsAPI';
import { EntityType } from '../../enums/entity.enum';
import { SearchIndex } from '../../enums/search.enum';
import {
getRecentlyViewedData,
setRecentlyViewedData,
} from '../../utils/CommonUtils';
import { getOwnerFromId, getTierTags } from '../../utils/TableUtils';
import { getTableTags } from '../../utils/TagsUtils';
import { getRecentlyViewedData } from '../../utils/CommonUtils';
import EntityList from '../EntityList/EntityList';
import Loader from '../Loader/Loader';
@ -33,147 +22,19 @@ const RecentlyViewed: FunctionComponent = () => {
const [data, setData] = useState<Array<FormatedTableData>>([]);
const [isLoading, setIsloading] = useState<boolean>(false);
const fetchRecentlyViewedEntity = async () => {
setIsloading(true);
const arrData: Array<FormatedTableData> = [];
let filteredRecentData = [...recentlyViewedData];
for (const oData of recentlyViewedData) {
// for (let i = 0; i < recentlyViewedData.length; i++) {
// const oData = recentlyViewedData[i];
try {
switch (oData.entityType) {
case EntityType.TABLE: {
const res = await getTableDetailsByFQN(
oData.fqn,
'usageSummary, tags, owner,columns'
);
const {
description,
id,
name,
columns,
owner,
usageSummary,
fullyQualifiedName,
tags,
} = res.data;
const tableTags = getTableTags(columns || []);
arrData.push({
description,
fullyQualifiedName,
id,
index: SearchIndex.TABLE,
name,
owner: getOwnerFromId(owner?.id)?.name || '--',
serviceType: oData.serviceType,
tags: [...tableTags].filter((tag) => tag),
tier: getTierTags(tags),
weeklyPercentileRank:
usageSummary?.weeklyStats.percentileRank || 0,
});
break;
}
case EntityType.TOPIC: {
const res = await getTopicByFqn(oData.fqn, 'owner, tags');
const { description, id, name, tags, owner, fullyQualifiedName } =
res.data;
arrData.push({
description,
fullyQualifiedName,
id,
index: SearchIndex.TOPIC,
name,
owner: getOwnerFromId(owner?.id)?.name || '--',
serviceType: oData.serviceType,
tags: tags,
tier: getTierTags(tags),
});
break;
}
case EntityType.DASHBOARD: {
const res = await getDashboardByFqn(
oData.fqn,
'owner, tags, usageSummary'
);
const {
description,
id,
displayName,
tags,
owner,
fullyQualifiedName,
} = res.data;
arrData.push({
description,
fullyQualifiedName,
id,
index: SearchIndex.DASHBOARD,
name: displayName,
owner: getOwnerFromId(owner?.id)?.name || '--',
serviceType: oData.serviceType,
tags: tags,
tier: getTierTags(tags),
});
break;
}
case EntityType.PIPELINE: {
const res = await getPipelineByFqn(
oData.fqn,
'owner, tags, usageSummary'
);
const {
description,
id,
displayName,
tags,
owner,
fullyQualifiedName,
} = res.data;
arrData.push({
description,
fullyQualifiedName,
id,
index: SearchIndex.PIPELINE,
name: displayName,
owner: getOwnerFromId(owner?.id)?.name || '--',
serviceType: oData.serviceType,
tags: tags,
tier: getTierTags(tags),
});
break;
}
default:
break;
}
} catch {
filteredRecentData = filteredRecentData.filter(
(data) => data.fqn !== oData.fqn
);
continue;
}
}
if (filteredRecentData.length !== recentlyViewedData.length) {
setRecentlyViewedData(filteredRecentData);
}
setIsloading(false);
setData(arrData);
};
useEffect(() => {
if (recentlyViewedData.length) {
fetchRecentlyViewedEntity();
setIsloading(true);
const formatedData = recentlyViewedData.map((data) => {
return {
serviceType: data.serviceType,
name: data.displayName || data.fqn.split('.')[1],
fullyQualifiedName: data.fqn,
index: data.entityType,
};
});
setData(formatedData as unknown as FormatedTableData[]);
setIsloading(false);
}
}, []);

1
openmetadata-ui/src/main/resources/ui/src/interface/types.d.ts vendored
View File

@ -388,6 +388,7 @@ declare module 'Models' {
// topic interface end
interface RecentlyViewedData {
displayName?: string;
entityType: 'table' | 'topic' | 'dashboard' | 'pipeline';
fqn: string;
serviceType?: string;

1
openmetadata-ui/src/main/resources/ui/src/pages/DashboardDetailsPage/DashboardDetailsPage.component.tsx
View File

@ -275,6 +275,7 @@ const DashboardDetailsPage = () => {
]);
addToRecentViewed({
displayName,
entityType: EntityType.DASHBOARD,
fqn: fullyQualifiedName,
serviceType: serviceType,

1
openmetadata-ui/src/main/resources/ui/src/pages/PipelineDetails/PipelineDetailsPage.component.tsx
View File

@ -224,6 +224,7 @@ const PipelineDetailsPage = () => {
]);
addToRecentViewed({
displayName,
entityType: EntityType.PIPELINE,
fqn: fullyQualifiedName,
serviceType: serviceType,

2
openmetadata-ui/src/main/resources/ui/src/utils/CommonUtils.tsx
View File

@ -275,7 +275,7 @@ export const addToRecentViewed = (eData: RecentlyViewedData): void => {
data: [entityData],
};
}
reactLocalStorage.setObject(LOCALSTORAGE_RECENTLY_VIEWED, recentlyViewed);
setRecentlyViewedData(recentlyViewed.data);
};
export const getHtmlForNonAdminAction = (isClaimOwner: boolean) => {