From 4fe9c247e85e162087e7fb7571b5a1d43c7b64d1 Mon Sep 17 00:00:00 2001
From: Pranita Fulsundar <pfulsundar8@gmail.com>
Date: Thu, 24 Apr 2025 18:43:37 +0530
Subject: [PATCH] minor(ui): fix placeholder styles (#20910)

* fix: placeholder styles

* fix glossary placeholder styles

* address pr comments
---
 .../src/components/Customization/GenericTab/generic-tab.less  | 2 +-
 .../Glossary/GlossaryTermTab/GlossaryTermTab.component.tsx    | 4 ++--
 .../components/Settings/Team/TeamDetails/TeamDetailsV1.tsx    | 4 ++--
 .../Settings/Team/TeamDetails/UserTab/UserTab.component.tsx   | 2 +-
 .../components/common/ResizablePanels/resizable-panels.less   | 1 -
 .../PoliciesPage/PoliciesDetailPage/PoliciesDetailPage.tsx    | 4 ++--
 .../src/pages/RolesPage/RolesDetailPage/RolesDetailPage.tsx   | 4 +++-
 .../ui/src/pages/ServiceDetailsPage/ServiceDetailsPage.tsx    | 2 +-
 8 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Customization/GenericTab/generic-tab.less b/openmetadata-ui/src/main/resources/ui/src/components/Customization/GenericTab/generic-tab.less
index 8b20eabe8a8..d353057bd0f 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/Customization/GenericTab/generic-tab.less
+++ b/openmetadata-ui/src/main/resources/ui/src/components/Customization/GenericTab/generic-tab.less
@@ -10,8 +10,8 @@
  *  See the License for the specific language governing permissions and
  *  limitations under the License.
  */
-@import (reference) url('../../../styles/variables.less');
 @import (reference) url('antd/dist/antd.variable.less');
+@import (reference) url('../../../styles/variables.less');
 
 .grid-container {
   .react-grid-item {
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Glossary/GlossaryTermTab/GlossaryTermTab.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Glossary/GlossaryTermTab/GlossaryTermTab.component.tsx
index cf0ae4e1b37..8693cab331c 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/Glossary/GlossaryTermTab/GlossaryTermTab.component.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/Glossary/GlossaryTermTab/GlossaryTermTab.component.tsx
@@ -828,9 +828,9 @@ const GlossaryTermTab = ({ isGlossary, className }: GlossaryTermTabProps) => {
   if (isEmpty(glossaryTerms)) {
     return (
       // If there is no terms, the table container ref is not set, so we need to use a div to set the width
-      <div ref={tableContainerRef}>
+      <div className="h-full" ref={tableContainerRef}>
         <ErrorPlaceHolder
-          className="p-md p-b-lg"
+          className="p-md p-b-lg border-none"
           doc={GLOSSARIES_DOCS}
           heading={t('label.glossary-term')}
           permission={permissions.Create}
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Settings/Team/TeamDetails/TeamDetailsV1.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Settings/Team/TeamDetails/TeamDetailsV1.tsx
index f779def02f3..6809c2313ef 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/Settings/Team/TeamDetails/TeamDetailsV1.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/Settings/Team/TeamDetails/TeamDetailsV1.tsx
@@ -60,8 +60,8 @@ import { OwnerType } from '../../../../enums/user.enum';
 import { Operation } from '../../../../generated/entity/policies/policy';
 import { Team, TeamType } from '../../../../generated/entity/teams/team';
 import {
-  User,
   EntityReference as UserTeams,
+  User,
 } from '../../../../generated/entity/teams/user';
 import { EntityReference } from '../../../../generated/type/entityReference';
 import { useAuth } from '../../../../hooks/authHooks';
@@ -250,7 +250,7 @@ const TeamDetailsV1 = ({
     }: PlaceholderProps) => (
       <ErrorPlaceHolder
         button={button}
-        className="mt-0-important border-none"
+        className="mt-0-important border-none p-lg"
         doc={doc}
         heading={heading}
         permission={permission}
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Settings/Team/TeamDetails/UserTab/UserTab.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Settings/Team/TeamDetails/UserTab/UserTab.component.tsx
index ad732562fd3..f3d0a773911 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/Settings/Team/TeamDetails/UserTab/UserTab.component.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/Settings/Team/TeamDetails/UserTab/UserTab.component.tsx
@@ -355,7 +355,7 @@ export const UserTab = ({
             )}
           </Space>
         }
-        className="mt-0-important"
+        className="mt-0-important border-none"
         heading={t('label.user')}
         permission={editUserPermission}
         type={ERROR_PLACEHOLDER_TYPE.ASSIGN}
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/common/ResizablePanels/resizable-panels.less b/openmetadata-ui/src/main/resources/ui/src/components/common/ResizablePanels/resizable-panels.less
index fcf30267303..3b3153cd173 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/common/ResizablePanels/resizable-panels.less
+++ b/openmetadata-ui/src/main/resources/ui/src/components/common/ResizablePanels/resizable-panels.less
@@ -46,7 +46,6 @@ body.reflex-row-resize {
 .reflex-container.vertical {
   flex-direction: row;
   min-width: 1px;
-  border-radius: 12px;
 }
 
 .reflex-container > .reflex-element {
diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/PoliciesPage/PoliciesDetailPage/PoliciesDetailPage.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/PoliciesPage/PoliciesDetailPage/PoliciesDetailPage.tsx
index 3e9d6431d5f..cc9dbc276d3 100644
--- a/openmetadata-ui/src/main/resources/ui/src/pages/PoliciesPage/PoliciesDetailPage/PoliciesDetailPage.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/pages/PoliciesPage/PoliciesDetailPage/PoliciesDetailPage.tsx
@@ -530,9 +530,9 @@ const PoliciesDetailPage = () => {
 
         <>
           {isEmpty(policy) ? (
-            <ErrorPlaceHolder className="border-none">
+            <ErrorPlaceHolder className="border-none h-min-80">
               <div className="text-center">
-                <p>
+                <p className="m-y-sm">
                   {t('message.no-entity-found-for-name', {
                     entity: t('label.policy-lowercase'),
                     name: fqn,
diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/RolesPage/RolesDetailPage/RolesDetailPage.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/RolesPage/RolesDetailPage/RolesDetailPage.tsx
index 7de1485985d..d17374744d9 100644
--- a/openmetadata-ui/src/main/resources/ui/src/pages/RolesPage/RolesDetailPage/RolesDetailPage.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/pages/RolesPage/RolesDetailPage/RolesDetailPage.tsx
@@ -367,7 +367,9 @@ const RolesDetailPage = () => {
         <TitleBreadcrumb titleLinks={breadcrumb} />
 
         {isEmpty(role) ? (
-          <ErrorPlaceHolder type={ERROR_PLACEHOLDER_TYPE.CUSTOM}>
+          <ErrorPlaceHolder
+            className="h-min-80 border-none"
+            type={ERROR_PLACEHOLDER_TYPE.CUSTOM}>
             <div className="text-center">
               <p>
                 {t('message.no-entity-found-for-name', {
diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/ServiceDetailsPage/ServiceDetailsPage.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/ServiceDetailsPage/ServiceDetailsPage.tsx
index 1161b2ffea7..99560da8741 100644
--- a/openmetadata-ui/src/main/resources/ui/src/pages/ServiceDetailsPage/ServiceDetailsPage.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/pages/ServiceDetailsPage/ServiceDetailsPage.tsx
@@ -1370,7 +1370,7 @@ const ServiceDetailsPage: FunctionComponent = () => {
         entity: getEntityName(serviceDetails),
       })}>
       {isEmpty(serviceDetails) ? (
-        <ErrorPlaceHolder className="m-0">
+        <ErrorPlaceHolder className="m-0 h-min-80">
           {getEntityMissingError(serviceCategory as string, decodedServiceFQN)}
         </ErrorPlaceHolder>
       ) : (