Ui improvements and fixes (#6966)

* Ui improvements and fixes

* Fixed failing unit tests
This commit is contained in:
Aniket Katkar 2022-08-27 07:20:48 +05:30 committed by GitHub
parent 2a3a6141ef
commit 5168c8afb0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
19 changed files with 22 additions and 22 deletions

View File

@ -170,7 +170,7 @@ const DashboardDetails = ({
position: 1,
},
{
name: 'Activity Feed & Tasks',
name: 'Activity Feeds & Tasks',
icon: {
alt: 'activity_feed',
name: 'activity_feed',

View File

@ -282,7 +282,7 @@ describe('Test DashboardDetails component', () => {
const description = await findByText(container, /Description Component/i);
const tabs = await findByTestId(container, 'tabs');
const detailsTab = await findByTestId(tabs, 'Details');
const activityFeedTab = await findByTestId(tabs, 'Activity Feed & Tasks');
const activityFeedTab = await findByTestId(tabs, 'Activity Feeds & Tasks');
const lineageTab = await findByTestId(tabs, 'Lineage');
expect(EntityPageInfo).toBeInTheDocument();

View File

@ -211,7 +211,7 @@ const DatasetDetails: React.FC<DatasetDetailsProps> = ({
position: 1,
},
{
name: 'Activity Feed & Tasks',
name: 'Activity Feeds & Tasks',
icon: {
alt: 'activity_feed',
name: 'activity_feed',
@ -389,14 +389,14 @@ const DatasetDetails: React.FC<DatasetDetailsProps> = ({
},
{ key: 'Type', value: `${tableType}`, showLabel: true },
{ value: usage },
{ value: `${weeklyUsageCount} queries` },
{ value: `${weeklyUsageCount} Queries` },
{
key: 'Columns',
value:
tableProfile && tableProfile?.columnCount
? `${tableProfile.columnCount} columns`
? `${tableProfile.columnCount} Columns`
: columns.length
? `${columns.length} columns`
? `${columns.length} Columns`
: '',
},
{

View File

@ -237,7 +237,7 @@ describe('Test MyDataDetailsPage page', () => {
const description = await findByText(container, /Description/i);
const tabs = await findByTestId(container, 'tabs');
const schemaTab = await findByTestId(tabs, 'Schema');
const activityFeedTab = await findByTestId(tabs, 'Activity Feed & Tasks');
const activityFeedTab = await findByTestId(tabs, 'Activity Feeds & Tasks');
const sampleDataTab = await findByTestId(tabs, 'Sample Data');
const queriesTab = await findByTestId(tabs, 'Queries');
const profilerTab = await findByTestId(tabs, 'Profiler');

View File

@ -111,7 +111,7 @@ const MyData: React.FC<MyDataProps> = ({
title="Tasks"
width="16px"
/>
{pendingTaskCount} Pending tasks
{pendingTaskCount} Pending task{pendingTaskCount > 1 && 's'}
</div>
}
/>

View File

@ -166,7 +166,7 @@ const PipelineDetails = ({
position: 1,
},
{
name: 'Activity Feed & Tasks',
name: 'Activity Feeds & Tasks',
icon: {
alt: 'activity_feed',
name: 'activity_feed',

View File

@ -204,7 +204,7 @@ describe('Test PipelineDetails component', () => {
const description = await findByText(container, /Description Component/i);
const tabs = await findByTestId(container, 'tabs');
const detailsTab = await findByTestId(tabs, 'Details');
const activityFeedTab = await findByTestId(tabs, 'Activity Feed & Tasks');
const activityFeedTab = await findByTestId(tabs, 'Activity Feeds & Tasks');
const lineageTab = await findByTestId(tabs, 'Lineage');
expect(EntityPageInfo).toBeInTheDocument();

View File

@ -193,7 +193,7 @@ const ProfilerDashboard: React.FC<ProfilerDashboardProps> = ({
{
value: `${
table.usageSummary?.weeklyStats?.count.toLocaleString() || '--'
} queries`,
} Queries`,
},
];
}, [table]);

View File

@ -179,7 +179,7 @@ const TopicDetails: React.FC<TopicDetailsProps> = ({
position: 1,
},
{
name: 'Activity Feed & Tasks',
name: 'Activity Feeds & Tasks',
icon: {
alt: 'activity_feed',
name: 'activity_feed',

View File

@ -177,7 +177,7 @@ describe('Test TopicDetails component', () => {
const description = await findByText(container, /Description Component/i);
const tabs = await findByTestId(container, 'tabs');
const schemaTab = await findByTestId(tabs, 'Schema');
const activityFeedTab = await findByTestId(tabs, 'Activity Feed & Tasks');
const activityFeedTab = await findByTestId(tabs, 'Activity Feeds & Tasks');
const configTab = await findByTestId(tabs, 'Config');
expect(EntityPageInfo).toBeInTheDocument();

View File

@ -257,7 +257,7 @@ const NavBar = ({
className="tw-relative search-grey hover:tw-outline-none focus:tw-outline-none tw-pl-2 tw-pt-2 tw-pb-1.5 tw-ml-4 tw-z-41"
data-testid="searchBox"
id="searchBox"
placeholder="Search for Table, Topics, Dashboards,Pipeline and ML Models"
placeholder="Search for Tables, Topics, Dashboards, Pipelines and ML Models"
style={{
borderRadius: '0.24rem',
boxShadow: 'none',

View File

@ -150,7 +150,7 @@ const DatabaseSchemaPage: FunctionComponent = () => {
position: 1,
},
{
name: 'Activity Feed',
name: 'Activity Feeds',
icon: {
alt: 'activity_feed',
name: 'activity_feed',

View File

@ -158,7 +158,7 @@ const DatabaseDetails: FunctionComponent = () => {
position: 1,
},
{
name: 'Activity Feed',
name: 'Activity Feeds',
icon: {
alt: 'activity_feed',
name: 'activity_feed',

View File

@ -22,7 +22,7 @@ export const dashboardDetailsTabs = [
path: 'details',
},
{
name: 'Activity Feed & Tasks',
name: 'Activity Feeds & Tasks',
path: 'activity_feed',
field: TabSpecificField.ACTIVITY_FEED,
},

View File

@ -6,7 +6,7 @@ export const databaseDetailsTabs = [
path: 'schemas',
},
{
name: 'Activity Feed',
name: 'Activity Feeds',
path: 'activity_feed',
field: TabSpecificField.ACTIVITY_FEED,
},

View File

@ -6,7 +6,7 @@ export const databaseSchemaDetailsTabs = [
path: 'tables',
},
{
name: 'Activity Feed',
name: 'Activity Feeds',
path: 'activity_feed',
field: TabSpecificField.ACTIVITY_FEED,
},

View File

@ -23,7 +23,7 @@ export const datasetTableTabs = [
path: 'schema',
},
{
name: 'Activity Feed & Tasks',
name: 'Activity Feeds & Tasks',
path: 'activity_feed',
field: TabSpecificField.ACTIVITY_FEED,
},

View File

@ -28,7 +28,7 @@ export const pipelineDetailsTabs = [
path: 'details',
},
{
name: 'Activity Feed & Tasks',
name: 'Activity Feeds & Tasks',
path: 'activity_feed',
field: TabSpecificField.ACTIVITY_FEED,
},

View File

@ -19,7 +19,7 @@ export const topicDetailsTabs = [
path: 'schema',
},
{
name: 'Activity Feed & Tasks',
name: 'Activity Feeds & Tasks',
path: 'activity_feed',
field: TabSpecificField.ACTIVITY_FEED,
},