From 52571efdc90c8e3c46a8c7f94843e8458c71198d Mon Sep 17 00:00:00 2001 From: Shailesh Parmar Date: Mon, 13 Dec 2021 22:31:15 +0530 Subject: [PATCH] Ui improvement as per feedback (#1727) * Ui improvement as per feedback * miner fix --- .../components/EntityLineage/EntityLineage.component.tsx | 4 ++-- .../components/TableProfiler/TableProfiler.component.tsx | 2 +- .../card-list/CardListItem/CardWithListItems.style.ts | 2 +- .../common/error-with-placeholder/ErrorPlaceHolderES.tsx | 8 +++++--- .../src/main/resources/ui/src/styles/tailwind.css | 2 +- 5 files changed, 10 insertions(+), 8 deletions(-) diff --git a/openmetadata-ui/src/main/resources/ui/src/components/EntityLineage/EntityLineage.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/EntityLineage/EntityLineage.component.tsx index 4a7e5436f8f..56a2b19a8b1 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/EntityLineage/EntityLineage.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/EntityLineage/EntityLineage.component.tsx @@ -96,7 +96,7 @@ const getNoLineageDataPlaceholder = () => {
Lineage is currently supported for Airflow. To enable lineage collection - from Airflow, Please follow the documentation + from Airflow, please follow the documentation { pathname: 'https://docs.open-metadata.org/install/metadata-ingestion/airflow/configure-airflow-lineage', }}> - here + here.
); diff --git a/openmetadata-ui/src/main/resources/ui/src/components/TableProfiler/TableProfiler.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/TableProfiler/TableProfiler.component.tsx index fb1aff61c82..02314f36bb8 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/TableProfiler/TableProfiler.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/TableProfiler/TableProfiler.component.tsx @@ -220,7 +220,7 @@ const TableProfiler = ({ tableProfiles, columns }: Props) => { to={{ pathname: 'https://docs.open-metadata.org/connectors', }}> - here + here. )} diff --git a/openmetadata-ui/src/main/resources/ui/src/components/card-list/CardListItem/CardWithListItems.style.ts b/openmetadata-ui/src/main/resources/ui/src/components/card-list/CardListItem/CardWithListItems.style.ts index 8e40753f299..436048c77fd 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/card-list/CardListItem/CardWithListItems.style.ts +++ b/openmetadata-ui/src/main/resources/ui/src/components/card-list/CardListItem/CardWithListItems.style.ts @@ -17,7 +17,7 @@ export const cardStyle = { active: 'tw-border-primary', header: { base: 'tw-flex tw-px-5 tw-py-3 tw-cursor-pointer tw-justify-between tw-items-center', - default: 'tw-bg-tag', + default: 'tw-bg-badge', active: 'tw-bg-primary tw-rounded-t-md tw-text-white', title: 'tw-text-base tw-mb-0', description: 'tw-font-medium tw-pr-2', diff --git a/openmetadata-ui/src/main/resources/ui/src/components/common/error-with-placeholder/ErrorPlaceHolderES.tsx b/openmetadata-ui/src/main/resources/ui/src/components/common/error-with-placeholder/ErrorPlaceHolderES.tsx index c5b524b247e..86573891e8c 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/common/error-with-placeholder/ErrorPlaceHolderES.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/common/error-with-placeholder/ErrorPlaceHolderES.tsx @@ -130,9 +130,11 @@ const ErrorPlaceHolderES = ({ type, errorMessage, query = '' }: Props) => { return (
-

- {`Hi, ${getUserDisplayName()}!`} -

+ {type !== 'noData' && ( +

+ {`Hi, ${getUserDisplayName()}!`} +

+ )} {type === 'noData' && noRecordForES()} {type === 'error' && elasticSearchError()}
diff --git a/openmetadata-ui/src/main/resources/ui/src/styles/tailwind.css b/openmetadata-ui/src/main/resources/ui/src/styles/tailwind.css index 93f42ccb905..f45b97d2d59 100644 --- a/openmetadata-ui/src/main/resources/ui/src/styles/tailwind.css +++ b/openmetadata-ui/src/main/resources/ui/src/styles/tailwind.css @@ -71,7 +71,7 @@ @apply tw-border tw-border-main tw-leading-normal; } .tableHead-cell { - @apply tw-py-3 tw-px-6 tw-text-left tw-font-normal tw-whitespace-nowrap; + @apply tw-py-3 tw-px-6 tw-font-medium tw-text-left tw-whitespace-nowrap; } .tableBody { @apply tw-text-grey-body;