yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-11-09 15:32:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix #19772: Not able to see Data diff option in table test case in DataBricks service (#19789)

Browse Source
This commit is contained in:
Shailesh Parmar 2025-02-14 16:21:34 +05:30 committed by GitHub
parent 5a5d03615a
commit 5261f9168f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 2 additions and 45 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
openmetadata-ui/src/main/resources/ui/src/components/DataQuality/AddDataQualityTest/components/ParameterForm.tsx
View File

@ -37,10 +37,7 @@ import { ReactComponent as IconDelete } from '../../../../assets/svg/ic-delete.s
import { WILD_CARD_CHAR } from '../../../../constants/char.constants'; import { WILD_CARD_CHAR } from '../../../../constants/char.constants';
import { PAGE_SIZE_LARGE } from '../../../../constants/constants'; import { PAGE_SIZE_LARGE } from '../../../../constants/constants';
import { SUPPORTED_PARTITION_TYPE_FOR_DATE_TIME } from '../../../../constants/profiler.constant'; import { SUPPORTED_PARTITION_TYPE_FOR_DATE_TIME } from '../../../../constants/profiler.constant';
import { import { TABLE_DIFF } from '../../../../constants/TestSuite.constant';
SUPPORTED_SERVICES_FOR_TABLE_DIFF,
TABLE_DIFF,
} from '../../../../constants/TestSuite.constant';
import { CSMode } from '../../../../enums/codemirror.enum'; import { CSMode } from '../../../../enums/codemirror.enum';
import { SearchIndex } from '../../../../enums/search.enum'; import { SearchIndex } from '../../../../enums/search.enum';
import { import {
@ -323,19 +320,6 @@ const ParameterForm: React.FC<ParameterFormProps> = ({ definition, table }) => {
pageNumber: 1, pageNumber: 1,
pageSize: PAGE_SIZE_LARGE, pageSize: PAGE_SIZE_LARGE,
searchIndex: SearchIndex.TABLE, searchIndex: SearchIndex.TABLE,
queryFilter: {
query: {
bool: {
must: [
{
terms: {
serviceType: SUPPORTED_SERVICES_FOR_TABLE_DIFF,
},
},
],
},
},
},
fetchSource: true, fetchSource: true,
includeFields: ['name', 'fullyQualifiedName', 'displayName'], includeFields: ['name', 'fullyQualifiedName', 'displayName'],
}); });

15
openmetadata-ui/src/main/resources/ui/src/components/DataQuality/AddDataQualityTest/components/TestCaseForm.tsx
View File

@ -30,10 +30,6 @@ import React, { useCallback, useEffect, useMemo, useState } from 'react';
import { useHistory, useParams } from 'react-router-dom'; import { useHistory, useParams } from 'react-router-dom';
import { PAGE_SIZE_LARGE } from '../../../../constants/constants'; import { PAGE_SIZE_LARGE } from '../../../../constants/constants';
import { ENTITY_NAME_REGEX } from '../../../../constants/regex.constants'; import { ENTITY_NAME_REGEX } from '../../../../constants/regex.constants';
import {
SUPPORTED_SERVICES_FOR_TABLE_DIFF,
TABLE_DIFF,
} from '../../../../constants/TestSuite.constant';
import { ProfilerDashboardType } from '../../../../enums/table.enum'; import { ProfilerDashboardType } from '../../../../enums/table.enum';
import { CreateTestCase } from '../../../../generated/api/tests/createTestCase'; import { CreateTestCase } from '../../../../generated/api/tests/createTestCase';
import { TestCase } from '../../../../generated/tests/testCase'; import { TestCase } from '../../../../generated/tests/testCase';
@ -124,17 +120,8 @@ const TestCaseForm: React.FC<TestCaseFormProps> = ({
testPlatform: TestPlatform.OpenMetadata, testPlatform: TestPlatform.OpenMetadata,
supportedDataType: columnType, supportedDataType: columnType,
}); });
const updatedData = data.filter((definition) => {
if (definition.fullyQualifiedName === TABLE_DIFF) {
return (
table.serviceType &&
SUPPORTED_SERVICES_FOR_TABLE_DIFF.includes(table.serviceType)
);
}
return true; setTestDefinitions(data);
});
setTestDefinitions(updatedData);
} catch (error) { } catch (error) {
showErrorToast(error as AxiosError); showErrorToast(error as AxiosError);
} }

14
openmetadata-ui/src/main/resources/ui/src/constants/TestSuite.constant.ts
View File

@ -13,7 +13,6 @@
import i18next from 'i18next'; import i18next from 'i18next';
import { StepperStepType } from 'Models'; import { StepperStepType } from 'Models';
import { DatabaseServiceType } from '../generated/entity/data/database';
import { TestCaseResolutionStatusTypes } from '../generated/tests/testCaseResolutionStatus'; import { TestCaseResolutionStatusTypes } from '../generated/tests/testCaseResolutionStatus';
import { DataQualityPageTabs } from '../pages/DataQuality/DataQualityPage.interface'; import { DataQualityPageTabs } from '../pages/DataQuality/DataQualityPage.interface';
@ -83,16 +82,3 @@ export const TEST_CASE_STATUS: Record<
export const TABLE_DIFF = 'tableDiff'; export const TABLE_DIFF = 'tableDiff';
export const TABLE_DATA_TO_BE_FRESH = 'tableDataToBeFresh'; export const TABLE_DATA_TO_BE_FRESH = 'tableDataToBeFresh';
export const TABLE_FRESHNESS_KEY = 'freshness'; export const TABLE_FRESHNESS_KEY = 'freshness';
export const SUPPORTED_SERVICES_FOR_TABLE_DIFF = [
DatabaseServiceType.Snowflake,
DatabaseServiceType.BigQuery,
DatabaseServiceType.Redshift,
DatabaseServiceType.Athena,
DatabaseServiceType.Postgres,
DatabaseServiceType.Mysql,
DatabaseServiceType.Mssql,
DatabaseServiceType.Oracle,
DatabaseServiceType.Trino,
DatabaseServiceType.SapHana,
];