From 54d40535cfdb6fb5f0b4e34dd9617c17ecbc660b Mon Sep 17 00:00:00 2001
From: Ashish Gupta <ashish@getcollate.io>
Date: Thu, 15 May 2025 12:53:15 +0530
Subject: [PATCH] FIX: flaky test and ui issues (#21194)

* fix bulk import table entity flaky test

* modify announcement flaky test

* fix the announcement card placement

* fix the button width and height of inline button component

(cherry picked from commit d2162f5db967fa8d9f2dab2eb0a86ba88e6cf91c)
---
 .../ui/playwright/e2e/Features/BulkImport.spec.ts         | 4 +---
 .../src/main/resources/ui/playwright/utils/entity.ts      | 2 +-
 .../DataAssetsHeader/DataAssetsHeader.component.tsx       | 8 ++++----
 .../ui/src/components/common/InlineEdit/inline-edit.less  | 6 ++++++
 4 files changed, 12 insertions(+), 8 deletions(-)

diff --git a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/BulkImport.spec.ts b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/BulkImport.spec.ts
index ebce268a221..6b2f8f173d9 100644
--- a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/BulkImport.spec.ts
+++ b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/BulkImport.spec.ts
@@ -889,12 +889,10 @@ test.describe('Bulk Import Export', () => {
         );
 
         await page.click('[type="button"] >> text="Update"', { force: true });
+        await updateButtonResponse;
         await page
           .locator('.inovua-react-toolkit-load-mask__background-layer')
           .waitFor({ state: 'detached' });
-
-        await updateButtonResponse;
-        await page.waitForEvent('framenavigated');
         await toastNotification(page, /details updated successfully/);
       }
     );
diff --git a/openmetadata-ui/src/main/resources/ui/playwright/utils/entity.ts b/openmetadata-ui/src/main/resources/ui/playwright/utils/entity.ts
index 68c1b6bb5e8..50c8fe8486d 100644
--- a/openmetadata-ui/src/main/resources/ui/playwright/utils/entity.ts
+++ b/openmetadata-ui/src/main/resources/ui/playwright/utils/entity.ts
@@ -843,7 +843,7 @@ export const createAnnouncement = async (
   await page.reload();
   await page.getByTestId('announcement-card').isVisible();
 
-  await expect(page.getByTestId('announcement-card')).toContainText(data.title);
+  await expect(page.getByTestId('announcement-title')).toHaveText(data.title);
 
   // TODO: Review redirection flow for announcement @Ashish8689
   // await redirectToHomePage(page);
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/DataAssets/DataAssetsHeader/DataAssetsHeader.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/DataAssets/DataAssetsHeader/DataAssetsHeader.component.tsx
index 51756a3a06f..ca0c390c497 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/DataAssets/DataAssetsHeader/DataAssetsHeader.component.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/DataAssets/DataAssetsHeader/DataAssetsHeader.component.tsx
@@ -709,14 +709,14 @@ export const DataAssetsHeader = ({
             />
             {extraInfo}
           </div>
-          <div className="mt-2">
-            {activeAnnouncement && (
+          {activeAnnouncement && (
+            <div className="m-t-sm d-flex justify-end">
               <AnnouncementCard
                 announcement={activeAnnouncement}
                 onClick={handleOpenAnnouncementDrawer}
               />
-            )}
-          </div>
+            </div>
+          )}
         </Col>
       </Row>
 
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/common/InlineEdit/inline-edit.less b/openmetadata-ui/src/main/resources/ui/src/components/common/InlineEdit/inline-edit.less
index 8882c5275d0..b07c68d1e81 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/common/InlineEdit/inline-edit.less
+++ b/openmetadata-ui/src/main/resources/ui/src/components/common/InlineEdit/inline-edit.less
@@ -12,4 +12,10 @@
  */
 .inline-edit-container {
   width: 100%;
+
+  .ant-btn-icon-only.ant-btn-sm {
+    width: 24px;
+    height: 24px;
+    padding: 0;
+  }
 }