From 5611ed77678958049656ba5b4fe048c96ca5a233 Mon Sep 17 00:00:00 2001 From: Shailesh Parmar Date: Fri, 10 Jun 2022 01:37:21 +0530 Subject: [PATCH] Fixed issue Unable to delete last tag from entity level tags #5280 and home page getting blank issue #5392 (#5393) * Fixed issue Unable to delete last tag from entity level tags #5280 * resolving blank page issue * miner fix Co-authored-by: Vivek Ratnavel Subramanian Co-authored-by: Sanket Shah --- openmetadata-ui/src/main/resources/ui/cypress.json | 3 ++- .../ui/src/components/tags-container/tags-container.tsx | 2 ++ .../src/main/resources/ui/src/utils/CommonUtils.tsx | 6 ++---- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/openmetadata-ui/src/main/resources/ui/cypress.json b/openmetadata-ui/src/main/resources/ui/cypress.json index 034adc41d53..d8360dae71f 100644 --- a/openmetadata-ui/src/main/resources/ui/cypress.json +++ b/openmetadata-ui/src/main/resources/ui/cypress.json @@ -5,5 +5,6 @@ "watchForFileChanges": false, "baseUrl": "http://localhost:8585", "defaultCommandTimeout": 5000, - "videoUploadOnPasses": false + "videoUploadOnPasses": false, + "chromeWebSecurity": false } diff --git a/openmetadata-ui/src/main/resources/ui/src/components/tags-container/tags-container.tsx b/openmetadata-ui/src/main/resources/ui/src/components/tags-container/tags-container.tsx index b0272e0742f..31c485f9921 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/tags-container/tags-container.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/tags-container/tags-container.tsx @@ -74,6 +74,8 @@ const TagsContainer: FunctionComponent = ({ return updatedTags; }); + } else { + setTags([]); } }; diff --git a/openmetadata-ui/src/main/resources/ui/src/utils/CommonUtils.tsx b/openmetadata-ui/src/main/resources/ui/src/utils/CommonUtils.tsx index aa0112f2edd..6e1c530c7f3 100644 --- a/openmetadata-ui/src/main/resources/ui/src/utils/CommonUtils.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/utils/CommonUtils.tsx @@ -328,15 +328,13 @@ export const getOwnerIds = ( if (filter === Ownership.OWNER) { if (!isEmpty(userDetails)) { return [ - ...(userDetails.teams?.map((team) => team.id) as Array), + ...(userDetails.teams?.map((team) => team.id) || []), userDetails.id, ]; } else { if (!isEmpty(nonSecureUserDetails)) { return [ - ...(nonSecureUserDetails.teams?.map( - (team) => team.id - ) as Array), + ...(nonSecureUserDetails.teams?.map((team) => team.id) || []), nonSecureUserDetails.id, ]; } else {