yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-09-25 17:04:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Filter patterns fixed (#4939)

Browse Source
This commit is contained in:
Ayush Shah 2022-05-13 21:37:25 +05:30 committed by GitHub
parent bf3e2ab018
commit 571b45ac52
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ingestion/src/metadata/ingestion/source/looker.py
View File

@ -96,7 +96,7 @@ class LookerSource(Source[Entity]):
yield from self._get_looker_dashboards() yield from self._get_looker_dashboards()
def _get_dashboard_elements(self, dashboard_elements): def _get_dashboard_elements(self, dashboard_elements):
if not filter_by_chart( if filter_by_chart(
chart_filter_pattern=self.source_config.chartFilterPattern, chart_filter_pattern=self.source_config.chartFilterPattern,
chart_name=dashboard_elements.id, chart_name=dashboard_elements.id,
): ):
@ -121,7 +121,7 @@ class LookerSource(Source[Entity]):
all_dashboards = self.client.all_dashboards(fields="id") all_dashboards = self.client.all_dashboards(fields="id")
for child_dashboard in all_dashboards: for child_dashboard in all_dashboards:
try: try:
if not filter_by_dashboard( if filter_by_dashboard(
dashboard_filter_pattern=self.source_config.dashboardFilterPattern, dashboard_filter_pattern=self.source_config.dashboardFilterPattern,
dashboard_name=child_dashboard.id, dashboard_name=child_dashboard.id,
): ):

8
ingestion/src/metadata/ingestion/source/powerbi.py
View File

@ -107,7 +107,7 @@ class PowerbiSource(Source[Entity]):
""" """
for chart in charts: for chart in charts:
try: try:
if not filter_by_chart( if filter_by_chart(
self.source_config.chartFilterPattern, chart["title"] self.source_config.chartFilterPattern, chart["title"]
): ):
self.status.failure( self.status.failure(
@ -130,7 +130,7 @@ class PowerbiSource(Source[Entity]):
except Exception as err: # pylint: disable=broad-except except Exception as err: # pylint: disable=broad-except
logger.debug(traceback.format_exc()) logger.debug(traceback.format_exc())
logger.error(repr(err)) logger.error(repr(err))
self.status.failure(chart["title"], err) self.status.failure(chart["title"], repr(err))
def get_dashboards(self): def get_dashboards(self):
"""Get dashboard method""" """Get dashboard method"""
@ -140,7 +140,7 @@ class PowerbiSource(Source[Entity]):
try: try:
dashboard_details = dashboard_service.get_dashboard(dashboard_id["id"]) dashboard_details = dashboard_service.get_dashboard(dashboard_id["id"])
self.charts = [] self.charts = []
if not filter_by_dashboard( if filter_by_dashboard(
self.source_config.dashboardFilterPattern, self.source_config.dashboardFilterPattern,
dashboard_details["displayName"], dashboard_details["displayName"],
): ):
@ -167,7 +167,7 @@ class PowerbiSource(Source[Entity]):
except Exception as err: except Exception as err:
logger.debug(traceback.format_exc()) logger.debug(traceback.format_exc())
logger.error(err) logger.error(err)
self.status.failure(dashboard_details["displayName"], err) self.status.failure(dashboard_details["displayName"], repr(err))
def get_status(self) -> SourceStatus: def get_status(self) -> SourceStatus:
return self.status return self.status