yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-12-16 18:15:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make generated fields required in filters and destination (#10356)

Browse Source
This commit is contained in:
Ashish Gupta 2023-02-28 15:31:23 +05:30 committed by GitHub
parent c1c185321c
commit 5865466094
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 27 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
openmetadata-ui/src/main/resources/ui/src/locale/languages/en-us.json
View File

@ -545,6 +545,7 @@
"please-enter-value": "Please enter {{name}} value", "please-enter-value": "Please enter {{name}} value",
"please-password-type-first": "Please type password first", "please-password-type-first": "Please type password first",
"please-select": "Please Select", "please-select": "Please Select",
"please-select-entity": "Please Select a {{entity}}",
"plus-symbol": "+", "plus-symbol": "+",
"policy": "Policy", "policy": "Policy",
"policy-lowercase": "policy", "policy-lowercase": "policy",

29
openmetadata-ui/src/main/resources/ui/src/pages/AddAlertPage/AddAlertPage.tsx
View File

@ -640,7 +640,20 @@ const AddAlertPage = () => {
)} )}
<div className="d-flex gap-1"> <div className="d-flex gap-1">
<div className="flex-1"> <div className="flex-1">
<Form.Item key={key} name={[name, 'name']}> <Form.Item
key={key}
name={[name, 'name']}
rules={[
{
required: true,
message: t(
'label.please-select-entity',
{
entity: t('label.condition'),
}
),
},
]}>
<Select <Select
options={functions} options={functions}
placeholder={t('label.select-field', { placeholder={t('label.select-field', {
@ -734,9 +747,19 @@ const AddAlertPage = () => {
<div className="d-flex" style={{ gap: '10px' }}> <div className="d-flex" style={{ gap: '10px' }}>
<div className="flex-1"> <div className="flex-1">
<Form.Item <Form.Item
required
key={key} key={key}
name={[name, 'alertActionType']}> name={[name, 'alertActionType']}
rules={[
{
required: true,
message: t(
'label.please-select-entity',
{
entity: t('label.source'),
}
),
},
]}>
<Select <Select
data-testid="alert-action-type" data-testid="alert-action-type"
disabled={ disabled={