MINOR: Fix Couchbase columns not fetched (#18284)

This commit is contained in:
Mayur Singal 2024-10-16 09:53:57 +05:30 committed by GitHub
parent 40bd3bd3fa
commit 592d7396bc
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 9 additions and 20 deletions

View File

@ -27,10 +27,7 @@ from metadata.ingestion.source.database.common_nosql_source import (
SAMPLE_SIZE, SAMPLE_SIZE,
CommonNoSQLSource, CommonNoSQLSource,
) )
from metadata.ingestion.source.database.couchbase.queries import ( from metadata.ingestion.source.database.couchbase.queries import COUCHBASE_GET_DATA
COUCHBASE_GET_DATA,
COUCHBASE_SQL_STATEMENT,
)
from metadata.utils.logger import ingestion_logger from metadata.utils.logger import ingestion_logger
logger = ingestion_logger() logger = ingestion_logger()
@ -111,18 +108,14 @@ class CouchbaseSource(CommonNoSQLSource):
""" """
try: try:
database_name = self.context.get().database database_name = self.context.get().database
query = COUCHBASE_SQL_STATEMENT.format(table_name=table_name) query_coln = COUCHBASE_GET_DATA.format(
result = self.couchbase.query(query) database_name=database_name,
for row in result.rows(): schema_name=schema_name,
if len(row) > 0: table_name=table_name,
query_coln = COUCHBASE_GET_DATA.format( sample_size=SAMPLE_SIZE,
database_name=database_name, )
schema_name=schema_name, query_iter = self.couchbase.query(query_coln)
table_name=table_name, return list(query_iter.rows())
sample_size=SAMPLE_SIZE,
)
query_iter = self.couchbase.query(query_coln)
return list(query_iter.rows())
except Exception as exp: except Exception as exp:
logger.debug(f"Failed to list column names for table [{table_name}]: {exp}") logger.debug(f"Failed to list column names for table [{table_name}]: {exp}")
logger.debug(traceback.format_exc()) logger.debug(traceback.format_exc())

View File

@ -14,10 +14,6 @@ SQL Queries used during ingestion
import textwrap import textwrap
COUCHBASE_SQL_STATEMENT = textwrap.dedent(
""" SELECT * FROM system:indexes WHERE keyspace_id = '{table_name}' AND is_primary = TRUE """
)
COUCHBASE_GET_DATA = textwrap.dedent( COUCHBASE_GET_DATA = textwrap.dedent(
""" select crc.* from `{database_name}`.`{schema_name}`.`{table_name}` crc limit {sample_size} """ """ select crc.* from `{database_name}`.`{schema_name}`.`{table_name}` crc limit {sample_size} """
) )