yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-12-04 19:44:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixes #13556: Support for Salesforce table description ingestion (#14733)

Browse Source 
* ISSUE-13556: Add suport for Salesforce table description ingestion

* ISSUE-13556: Remove unnecessary blank line

* ISSUE-13556: Fix to get description for each table

---------

Co-authored-by: Teddy <teddy.crepineau@gmail.com>
This commit is contained in:
kwgdaig 2024-01-23 16:36:36 +09:00 committed by GitHub
parent 45efaefc46
commit 5d5c384dec
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 26 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
ingestion/src/metadata/ingestion/source/database/salesforce/metadata.py
View File

@ -151,6 +151,7 @@ class SalesforceSource(DatabaseServiceSource):
:return: tables or views, depending on config
"""
schema_name = self.context.database_schema
try:
if self.service_connection.sobjectName:
table_name = self.standardize_table_name(
@ -191,6 +192,30 @@ class SalesforceSource(DatabaseServiceSource):
)
)
def get_table_description(self, table_name: str) -> Optional[str]:
"""
Method to get the table description for salesforce with Tooling API
"""
try:
result = self.client.toolingexecute(
f"query/?q=SELECT+Description+FROM+EntityDefinition+WHERE+QualifiedApiName='{table_name}'"
)
return result["records"][0]["Description"]
except KeyError as err:
logger.warning(
f"Unable to get required key from Tooling API response for table [{table_name}]: {err}"
)
except IndexError as err:
logger.warning(
f"Unable to get row for table [{table_name}] from EntityDefinition: {err}"
)
except Exception as exc:
logger.debug(traceback.format_exc())
logger.warning(
f"Unable to get description with Tooling API for table [{table_name}]: {exc}"
)
return None
def yield_table(
self, table_name_and_type: Tuple[str, str]
) -> Iterable[Either[CreateTableRequest]]:
@ -209,6 +234,7 @@ class SalesforceSource(DatabaseServiceSource):
table_request = CreateTableRequest(
name=table_name,
tableType=table_type,
description=self.get_table_description(table_name),
columns=columns,
tableConstraints=table_constraints,
databaseSchema=fqn.build(