From 5e7e518f305b0291eddb4fc8cca4505b511e82cf Mon Sep 17 00:00:00 2001 From: Shailesh Parmar Date: Mon, 18 Aug 2025 14:41:01 +0530 Subject: [PATCH] Upgrade playwright version to 1.51.1 (#22884) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Upgrade playwright version to 1.54.2 (latest) to support indexedDb storageState (#22879) * bump playwright version to latest * update playwright version in workflow files * update playwright installation step in workflow files to ensure consistent working directory --------- Co-authored-by: “maulikkotak98” <“maulik.k@deuexsolutions.com”> * update playwright version to 1.51.1 * fix tests for lineage * minor refactor and cleanup * fix lineage tests --------- Co-authored-by: Maulik Kotak <72746599+maulikkotak98@users.noreply.github.com> Co-authored-by: “maulikkotak98” <“maulik.k@deuexsolutions.com”> Co-authored-by: Aniket Katkar (cherry picked from commit bb9b395243fe166c37d6c7083a1fe01f9223c4b4) --- .github/workflows/mysql-nightly-e2e.yml | 2 +- .github/workflows/playwright-mysql-e2e.yml | 19 ++++++------- .../workflows/playwright-postgresql-e2e.yml | 16 +++++------ .github/workflows/postgresql-nightly-e2e.yml | 2 +- .../src/main/resources/ui/package.json | 2 +- .../resources/ui/playwright/utils/lineage.ts | 4 +-- .../src/main/resources/ui/yarn.lock | 28 +++++++++---------- 7 files changed, 35 insertions(+), 38 deletions(-) diff --git a/.github/workflows/mysql-nightly-e2e.yml b/.github/workflows/mysql-nightly-e2e.yml index 69d80642e44..5ddcf8daf61 100644 --- a/.github/workflows/mysql-nightly-e2e.yml +++ b/.github/workflows/mysql-nightly-e2e.yml @@ -75,7 +75,7 @@ jobs: working-directory: openmetadata-ui/src/main/resources/ui/ run: yarn --ignore-scripts --frozen-lockfile - name: Install Playwright Browsers - run: npx playwright@1.48.2 install --with-deps + run: npx playwright@1.51.1 install --with-deps - name: Run Playwright tests working-directory: openmetadata-ui/src/main/resources/ui/ run: | diff --git a/.github/workflows/playwright-mysql-e2e.yml b/.github/workflows/playwright-mysql-e2e.yml index 087a1f9efdb..16b63ff1986 100644 --- a/.github/workflows/playwright-mysql-e2e.yml +++ b/.github/workflows/playwright-mysql-e2e.yml @@ -23,14 +23,13 @@ on: - reopened - ready_for_review paths-ignore: - - 'openmetadata-docs/**' - - '.github/**' - - 'openmetadata-dist/**' - - 'docker/**' - - '!docker/development/docker-compose.yml' - - '!docker/development/docker-compose-postgres.yml' + - "openmetadata-docs/**" + - ".github/**" + - "openmetadata-dist/**" + - "docker/**" + - "!docker/development/docker-compose.yml" + - "!docker/development/docker-compose-postgres.yml" - permissions: contents: read @@ -94,7 +93,7 @@ jobs: - name: Setup Openmetadata Test Environment uses: ./.github/actions/setup-openmetadata-test-environment with: - python-version: '3.9' + python-version: "3.9" args: "-d mysql" ingestion_dependency: "playwright" @@ -102,7 +101,7 @@ jobs: working-directory: openmetadata-ui/src/main/resources/ui/ run: yarn --ignore-scripts --frozen-lockfile - name: Install Playwright Browsers - run: npx playwright@1.48.2 install --with-deps + run: npx playwright@1.51.1 install --with-deps - name: Run Playwright tests working-directory: openmetadata-ui/src/main/resources/ui/ run: | @@ -175,5 +174,3 @@ jobs: cd ./docker/development docker compose down --remove-orphans sudo rm -rf ${PWD}/docker-volume - - diff --git a/.github/workflows/playwright-postgresql-e2e.yml b/.github/workflows/playwright-postgresql-e2e.yml index 9f2972159db..46842d957b5 100644 --- a/.github/workflows/playwright-postgresql-e2e.yml +++ b/.github/workflows/playwright-postgresql-e2e.yml @@ -23,12 +23,12 @@ on: - reopened - ready_for_review paths-ignore: - - 'openmetadata-docs/**' - - '.github/**' - - 'openmetadata-dist/**' - - 'docker/**' - - '!docker/development/docker-compose.yml' - - '!docker/development/docker-compose-postgres.yml' + - "openmetadata-docs/**" + - ".github/**" + - "openmetadata-dist/**" + - "docker/**" + - "!docker/development/docker-compose.yml" + - "!docker/development/docker-compose-postgres.yml" permissions: contents: read @@ -93,7 +93,7 @@ jobs: - name: Setup Openmetadata Test Environment uses: ./.github/actions/setup-openmetadata-test-environment with: - python-version: '3.9' + python-version: "3.9" args: "-d postgresql" ingestion_dependency: "playwright" @@ -101,7 +101,7 @@ jobs: working-directory: openmetadata-ui/src/main/resources/ui/ run: yarn --ignore-scripts --frozen-lockfile - name: Install Playwright Browsers - run: npx playwright@1.48.2 install --with-deps + run: npx playwright@1.51.1 install --with-deps - name: Run Playwright tests working-directory: openmetadata-ui/src/main/resources/ui/ run: | diff --git a/.github/workflows/postgresql-nightly-e2e.yml b/.github/workflows/postgresql-nightly-e2e.yml index 13e72efe4a7..451c2800c97 100644 --- a/.github/workflows/postgresql-nightly-e2e.yml +++ b/.github/workflows/postgresql-nightly-e2e.yml @@ -75,7 +75,7 @@ jobs: working-directory: openmetadata-ui/src/main/resources/ui/ run: yarn --ignore-scripts --frozen-lockfile - name: Install Playwright Browsers - run: npx playwright@1.48.2 install --with-deps + run: npx playwright@1.51.1 install --with-deps - name: Run Playwright tests working-directory: openmetadata-ui/src/main/resources/ui/ run: | diff --git a/openmetadata-ui/src/main/resources/ui/package.json b/openmetadata-ui/src/main/resources/ui/package.json index 47fd8a27ee0..e5d70101333 100644 --- a/openmetadata-ui/src/main/resources/ui/package.json +++ b/openmetadata-ui/src/main/resources/ui/package.json @@ -152,7 +152,7 @@ "@babel/preset-env": "^7.11.0", "@babel/preset-react": "^7.10.4", "@estruyf/github-actions-reporter": "^1.7.0", - "@playwright/test": "1.48.2", + "@playwright/test": "1.51.1", "@svgr/webpack": "^6.5.0", "@testing-library/jest-dom": "^5.11.10", "@testing-library/react": "^14.2.1", diff --git a/openmetadata-ui/src/main/resources/ui/playwright/utils/lineage.ts b/openmetadata-ui/src/main/resources/ui/playwright/utils/lineage.ts index 0d7785211e1..63c973ee0d9 100644 --- a/openmetadata-ui/src/main/resources/ui/playwright/utils/lineage.ts +++ b/openmetadata-ui/src/main/resources/ui/playwright/utils/lineage.ts @@ -123,7 +123,7 @@ export const deleteEdge = async ( await page.locator('[data-testid="add-pipeline"]').dispatchEvent('click'); - await expect(page.locator('[role="dialog"]')).toBeVisible(); + await expect(page.locator('[role="dialog"]').first()).toBeVisible(); await page .locator( @@ -131,7 +131,7 @@ export const deleteEdge = async ( ) .dispatchEvent('click'); - await expect(page.locator('[role="dialog"]')).toBeVisible(); + await expect(page.locator('[role="dialog"]').first()).toBeVisible(); const deleteRes = page.waitForResponse('/api/v1/lineage/**'); await page diff --git a/openmetadata-ui/src/main/resources/ui/yarn.lock b/openmetadata-ui/src/main/resources/ui/yarn.lock index d9a8aa0f479..b9729a4adfb 100644 --- a/openmetadata-ui/src/main/resources/ui/yarn.lock +++ b/openmetadata-ui/src/main/resources/ui/yarn.lock @@ -2970,12 +2970,12 @@ tslib "^2.5.0" webcrypto-core "^1.7.7" -"@playwright/test@1.48.2": - version "1.48.2" - resolved "https://registry.npmjs.org/@playwright/test/-/test-1.48.2.tgz" - integrity sha512-54w1xCWfXuax7dz4W2M9uw0gDyh+ti/0K/MxcCUxChFh37kkdxPdfZDw5QBbuPUJHr1CiHJ1hXgSs+GgeQc5Zw== +"@playwright/test@1.51.1": + version "1.51.1" + resolved "https://registry.yarnpkg.com/@playwright/test/-/test-1.51.1.tgz#75357d513221a7be0baad75f01e966baf9c41a2e" + integrity sha512-nM+kEaTSAoVlXmMPH10017vn3FSiFqr/bh4fKg9vmAdMfd9SDqRZNvPSiAHADc/itWak+qPvMPZQOPwCBW7k7Q== dependencies: - playwright "1.48.2" + playwright "1.51.1" "@polka/url@^1.0.0-next.24": version "1.0.0-next.28" @@ -11435,17 +11435,17 @@ pkg-dir@^4.1.0, pkg-dir@^4.2.0: dependencies: find-up "^4.0.0" -playwright-core@1.48.2: - version "1.48.2" - resolved "https://registry.npmjs.org/playwright-core/-/playwright-core-1.48.2.tgz" - integrity sha512-sjjw+qrLFlriJo64du+EK0kJgZzoQPsabGF4lBvsid+3CNIZIYLgnMj9V6JY5VhM2Peh20DJWIVpVljLLnlawA== +playwright-core@1.51.1: + version "1.51.1" + resolved "https://registry.yarnpkg.com/playwright-core/-/playwright-core-1.51.1.tgz#d57f0393e02416f32a47cf82b27533656a8acce1" + integrity sha512-/crRMj8+j/Nq5s8QcvegseuyeZPxpQCZb6HNk3Sos3BlZyAknRjoyJPFWkpNn8v0+P3WiwqFF8P+zQo4eqiNuw== -playwright@1.48.2: - version "1.48.2" - resolved "https://registry.npmjs.org/playwright/-/playwright-1.48.2.tgz" - integrity sha512-NjYvYgp4BPmiwfe31j4gHLa3J7bD2WiBz8Lk2RoSsmX38SVIARZ18VYjxLjAcDsAhA+F4iSEXTSGgjua0rrlgQ== +playwright@1.51.1: + version "1.51.1" + resolved "https://registry.yarnpkg.com/playwright/-/playwright-1.51.1.tgz#ae1467ee318083968ad28d6990db59f47a55390f" + integrity sha512-kkx+MB2KQRkyxjYPc3a0wLZZoDczmppyGJIvQ43l+aZihkaVvmu/21kiyaHeHjiFxjxNNFnUncKmcGIyOojsaw== dependencies: - playwright-core "1.48.2" + playwright-core "1.51.1" optionalDependencies: fsevents "2.3.2"