From 61bc8568f88e6adee01b3c7cb34bcd05a47fed82 Mon Sep 17 00:00:00 2001
From: Ashish Gupta <ashish@getcollate.io>
Date: Sat, 6 Apr 2024 19:30:09 +0530
Subject: [PATCH] chore: minor ui issue (#15819)

* chore: minor ui issue

* remove password field from schema form
---
 .../main/resources/ui/src/assets/svg/doc.svg  |  6 ++---
 .../ui/src/assets/svg/version-black.svg       | 26 ++++++++++++++-----
 .../DataAssetsHeader.component.tsx            |  6 ++++-
 .../DataAssetsHeader/data-asset-header.less   | 21 +++++++++++++++
 .../JsonSchemaWidgets/PasswordWidget.tsx      |  2 +-
 5 files changed, 49 insertions(+), 12 deletions(-)
 create mode 100644 openmetadata-ui/src/main/resources/ui/src/components/DataAssets/DataAssetsHeader/data-asset-header.less

diff --git a/openmetadata-ui/src/main/resources/ui/src/assets/svg/doc.svg b/openmetadata-ui/src/main/resources/ui/src/assets/svg/doc.svg
index b38210fdf45..7d84b2ca5aa 100644
--- a/openmetadata-ui/src/main/resources/ui/src/assets/svg/doc.svg
+++ b/openmetadata-ui/src/main/resources/ui/src/assets/svg/doc.svg
@@ -1,6 +1,6 @@
 
 <svg viewBox="0 0 40 40" fill="none" xmlns="http://www.w3.org/2000/svg">
-<path d="M10.1562 31.7188C9.63846 31.7188 9.21875 31.299 9.21875 30.7812V8.86719C9.21875 6.73479 10.9535 5 13.0859 5H29.8438C30.3615 5 30.7812 5.41977 30.7812 5.9375V27.5C30.7812 28.0177 30.3615 28.4375 29.8438 28.4375C29.326 28.4375 28.9062 28.0177 28.9062 27.5V6.875H13.0859C11.9874 6.875 11.0938 7.76867 11.0938 8.86719V30.7812C11.0938 31.299 10.674 31.7188 10.1562 31.7188Z" fill="currentColor"/>
-<path d="M29.8438 35H13.4375C11.1113 35 9.21875 33.1075 9.21875 30.7812C9.21875 28.455 11.1113 26.5625 13.4375 26.5625H29.8438C30.3615 26.5625 30.7812 26.9823 30.7812 27.5C30.7812 28.0177 30.3615 28.4375 29.8438 28.4375H13.4375C12.1452 28.4375 11.0938 29.4889 11.0938 30.7812C11.0938 32.0736 12.1452 33.125 13.4375 33.125H29.8438C30.3615 33.125 30.7812 33.5448 30.7812 34.0625C30.7812 34.5802 30.3615 35 29.8438 35Z" fill="currentColor"/>
-<path d="M29.8438 31.7188H13.4375C12.9197 31.7188 12.5 31.299 12.5 30.7812C12.5 30.2635 12.9197 29.8438 13.4375 29.8438H29.8438C30.3615 29.8438 30.7812 30.2635 30.7812 30.7812C30.7812 31.299 30.3615 31.7188 29.8438 31.7188ZM14.375 28.4375C13.8572 28.4375 13.4375 28.0177 13.4375 27.5V5.9375C13.4375 5.41977 13.8572 5 14.375 5C14.8928 5 15.3125 5.41977 15.3125 5.9375V27.5C15.3125 28.0177 14.8928 28.4375 14.375 28.4375Z" fill="currentColor"/>
+<path d="M8.9375 31.7188C8.41971 31.7188 8 31.299 8 30.7812V8.86719C8 6.73479 9.73479 5 11.8672 5H31.625C32.1428 5 32.5625 5.41977 32.5625 5.9375V27.5C32.5625 28.0177 32.1428 28.4375 31.625 28.4375C31.1072 28.4375 30.6875 28.0177 30.6875 27.5V6.875H11.8672C10.7687 6.875 9.875 7.76867 9.875 8.86719V30.7812C9.875 31.299 9.45529 31.7188 8.9375 31.7188Z" fill="currentColor"/>
+<path d="M31.625 35H12.2188C9.89252 35 8 33.1075 8 30.7812C8 28.455 9.89252 26.5625 12.2188 26.5625H31.625C32.1428 26.5625 32.5625 26.9823 32.5625 27.5C32.5625 28.0177 32.1428 28.4375 31.625 28.4375H12.2188C10.9264 28.4375 9.875 29.4889 9.875 30.7812C9.875 32.0736 10.9264 33.125 12.2188 33.125H31.625C32.1428 33.125 32.5625 33.5448 32.5625 34.0625C32.5625 34.5802 32.1428 35 31.625 35Z" fill="currentColor"/>
+<path d="M31.625 31.7188H12.2188C11.701 31.7188 11.2812 31.299 11.2812 30.7812C11.2812 30.2635 11.701 29.8438 12.2188 29.8438H31.625C32.1428 29.8438 32.5625 30.2635 32.5625 30.7812C32.5625 31.299 32.1428 31.7188 31.625 31.7188ZM13.1562 28.4375C12.6385 28.4375 12.2188 28.0177 12.2188 27.5V5.9375C12.2188 5.41977 12.6385 5 13.1562 5C13.674 5 14.0938 5.41977 14.0938 5.9375V27.5C14.0938 28.0177 13.674 28.4375 13.1562 28.4375Z" fill="currentColor"/>
 </svg>
diff --git a/openmetadata-ui/src/main/resources/ui/src/assets/svg/version-black.svg b/openmetadata-ui/src/main/resources/ui/src/assets/svg/version-black.svg
index 02eaada93cf..6ed5510c5a2 100644
--- a/openmetadata-ui/src/main/resources/ui/src/assets/svg/version-black.svg
+++ b/openmetadata-ui/src/main/resources/ui/src/assets/svg/version-black.svg
@@ -1,11 +1,23 @@
 <svg viewBox="0 0 40 40" fill="none" xmlns="http://www.w3.org/2000/svg">
-<mask id="mask0_1621_79066" style="mask-type:luminance" maskUnits="userSpaceOnUse" x="6" y="6" width="29" height="29">
-<path d="M6 6H34.2353V34.2353H6V6Z" fill="white"/>
+<mask id="mask0_3375_127709" style="mask-type:luminance" maskUnits="userSpaceOnUse" x="5" y="5" width="30" height="30">
+<path d="M5 5H35V35H5V5Z" fill="white"/>
 </mask>
-<g mask="url(#mask0_1621_79066)">
-<path d="M14.647 12.2941V28.1765M14.647 24.6471C17.2782 19.8347 26.0506 22.24 25.1735 15.8235" fill="#ffffff" stroke="currentColor" stroke-width="2"/>
-<path d="M14.6471 12.2941C16.109 12.2941 17.2941 11.109 17.2941 9.64706C17.2941 8.18513 16.109 7 14.6471 7C13.1851 7 12 8.18513 12 9.64706C12 11.109 13.1851 12.2941 14.6471 12.2941Z" fill="#ffffff" stroke="currentColor" stroke-width="2"/>
-<path d="M14.6471 33.2941C16.109 33.2941 17.2941 32.109 17.2941 30.6471C17.2941 29.1851 16.109 28 14.6471 28C13.1851 28 12 29.1851 12 30.6471C12 32.109 13.1851 33.2941 14.6471 33.2941Z" fill="#ffffff" stroke="currentColor" stroke-width="2"/>
-<path d="M25.2353 15.8235C26.6972 15.8235 27.8824 14.6384 27.8824 13.1765C27.8824 11.7145 26.6972 10.5294 25.2353 10.5294C23.7734 10.5294 22.5883 11.7145 22.5883 13.1765C22.5883 14.6384 23.7734 15.8235 25.2353 15.8235Z" fill="#ffffff" stroke="currentColor" stroke-width="2"/>
+<g mask="url(#mask0_3375_127709)">
+<path fill-rule="evenodd" clip-rule="evenodd" d="M11.8125 28.5V11.625H13.8125V20.819C14.2402 20.3888 14.7123 20.0537 15.2263 19.7986C16.5788 19.1274 18.0995 19.0907 19.3868 19.0597C19.4505 19.0581 19.5137 19.0566 19.5762 19.055C20.9895 19.0192 22.1763 18.9581 23.229 18.4194C24.2274 17.9084 25.2435 16.8854 26.0581 14.6015L27.9419 15.2735C27.0065 17.8958 25.7101 19.3963 24.1402 20.1998C22.6244 20.9755 20.9871 21.0199 19.6269 21.0544C18.1792 21.0911 17.0612 21.1207 16.1154 21.5901C15.2731 22.0081 14.4286 22.8605 13.8125 24.8951V28.5H11.8125Z" fill="currentColor"/>
+<path fill-rule="evenodd" clip-rule="evenodd" d="M12.8125 7C11.8115 7 11 7.81148 11 8.8125C11 9.81352 11.8115 10.625 12.8125 10.625C13.8135 10.625 14.625 9.81352 14.625 8.8125C14.625 7.81148 13.8135 7 12.8125 7ZM9 8.8125C9 6.70691 10.7069 5 12.8125 5C14.9181 5 16.625 6.70691 16.625 8.8125C16.625 10.9181 14.9181 12.625 12.8125 12.625C10.7069 12.625 9 10.9181 9 8.8125Z" fill="currentColor"/>
+<path fill-rule="evenodd" clip-rule="evenodd" d="M12.8125 29.3125C11.8115 29.3125 11 30.124 11 31.125C11 32.126 11.8115 32.9375 12.8125 32.9375C13.8135 32.9375 14.625 32.126 14.625 31.125C14.625 30.124 13.8135 29.3125 12.8125 29.3125ZM9 31.125C9 29.0194 10.7069 27.3125 12.8125 27.3125C14.9181 27.3125 16.625 29.0194 16.625 31.125C16.625 33.2306 14.9181 34.9375 12.8125 34.9375C10.7069 34.9375 9 33.2306 9 31.125Z" fill="currentColor"/>
+<path fill-rule="evenodd" clip-rule="evenodd" d="M26.8125 10.75C25.8115 10.75 25 11.5615 25 12.5625C25 13.5635 25.8115 14.375 26.8125 14.375C27.8135 14.375 28.625 13.5635 28.625 12.5625C28.625 11.5615 27.8135 10.75 26.8125 10.75ZM23 12.5625C23 10.4569 24.7069 8.75 26.8125 8.75C28.9181 8.75 30.625 10.4569 30.625 12.5625C30.625 14.6681 28.9181 16.375 26.8125 16.375C24.7069 16.375 23 14.6681 23 12.5625Z" fill="currentColor"/>
 </g>
 </svg>
+
+
+
+
+
+
+
+
+
+
+
+
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/DataAssets/DataAssetsHeader/DataAssetsHeader.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/DataAssets/DataAssetsHeader/DataAssetsHeader.component.tsx
index 18ec882047d..97c943849c9 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/DataAssets/DataAssetsHeader/DataAssetsHeader.component.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/DataAssets/DataAssetsHeader/DataAssetsHeader.component.tsx
@@ -63,6 +63,7 @@ import TitleBreadcrumb from '../../common/TitleBreadcrumb/TitleBreadcrumb.compon
 import RetentionPeriod from '../../Database/RetentionPeriod/RetentionPeriod.component';
 import Voting from '../../Entity/Voting/Voting.component';
 import { VotingDataProps } from '../../Entity/Voting/voting.interface';
+import './data-asset-header.less';
 import {
   DataAssetHeaderInfo,
   DataAssetsHeaderProps,
@@ -425,7 +426,10 @@ export const DataAssetsHeader = ({
         <Col span={7}>
           <Space className="items-end w-full" direction="vertical" size={16}>
             <Space>
-              <ButtonGroup data-testid="asset-header-btn-group" size="small">
+              <ButtonGroup
+                className="data-asset-button-group"
+                data-testid="asset-header-btn-group"
+                size="small">
                 {onUpdateVote && (
                   <Voting
                     disabled={deleted}
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/DataAssets/DataAssetsHeader/data-asset-header.less b/openmetadata-ui/src/main/resources/ui/src/components/DataAssets/DataAssetsHeader/data-asset-header.less
new file mode 100644
index 00000000000..c9240892b23
--- /dev/null
+++ b/openmetadata-ui/src/main/resources/ui/src/components/DataAssets/DataAssetsHeader/data-asset-header.less
@@ -0,0 +1,21 @@
+/*
+ *  Copyright 2024 Collate.
+ *  Licensed under the Apache License, Version 2.0 (the "License");
+ *  you may not use this file except in compliance with the License.
+ *  You may obtain a copy of the License at
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+
+.data-asset-button-group {
+  button {
+    :last-child {
+      border-top-right-radius: 4px;
+      border-bottom-right-radius: 4px;
+    }
+  }
+}
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/common/Form/JSONSchema/JsonSchemaWidgets/PasswordWidget.tsx b/openmetadata-ui/src/main/resources/ui/src/components/common/Form/JSONSchema/JsonSchemaWidgets/PasswordWidget.tsx
index 594bab9da47..cd5f67a4080 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/common/Form/JSONSchema/JsonSchemaWidgets/PasswordWidget.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/common/Form/JSONSchema/JsonSchemaWidgets/PasswordWidget.tsx
@@ -21,7 +21,7 @@ const PasswordWidget: FC<WidgetProps> = ({
   ...rest
 }) => {
   return (
-    <Input.Password
+    <Input
       autoComplete="off"
       autoFocus={rest.autofocus}
       disabled={rest.disabled}