yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-10-27 00:31:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix: Improved test suite logging (#20635)

Browse Source 
* Fix: Improved test suite logging

* linting
This commit is contained in:
Suman Maharana 2025-04-04 16:51:21 +05:30 committed by GitHub
parent ed77fe1afa
commit 61e500253f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 23 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
ingestion/src/metadata/data_quality/source/test_suite.py
View File

@ -96,13 +96,24 @@ class TestSuiteSource(Source):
"""
# Logical test suites don't have associated tables
if self.source_config.entityFullyQualifiedName is None:
logger.debug("No entity FQN provided, skipping table entity retrieval")
return None
logger.info(
f"Retrieving table entity for FQN: {self.source_config.entityFullyQualifiedName.root}"
)
table: Table = self.metadata.get_by_name(
entity=Table,
fqn=self.source_config.entityFullyQualifiedName.root,
fields=["tableProfilerConfig", "testSuite", "serviceType"],
)
if not table:
logger.warning(
f"Table not found for FQN: {self.source_config.entityFullyQualifiedName.root}. "
"Please double check the entityFullyQualifiedName"
"by copying it directly from the entity URL in the OpenMetadata UI. "
"The FQN should be in the format: service_name.database_name.schema_name.table_name"
)
return table
def _get_table_service_connection(self, table: Table) -> DatabaseConnection:
@ -196,6 +207,9 @@ class TestSuiteSource(Source):
# If there is no executable test suite yet for the table, we'll need to create one
# Then, the suite won't have yet any tests
if not table.testSuite or table.testSuite.id.root is None:
logger.info(
f"Creating new test suite for table {table.name.root} as no executable test suite exists"
)
executable_test_suite = CreateTestSuiteRequest(
name=fqn.build(
None,
@ -218,6 +232,7 @@ class TestSuiteSource(Source):
# Otherwise, we pick the tests already registered in the suite
else:
logger.info(f"Using existing test suite for table {table.name.root}")
test_suite: Optional[TestSuite] = self.metadata.get_by_id(
entity=TestSuite, entity_id=table.testSuite.id.root
)
@ -242,6 +257,9 @@ class TestSuiteSource(Source):
def _process_logical_suite(self):
"""Process logical test suite, collect all test cases and yield them in batches by table"""
logger.info(
f"Processing logical test suite for service name: {self.config.source.serviceName}"
)
test_suite = self.metadata.get_by_name(
entity=TestSuite, fqn=self.config.source.serviceName
)
@ -252,6 +270,10 @@ class TestSuiteSource(Source):
error=f"Test Suite with name {self.config.source.serviceName} not found",
)
)
# Return early if test suite not found in TestSuiteSource
return
logger.info(f"Found test suite: {test_suite.name.root}")
test_cases: List[TestCase] = self._get_test_cases_from_test_suite(test_suite)
grouped_by_table = itertools.groupby(
test_cases, key=lambda t: entity_link.get_table_fqn(t.entityLink.root)