Refactor publishers to use Notification Templates engine (#24145)

openmetadata-service/src/main/java/org/openmetadata/service/apps/bundles/changeEvent/email/EmailPublisher.java

@@ -30,16 +30,16 @@ import org.openmetadata.service.Entity;
 import org.openmetadata.service.apps.bundles.changeEvent.Destination;
 import org.openmetadata.service.events.errors.EventPublisherException;
 import org.openmetadata.service.exception.CatalogExceptionMessage;
-import org.openmetadata.service.formatter.decorators.EmailMessageDecorator;
-import org.openmetadata.service.formatter.decorators.MessageDecorator;
-import org.openmetadata.service.jdbi3.CollectionDAO;
+import org.openmetadata.service.jdbi3.NotificationTemplateRepository;
+import org.openmetadata.service.notifications.HandlebarsNotificationMessageEngine;
+import org.openmetadata.service.notifications.channels.NotificationMessage;
+import org.openmetadata.service.notifications.channels.email.EmailMessage;
 import org.openmetadata.service.util.email.EmailUtil;
 
 @Slf4j
 public class EmailPublisher implements Destination<ChangeEvent> {
-  private final MessageDecorator<EmailMessage> emailDecorator = new EmailMessageDecorator();
+  private final HandlebarsNotificationMessageEngine messageEngine;
   private final EmailAlertConfig emailAlertConfig;
-  private final CollectionDAO daoCollection;
 
   @Getter private final SubscriptionDestination subscriptionDestination;
   private final EventSubscription eventSubscription;
@@ -51,7 +51,10 @@ public class EmailPublisher implements Destination<ChangeEvent> {
       this.subscriptionDestination = subscriptionDestination;
       this.emailAlertConfig =
           JsonUtils.convertValue(subscriptionDestination.getConfig(), EmailAlertConfig.class);
-      this.daoCollection = Entity.getCollectionDAO();
+      this.messageEngine =
+          new HandlebarsNotificationMessageEngine(
+              (NotificationTemplateRepository)
+                  Entity.getEntityRepository(Entity.NOTIFICATION_TEMPLATE));
     } else {
       throw new IllegalArgumentException("Email Alert Invoked with Illegal Type and Settings.");
     }
@@ -60,12 +63,20 @@ public class EmailPublisher implements Destination<ChangeEvent> {
   @Override
   public void sendMessage(ChangeEvent event) throws EventPublisherException {
     try {
+      // Generate message using new Handlebars pipeline
+      NotificationMessage message =
+          messageEngine.generateMessage(event, eventSubscription, subscriptionDestination);
+      EmailMessage emailMessage = (EmailMessage) message;
+
+      // Get receivers
       Set<String> receivers = getTargetsForAlert(emailAlertConfig, subscriptionDestination, event);
-      EmailMessage emailMessage =
-          emailDecorator.buildOutgoingMessage(getDisplayNameOrFqn(eventSubscription), event);
-      for (String email : receivers) {
-        EmailUtil.sendChangeEventMail(getDisplayNameOrFqn(eventSubscription), email, emailMessage);
+
+      // Send using new helper method
+      for (String receiver : receivers) {
+        EmailUtil.sendNotificationEmail(
+            receiver, emailMessage.getSubject(), emailMessage.getHtmlContent());
       }
+
       setSuccessStatus(System.currentTimeMillis());
     } catch (Exception e) {
       setErrorStatus(System.currentTimeMillis(), 500, e.getMessage());

openmetadata-service/src/main/java/org/openmetadata/service/apps/bundles/changeEvent/gchat/GChatPublisher.java

@@ -31,21 +31,23 @@ import org.openmetadata.schema.entity.events.SubscriptionDestination;
 import org.openmetadata.schema.type.ChangeEvent;
 import org.openmetadata.schema.type.Webhook;
 import org.openmetadata.schema.utils.JsonUtils;
+import org.openmetadata.service.Entity;
 import org.openmetadata.service.apps.bundles.changeEvent.Destination;
 import org.openmetadata.service.events.errors.EventPublisherException;
 import org.openmetadata.service.exception.CatalogExceptionMessage;
 import org.openmetadata.service.formatter.decorators.GChatMessageDecorator;
-import org.openmetadata.service.formatter.decorators.MessageDecorator;
+import org.openmetadata.service.jdbi3.NotificationTemplateRepository;
+import org.openmetadata.service.notifications.HandlebarsNotificationMessageEngine;
+import org.openmetadata.service.notifications.channels.NotificationMessage;
+import org.openmetadata.service.notifications.channels.gchat.GChatMessageV2;
 
 @Slf4j
 public class GChatPublisher implements Destination<ChangeEvent> {
-  private final MessageDecorator<GChatMessage> gChatMessageMessageDecorator =
-      new GChatMessageDecorator();
+  private final HandlebarsNotificationMessageEngine messageEngine;
   private final Webhook webhook;
   private final Client client;
 
   @Getter private final SubscriptionDestination subscriptionDestination;
-
   private final EventSubscription eventSubscription;
 
   public GChatPublisher(
@@ -54,10 +56,12 @@ public class GChatPublisher implements Destination<ChangeEvent> {
       this.eventSubscription = eventSubscription;
       this.subscriptionDestination = subscriptionDestination;
       this.webhook = JsonUtils.convertValue(subscriptionDestination.getConfig(), Webhook.class);
-
-      // Build Client
-      client =
+      this.client =
           getClient(subscriptionDestination.getTimeout(), subscriptionDestination.getReadTimeout());
+      this.messageEngine =
+          new HandlebarsNotificationMessageEngine(
+              (NotificationTemplateRepository)
+                  Entity.getEntityRepository(Entity.NOTIFICATION_TEMPLATE));
     } else {
       throw new IllegalArgumentException("GChat Alert Invoked with Illegal Type and Settings.");
     }
@@ -65,15 +69,18 @@ public class GChatPublisher implements Destination<ChangeEvent> {
 
   @Override
   public void sendMessage(ChangeEvent event) throws EventPublisherException {
-
     try {
-      GChatMessage gchatMessage =
-          gChatMessageMessageDecorator.buildOutgoingMessage(
-              getDisplayNameOrFqn(eventSubscription), event);
+      // Generate message using new Handlebars pipeline
+      NotificationMessage message =
+          messageEngine.generateMessage(event, eventSubscription, subscriptionDestination);
+      GChatMessageV2 gchatMessage = (GChatMessageV2) message;
+
+      // Send using existing webhook utilities
       String json = JsonUtils.pojoToJsonIgnoreNull(gchatMessage);
       List<Invocation.Builder> targets =
           getTargetsForWebhookAlert(webhook, subscriptionDestination, client, event, json);
       targets.add(getTarget(client, webhook, json));
+
       for (Invocation.Builder actionTarget : targets) {
         postWebhookMessage(this, actionTarget, gchatMessage);
       }
@@ -90,7 +97,9 @@ public class GChatPublisher implements Destination<ChangeEvent> {
   @Override
   public void sendTestMessage() throws EventPublisherException {
     try {
-      GChatMessage gchatMessage = gChatMessageMessageDecorator.buildOutgoingTestMessage();
+      // Use legacy test message (unchanged)
+      GChatMessage gchatMessage = new GChatMessageDecorator().buildOutgoingTestMessage();
+
       deliverTestWebhookMessage(
           this, getTarget(client, webhook, JsonUtils.pojoToJson(gchatMessage)), gchatMessage);
     } catch (Exception e) {

openmetadata-service/src/main/java/org/openmetadata/service/apps/bundles/changeEvent/msteams/MSTeamsPublisher.java

@@ -31,16 +31,18 @@ import org.openmetadata.schema.entity.events.SubscriptionDestination;
 import org.openmetadata.schema.type.ChangeEvent;
 import org.openmetadata.schema.type.Webhook;
 import org.openmetadata.schema.utils.JsonUtils;
+import org.openmetadata.service.Entity;
 import org.openmetadata.service.apps.bundles.changeEvent.Destination;
 import org.openmetadata.service.events.errors.EventPublisherException;
 import org.openmetadata.service.exception.CatalogExceptionMessage;
 import org.openmetadata.service.formatter.decorators.MSTeamsMessageDecorator;
-import org.openmetadata.service.formatter.decorators.MessageDecorator;
+import org.openmetadata.service.jdbi3.NotificationTemplateRepository;
+import org.openmetadata.service.notifications.HandlebarsNotificationMessageEngine;
+import org.openmetadata.service.notifications.channels.NotificationMessage;
 
 @Slf4j
 public class MSTeamsPublisher implements Destination<ChangeEvent> {
-  private final MessageDecorator<TeamsMessage> teamsMessageFormatter =
-      new MSTeamsMessageDecorator();
+  private final HandlebarsNotificationMessageEngine messageEngine;
   private final Webhook webhook;
   private final Client client;
 
@@ -53,10 +55,12 @@ public class MSTeamsPublisher implements Destination<ChangeEvent> {
       this.eventSubscription = eventSubscription;
       this.subscriptionDestination = subscriptionDestination;
       this.webhook = JsonUtils.convertValue(subscriptionDestination.getConfig(), Webhook.class);
-
-      // Build Client
-      client =
+      this.client =
           getClient(subscriptionDestination.getTimeout(), subscriptionDestination.getReadTimeout());
+      this.messageEngine =
+          new HandlebarsNotificationMessageEngine(
+              (NotificationTemplateRepository)
+                  Entity.getEntityRepository(Entity.NOTIFICATION_TEMPLATE));
     } else {
       throw new IllegalArgumentException("MsTeams Alert Invoked with Illegal Type and Settings.");
     }
@@ -65,12 +69,17 @@ public class MSTeamsPublisher implements Destination<ChangeEvent> {
   @Override
   public void sendMessage(ChangeEvent event) throws EventPublisherException {
     try {
-      TeamsMessage teamsMessage =
-          teamsMessageFormatter.buildOutgoingMessage(getDisplayNameOrFqn(eventSubscription), event);
+      // Generate message using new Handlebars pipeline
+      NotificationMessage message =
+          messageEngine.generateMessage(event, eventSubscription, subscriptionDestination);
+      TeamsMessage teamsMessage = (TeamsMessage) message;
+
+      // Send using existing webhook utilities
       String eventJson = JsonUtils.pojoToJson(teamsMessage);
       List<Invocation.Builder> targets =
           getTargetsForWebhookAlert(webhook, subscriptionDestination, client, event, eventJson);
       targets.add(getTarget(client, webhook, eventJson));
+
       for (Invocation.Builder actionTarget : targets) {
         postWebhookMessage(this, actionTarget, teamsMessage);
       }
@@ -87,7 +96,9 @@ public class MSTeamsPublisher implements Destination<ChangeEvent> {
   @Override
   public void sendTestMessage() throws EventPublisherException {
     try {
-      TeamsMessage teamsMessage = teamsMessageFormatter.buildOutgoingTestMessage();
+      // Use legacy test message (unchanged)
+      TeamsMessage teamsMessage = new MSTeamsMessageDecorator().buildOutgoingTestMessage();
+
       deliverTestWebhookMessage(
           this, getTarget(client, webhook, JsonUtils.pojoToJson(teamsMessage)), teamsMessage);
     } catch (Exception e) {

openmetadata-service/src/main/java/org/openmetadata/service/apps/bundles/changeEvent/slack/SlackEventPublisher.java

@@ -34,17 +34,21 @@ import org.openmetadata.schema.entity.events.SubscriptionDestination;
 import org.openmetadata.schema.type.ChangeEvent;
 import org.openmetadata.schema.type.Webhook;
 import org.openmetadata.schema.utils.JsonUtils;
+import org.openmetadata.service.Entity;
 import org.openmetadata.service.apps.bundles.changeEvent.Destination;
 import org.openmetadata.service.events.errors.EventPublisherException;
 import org.openmetadata.service.exception.CatalogExceptionMessage;
-import org.openmetadata.service.formatter.decorators.MessageDecorator;
 import org.openmetadata.service.formatter.decorators.SlackMessageDecorator;
+import org.openmetadata.service.jdbi3.NotificationTemplateRepository;
+import org.openmetadata.service.notifications.HandlebarsNotificationMessageEngine;
+import org.openmetadata.service.notifications.channels.NotificationMessage;
 
 @Slf4j
 public class SlackEventPublisher implements Destination<ChangeEvent> {
-  private final MessageDecorator<SlackMessage> slackMessageFormatter = new SlackMessageDecorator();
+  private final HandlebarsNotificationMessageEngine messageEngine;
   private final Webhook webhook;
   private final Client client;
+
   @Getter private final SubscriptionDestination subscriptionDestination;
   private final EventSubscription eventSubscription;
 
@@ -54,9 +58,11 @@ public class SlackEventPublisher implements Destination<ChangeEvent> {
       this.eventSubscription = eventSubscription;
       this.subscriptionDestination = subscriptionDest;
       this.webhook = JsonUtils.convertValue(subscriptionDest.getConfig(), Webhook.class);
-
-      // Build Client
-      client = getClient(subscriptionDest.getTimeout(), subscriptionDest.getReadTimeout());
+      this.client = getClient(subscriptionDest.getTimeout(), subscriptionDest.getReadTimeout());
+      this.messageEngine =
+          new HandlebarsNotificationMessageEngine(
+              (NotificationTemplateRepository)
+                  Entity.getEntityRepository(Entity.NOTIFICATION_TEMPLATE));
     } else {
       throw new IllegalArgumentException("Slack Alert Invoked with Illegal Type and Settings.");
     }
@@ -65,14 +71,20 @@ public class SlackEventPublisher implements Destination<ChangeEvent> {
   @Override
   public void sendMessage(ChangeEvent event) throws EventPublisherException {
     try {
-      SlackMessage slackMessage =
-          slackMessageFormatter.buildOutgoingMessage(getDisplayNameOrFqn(eventSubscription), event);
+      // Generate message using new Handlebars pipeline
+      NotificationMessage message =
+          messageEngine.generateMessage(event, eventSubscription, subscriptionDestination);
+      SlackMessage slackMessage = (SlackMessage) message;
 
+      // Convert to JSON and apply snake_case transformation
       String json = JsonUtils.pojoToJsonIgnoreNull(slackMessage);
       json = convertCamelCaseToSnakeCase(json);
+
+      // Send using existing webhook utilities
       List<Invocation.Builder> targets =
           getTargetsForWebhookAlert(webhook, subscriptionDestination, client, event, json);
       targets.add(getTarget(client, webhook, json));
+
       for (Invocation.Builder actionTarget : targets) {
         postWebhookMessage(this, actionTarget, json);
       }
@@ -89,7 +101,8 @@ public class SlackEventPublisher implements Destination<ChangeEvent> {
   @Override
   public void sendTestMessage() throws EventPublisherException {
     try {
-      SlackMessage slackMessage = slackMessageFormatter.buildOutgoingTestMessage();
+      // Use legacy test message (unchanged)
+      SlackMessage slackMessage = new SlackMessageDecorator().buildOutgoingTestMessage();
 
       String json = JsonUtils.pojoToJsonIgnoreNull(slackMessage);
       json = convertCamelCaseToSnakeCase(json);
@@ -102,10 +115,10 @@ public class SlackEventPublisher implements Destination<ChangeEvent> {
   }
 
   /**
-   * Slack messages sent via webhook require some keys in snake_case, while the Slack
-   * app accepts them as they are (camelCase). Using Layout blocks (from com.slack.api.model.block) restricts control over key
+   * Slack messages sent via webhook require some keys in snake_case.
+   * Using Layout blocks (from com.slack.api.model.block) restricts control over key
    * aliases within the class.
-   **/
+   */
   public String convertCamelCaseToSnakeCase(String jsonString) {
     JsonNode rootNode = JsonUtils.readTree(jsonString);
     JsonNode modifiedNode = convertKeys(rootNode);
@@ -127,16 +140,12 @@ public class SlackEventPublisher implements Destination<ChangeEvent> {
                 } else if (fieldName.equals("altText")) {
                   newFieldName = "alt_text";
                 }
-
-                // Recursively convert the keys
                 newNode.set(newFieldName, convertKeys(objectNode.get(fieldName)));
               });
       return newNode;
     } else if (node.isArray()) {
       ArrayNode arrayNode = (ArrayNode) node;
       ArrayNode newArrayNode = JsonUtils.getObjectNode().arrayNode();
-
-      // recursively convert elements
       for (int i = 0; i < arrayNode.size(); i++) {
         newArrayNode.add(convertKeys(arrayNode.get(i)));
       }

openmetadata-service/src/main/java/org/openmetadata/service/util/email/EmailUtil.java

@@ -271,6 +271,30 @@ public class EmailUtil {
     }
   }
 
+  /**
+   * Send notification email with pre-rendered HTML content.
+   * Used by the new Handlebars notification system.
+   *
+   * @param to Recipient email address
+   * @param subject Email subject
+   * @param htmlContent Pre-rendered HTML content (already processed by HandlebarsNotificationMessageEngine)
+   */
+  public static void sendNotificationEmail(String to, String subject, String htmlContent) {
+    if (Boolean.TRUE.equals(getSmtpSettings().getEnableSmtpServer())) {
+      Email email =
+          EmailBuilder.startingBlank()
+              .withSubject(subject)
+              .to(to)
+              .from(getSmtpSettings().getSenderMail())
+              .withHTMLText(htmlContent)
+              .buildEmail();
+
+      sendMail(email, true);
+    } else {
+      LOG.warn(EMAIL_IGNORE_MSG, to);
+    }
+  }
+
   public static void sendInviteMailToAdmin(User user, String password) {
     if (Boolean.TRUE.equals(getSmtpSettings().getEnableSmtpServer())) {